Skip to content

ASoC: codecs: wsa883x: fix pops and clicks

Johan Hovold linux-sound lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: soc-dai: add flag to mute and unmute stream during triggerinclude/sound/soc-dai.h sound/soc/soc-dai.c sound/soc/soc-pcm.c+16 -40 replies
2/2ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flagsound/soc/codecs/wsa883x.c+1 -60 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by.

PatchJohan Hovold
1/2T-b
2/2T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH stable-6.6 0/2] ASoC: codecs: wsa883x: fix pops and clicks

This is a backport of commits

	0220575e65a ("ASoC: soc-dai: add flag to mute and unmute stream during trigger")
	805ce81826c8 ("ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag")

which specifically fix a loud crackling noise when starting a stream on the Lenovo ThinkPad X13s.

These backports should apply to any stable tree which already has commit 3efcb471f871 ("ASoC: soc-pcm.c: Make sure DAI parameters cleared if the DAI becomes inactive") backported (e.g. 6.6.2 and 6.5.12).

Note that the interaction of these commits resulted in a bad merge in mainline which is fixed up here:

	https://lore.kernel.org/lkml/[email protected]/

Johan

Srinivas Kandagatla (2):
ASoC: soc-dai: add flag to mute and unmute stream during trigger
ASoC: codecs: wsa883x: make use of new mute_unmute_on_trigger flag

 include/sound/soc-dai.h    |  1 +
 sound/soc/codecs/wsa883x.c |  7 +------
 sound/soc/soc-dai.c        |  7 +++++++
 sound/soc/soc-pcm.c        | 12 ++++++++----
 4 files changed, 17 insertions(+), 10 deletions(-)
Signature · 1 line
2.41.0