Skip to content

Conver net selftests to run in unique namespace (Part 1)

Hangbin Liu linux-kselftest netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest14 patches 6 repliesApplied 14/14
  2. v214 patches 8 repliesSuperseded
  3. v138 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- Convert all ip netns del to cleanup_ns (Justin Iurman)

Patches in v3 All 14 applied

#Subject and filesSizeRepliesApplied
1/14selftests/net: add lib.shtools/testing/selftests/net/Makefile tools/testing/selftests/net/forwarding/lib.sh tools/testing/selftests/net/lib.sh+87 -276 repliesApplied
2/14selftests/net: convert arp_ndisc_evict_nocarrier.sh to run it in unique namespacetools/testing/selftests/net/arp_ndisc_evict_nocarrier.sh+16 -300 repliesApplied
3/14selftests/net: specify the interface when do arpingtools/testing/selftests/net/arp_ndisc_untracked_subnets.sh+1 -10 repliesApplied
4/14selftests/net: convert arp_ndisc_untracked_subnets.sh to run it in unique namespacetools/testing/selftests/net/arp_ndisc_untracked_subnets.sh+6 -120 repliesApplied
5/14selftests/net: convert cmsg tests to make them run in unique namespacetools/testing/selftests/net/cmsg_ipv6.sh tools/testing/selftests/net/cmsg_so_mark.sh tools/testing/selftests/net/cmsg_time.sh+12 -120 repliesApplied
6/14selftests/net: convert drop_monitor_tests.sh to run it in unique namespacetools/testing/selftests/net/drop_monitor_tests.sh+11 -100 repliesApplied
7/14selftests/net: convert traceroute.sh to run it in unique namespacetools/testing/selftests/net/traceroute.sh+36 -460 repliesApplied
8/14selftests/net: convert icmp_redirect.sh to run it in unique namespacetools/testing/selftests/net/icmp_redirect.sh+88 -940 repliesApplied
9/14sleftests/net: convert icmp.sh to run it in unique namespacetools/testing/selftests/net/icmp.sh+4 -60 repliesApplied
10/14selftests/net: convert ioam6.sh to run it in unique namespacetools/testing/selftests/net/ioam6.sh+121 -1260 repliesApplied
11/14selftests/net: convert l2tp.sh to run it in unique namespacetools/testing/selftests/net/l2tp.sh+62 -680 repliesApplied
12/14selftests/net: convert ndisc_unsolicited_na_test.sh to run it in unique namespacetools/testing/selftests/net/ndisc_unsolicited_na_test.sh+7 -120 repliesApplied
13/14selftests/net: convert sctp_vrf.sh to run it in unique namespacetools/testing/selftests/net/sctp_vrf.sh+3 -90 repliesApplied
14/14selftests/net: convert unicast_extensions.sh to run it in unique namespacetools/testing/selftests/net/unicast_extensions.sh+46 -530 repliesApplied

Reviews trailers per patch

13 of 14 patches have a Reviewed-by or Acked-by.

PatchPetr MachataDavid AhernJustin IurmanJames ChapmanXin Long
1/14R-b
2/14A-b
3/14
4/14A-b
5/14A-b
6/14A-b
7/14A-b
8/14A-b
9/14A-b
10/14A-b R-b
11/14A-b R-b
12/14A-b
13/14A-b R-b
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v3 thread

Cover letter [PATCHv3 net-next 00/14] Conver net selftests to run in unique namespace (Part 1)

As Guillaume pointed, many selftests create namespaces with very common names (like "client" or "server") or even (partially) run directly in init_net. This makes these tests prone to failure if another namespace with the same name already exists. It also makes it impossible to run several instances of these tests in parallel.

This patch set intend to conver all the net selftests to run in unique namespace, so we can update the selftest freamwork to run all tests in it's own namespace in parallel. After update, we only need to wait for the test which need longest time.

As the total patch set is too large. I break it to severl parts. This is the first part.

v2 -> v3:
- Convert all ip netns del to cleanup_ns (Justin Iurman)

v1 -> v2:
- Split the large patch set to small parts for easy review (Paolo Abeni)
- Move busywait from forwarding/lib.sh to net/lib.sh directly (Petr Machata)
- Update setup_ns/cleanup_ns struct (Petr Machata)
- Remove default trap in lib.sh (Petr Machata)

Hangbin Liu (14):
selftests/net: add lib.sh
selftests/net: convert arp_ndisc_evict_nocarrier.sh to run it in
unique namespace
selftests/net: specify the interface when do arping selftests/net: convert arp_ndisc_untracked_subnets.sh to run it in
unique namespace
selftests/net: convert cmsg tests to make them run in unique namespace selftests/net: convert drop_monitor_tests.sh to run it in unique
namespace
selftests/net: convert traceroute.sh to run it in unique namespace selftests/net: convert icmp_redirect.sh to run it in unique namespace sleftests/net: convert icmp.sh to run it in unique namespace selftests/net: convert ioam6.sh to run it in unique namespace selftests/net: convert l2tp.sh to run it in unique namespace selftests/net: convert ndisc_unsolicited_na_test.sh to run it in
unique namespace
selftests/net: convert sctp_vrf.sh to run it in unique namespace selftests/net: convert unicast_extensions.sh to run it in unique
namespace

 tools/testing/selftests/net/Makefile          |   2 +-
 .../net/arp_ndisc_evict_nocarrier.sh          |  46 ++--
 .../net/arp_ndisc_untracked_subnets.sh        |  20 +-
 tools/testing/selftests/net/cmsg_ipv6.sh      |  10 +-
 tools/testing/selftests/net/cmsg_so_mark.sh   |   7 +-
 tools/testing/selftests/net/cmsg_time.sh      |   7 +-
 .../selftests/net/drop_monitor_tests.sh       |  21 +-
 tools/testing/selftests/net/forwarding/lib.sh |  27 +-
 tools/testing/selftests/net/icmp.sh           |  10 +-
 tools/testing/selftests/net/icmp_redirect.sh  | 182 +++++++------
 tools/testing/selftests/net/ioam6.sh          | 247 +++++++++---------
 tools/testing/selftests/net/l2tp.sh           | 130 +++++----
 tools/testing/selftests/net/lib.sh            |  85 ++++++
 .../net/ndisc_unsolicited_na_test.sh          |  19 +-
 tools/testing/selftests/net/sctp_vrf.sh       |  12 +-
 tools/testing/selftests/net/traceroute.sh     |  82 +++---
 .../selftests/net/unicast_extensions.sh       |  99 ++++---
 17 files changed, 500 insertions(+), 506 deletions(-)
 create mode 100644 tools/testing/selftests/net/lib.sh
Signature · 1 line
2.43.0