Skip to content

ASoC: SOF: Extend the enabled DSP core handling

Peter Ujfalusi alsa-devel linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: SOF: ipc4-topology: Add core_mask in struct snd_sof_pipelinesound/soc/sof/ipc3-topology.c sound/soc/sof/ipc4-topology.c sound/soc/sof/sof-audio.h+13 -00 replies
2/2ASoC: SOF: sof-audio: Modify logic for enabling/disabling topology coressound/soc/sof/sof-audio.c+41 -240 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartPéter Ujfalusi
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] ASoC: SOF: Extend the enabled DSP core handling

Hi,

In the current code, we enable a widget core when it is set up and disable it when it is freed. This is problematic with IPC4 because widget free is essentially a NOP and all widgets are freed in the firmware when the pipeline is deleted. This results in a crash during pipeline deletion when one of it's widgets is scheduled to run on a secondary core and is powered off when widget is freed. So, change the logic to enable all cores needed by all the modules in a pipeline when the pipeline widget is set up and disable them after the pipeline widget is freed.

Regards,
Peter
---
Ranjani Sridharan (2):
ASoC: SOF: ipc4-topology: Add core_mask in struct snd_sof_pipeline
ASoC: SOF: sof-audio: Modify logic for enabling/disabling topology
cores

 sound/soc/sof/ipc3-topology.c |  2 ++
 sound/soc/sof/ipc4-topology.c |  9 +++++
 sound/soc/sof/sof-audio.c     | 65 ++++++++++++++++++++++-------------
 sound/soc/sof/sof-audio.h     |  2 ++
 4 files changed, 54 insertions(+), 24 deletions(-)
Signature · 1 line
2.42.1