ASoC: SOF: Extend the enabled DSP core handling
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ASoC: SOF: ipc4-topology: Add core_mask in struct snd_sof_pipelinesound/ sound/ sound/ | +13 | 0 replies | |
| 2/2 | ASoC: SOF: sof-audio: Modify logic for enabling/disabling topology coressound/ | +41 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Pierre-Louis Bossart | Péter Ujfalusi |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] ASoC: SOF: Extend the enabled DSP core handling
Hi,
In the current code, we enable a widget core when it is set up and disable it when it is freed. This is problematic with IPC4 because widget free is essentially a NOP and all widgets are freed in the firmware when the pipeline is deleted. This results in a crash during pipeline deletion when one of it's widgets is scheduled to run on a secondary core and is powered off when widget is freed. So, change the logic to enable all cores needed by all the modules in a pipeline when the pipeline widget is set up and disable them after the pipeline widget is freed.
Regards,
Peter
---
Ranjani Sridharan (2):
ASoC: SOF: ipc4-topology: Add core_mask in struct snd_sof_pipeline
ASoC: SOF: sof-audio: Modify logic for enabling/disabling topology
cores
sound/soc/sof/ipc3-topology.c | 2 ++ sound/soc/sof/ipc4-topology.c | 9 +++++ sound/soc/sof/sof-audio.c | 65 ++++++++++++++++++++++------------- sound/soc/sof/sof-audio.h | 2 ++ 4 files changed, 54 insertions(+), 24 deletions(-)
Signature · 1 line
2.42.1