Skip to content

reparse points work

Paulo Alcantara linux-cifs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 2 repliesIn review
  2. v18 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Fix missing mode bits for SMB symlinks (reported by Steve)
- Fix uninitialised var warnings (reported by kernel test robot)
- Add dentry reval optimisation for SMB3 POSIX query info as well

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9smb: client: extend smb2_compound_op() to accept more commandsfs/smb/client/cifsglob.h fs/smb/client/smb2inode.c+406 -3880 replies
2/9smb: client: allow creating special files via reparse pointsfs/smb/client/cifsproto.h fs/smb/client/dir.c fs/smb/client/file.c +7 more+256 -600 replies
3/9smb: client: allow creating symlinks via reparse pointsfs/smb/client/cifsglob.h fs/smb/client/link.c fs/smb/client/smb2ops.c+86 -50 replies
4/9smb: client: optimise reparse point queryingfs/smb/client/cifsglob.h fs/smb/client/cifsproto.h fs/smb/client/inode.c +3 more+118 -310 replies
5/9smb: client: fix renaming of reparse pointsfs/smb/client/cifsglob.h fs/smb/client/cifsproto.h fs/smb/client/cifssmb.c +3 more+63 -370 replies
6/9smb: client: fix hardlinking of reparse pointsfs/smb/client/cifsglob.h fs/smb/client/cifsproto.h fs/smb/client/cifssmb.c +3 more+44 -270 replies
7/9smb: client: cleanup smb2_query_reparse_point()fs/smb/client/smb2inode.c fs/smb/client/smb2ops.c fs/smb/client/smb2proto.h+39 -1330 replies
8/9smb: client: optimise dentry revalidation for reparse pointsfs/smb/client/inode.c fs/smb/client/smb2inode.c+19 -70 replies
9/9smb: client: fix missing mode bits for SMB symlinksfs/smb/client/inode.c+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/9] reparse points work

Hi Steve,

This series contains reparse point fixes and improvements for SMB2+:

- Add support for creating character/block devices, sockets and fifos via NFS reparse points by default.

- Add support for creating SMB symlinks via IO_REPARSE_TAG_SYMLINK reparse points.

- smb2_compound_op()

* allow up to MAX_COMPOUND(5) commands in a single compound request
* introduce SMB2_OP_{GET,SET}_REPARSE commands

- Optimisations for dentry revalidation and read/write of reparse points by reducing number of roundtrips.

- Fix renaming and hardlinking of reparse points

For people who pass 'mfsymlinks' and 'sfu' mount options, the implementation is expected to avoid creating reparse points at all.

Volker Lendecke had suggested trying to create both SMB symlink and mfsymlink in a single compound request but this series doesn't have it. It could be implemented later.

---
Changes in v2:
- Fix missing mode bits for SMB symlinks (reported by Steve)
- Fix uninitialised var warnings (reported by kernel test robot)
- Add dentry reval optimisation for SMB3 POSIX query info as well

---
Paulo Alcantara (9):
smb: client: extend smb2_compound_op() to accept more commands
smb: client: allow creating special files via reparse points
smb: client: allow creating symlinks via reparse points
smb: client: optimise reparse point querying
smb: client: fix renaming of reparse points
smb: client: fix hardlinking of reparse points
smb: client: cleanup smb2_query_reparse_point()
smb: client: optimise dentry revalidation for reparse points
smb: client: fix missing mode bits for SMB symlinks

 fs/smb/client/cifsglob.h  |   47 +-
 fs/smb/client/cifsproto.h |   30 +-
 fs/smb/client/cifssmb.c   |   17 +-
 fs/smb/client/dir.c       |    7 +-
 fs/smb/client/file.c      |   10 +-
 fs/smb/client/inode.c     |   98 ++--
 fs/smb/client/link.c      |   29 +-
 fs/smb/client/smb2glob.h  |   26 +-
 fs/smb/client/smb2inode.c | 1054 ++++++++++++++++++++++---------------
 fs/smb/client/smb2ops.c   |  297 ++++++-----
 fs/smb/client/smb2proto.h |   29 +-
 fs/smb/client/trace.h     |    7 +-
 12 files changed, 997 insertions(+), 654 deletions(-)
Signature · 1 line
2.43.0