Skip to content

ALSA/ASoC/SOF: SSP dev_type support

Peter Ujfalusi alsa-devel linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ALSA: hda: intel-nhlt: add intel_nhlt_ssp_device_type() functioninclude/sound/intel-nhlt.h sound/hda/intel-nhlt.c+36 -00 replies
2/2ASoC: SOF: ipc4-topology: support NHLT device typesound/soc/sof/ipc4-topology.c+16 -31 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPéter UjfalusiPierre-Louis BossartBard LiaoMark Brown
1/2R-b R-b R-b
2/2R-b R-b R-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] ALSA/ASoC/SOF: SSP dev_type support

Hi,

SOF always passed 0 as dev_type to intel_nhlt_get_endpoint_blob() when looking up the blob from the NHLT table. This causes issues since alsa-utils commit 3a47ef2487ed ("topology: nhlt: intel: support more device types and directions")

The dev_type is no longer always 0 in the topology embedded NHLT table resulting lookup failures for analog codecs since they will have dev_type=4.

With SOF the dev_type is not used, we always use the SSP port index for looking up the configuration blob.

The solution for the issue is to fetch the dev_type for the SSP port and feed it back to the intel_nhlt_get_endpoint_blob() to be able to find the configuration regardless of the assigned dev_type.

Regards,
Peter
---
Brent Lu (2):
ALSA: hda: intel-nhlt: add intel_nhlt_ssp_device_type() function
ASoC: SOF: ipc4-topology: support NHLT device type

 include/sound/intel-nhlt.h    | 10 ++++++++++
 sound/hda/intel-nhlt.c        | 26 ++++++++++++++++++++++++++
 sound/soc/sof/ipc4-topology.c | 19 ++++++++++++++++---
 3 files changed, 52 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0