Skip to content

ASoC: SOF: ipc4-topology: Correct IPC message struct layouts

Peter Ujfalusi alsa-devel linux-sound 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ASoC: SOF: ipc4-topology: Correct data structures for the SRC modulesound/soc/sof/ipc4-topology.c sound/soc/sof/ipc4-topology.h+23 -140 replies
2/2ASoC: SOF: ipc4-topology: Correct data structures for the GAIN modulesound/soc/sof/ipc4-control.c sound/soc/sof/ipc4-topology.c sound/soc/sof/ipc4-topology.h+38 -310 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartBard LiaoRanjani Sridharan
1/2R-b R-b R-b
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/2] ASoC: SOF: ipc4-topology: Correct IPC message struct layouts

Hi,

The SRC and GAIN module defined it's kernel side private struct in a way that part of that is used as IPC message without making sure of proper alignment and padding, which happens to work but it is better to be not 'clever' about these sort of things.

The two patch corects this overlooked detail.

Regards,
Peter
---
Peter Ujfalusi (2):
ASoC: SOF: ipc4-topology: Correct data structures for the SRC module
ASoC: SOF: ipc4-topology: Correct data structures for the GAIN module

 sound/soc/sof/ipc4-control.c  | 20 +++++++-------
 sound/soc/sof/ipc4-topology.c | 52 +++++++++++++++++------------------
 sound/soc/sof/ipc4-topology.h | 34 +++++++++++++++++------
 3 files changed, 61 insertions(+), 45 deletions(-)
Signature · 1 line
2.43.0