Skip to content

libfc: fixup command abort handling

[email protected] linux-scsi 1 version Applied

Status from this message: Applied to 6.8/scsi-queue, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 4 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/3libfc: don't schedule abort twicedrivers/scsi/libfc/fc_fcp.c+11 -51 reply
2/3libfc: Fixup timeout error in fc_fcp_rec_error()drivers/scsi/libfc/fc_fcp.c+1 -11 reply
3/3libfc: map FC_TIMED_OUT to DID_TIME_OUTdrivers/scsi/libfc/fc_fcp.c+2 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] libfc: fixup command abort handling

From: Hannes Reinecke <[email protected]>

Hi all,

when testing command timeout with the help of XDP I found that scsi_try_to_abort_cmd() would always return 'SUCCESS' for FCoE, even if no commands could be sent over the wire. Which is not only surprising, but also can lead to data corruption as commands were never aborted.
Root cause was that aborts had been sent twice, once from FC error recovery and once from SCSI EH, with the former inducing the latter to assume that the command was already aborted.

As usual, comments and reviews are welcome.

Hannes Reinecke (3):
libfc: don't schedule abort twice
libfc: Fixup timeout error in fc_fcp_rec_error()
libfc: map FC_TIMED_OUT to DID_TIME_OUT

 drivers/scsi/libfc/fc_fcp.c | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)
Signature · 1 line
2.35.3