Skip to content

Several fixes around recipetool appendsrcfile(s) and oe.recipeutils.bbappend_recipe

Julien Stephan openembedded-core 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest10 patches 1 replyIn review
  2. v29 patches 2 repliesSuperseded
  3. v18 patches 3 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10recipetool: appendsrcfile(s): add dry-run modescripts/lib/recipetool/append.py+32 -10 replies
2/10recipeutils: bbappend_recipe: fix undefined variablemeta/lib/oe/recipeutils.py+1 -00 replies
3/10recipeutils: bbappend_recipe: fix docstringmeta/lib/oe/recipeutils.py+5 -30 replies
4/10recipeutils: bbappend_recipe: add a way to specify the name of the file to addmeta/lib/oe/recipeutils.py+6 -10 replies
5/10recipeutils: bbappend_recipe: remove old srcuri entry if parameters are differentmeta/lib/oe/recipeutils.py+8 -00 replies
6/10recipetool: appendsrcfile(s): use params instead of extralinemeta/lib/oeqa/selftest/cases/recipetool.py scripts/lib/recipetool/append.py+23 -240 replies
7/10recipeutils: bbappend_recipe: allow to patch the recipe itselfmeta/lib/oe/recipeutils.py+25 -100 replies
8/10recipetool: appendsrcfile(s): add a mode to update the recipe itselfscripts/lib/recipetool/append.py+5 -10 replies
9/10oeqa/selftest/recipetool: appendsrfile: add test for machinemeta/lib/oeqa/selftest/cases/recipetool.py+38 -61 reply
10/10oeqa/selftest/recipetool: appendsrc: add test for update modemeta/lib/oeqa/selftest/cases/recipetool.py+28 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/10] Several fixes around recipetool appendsrcfile(s) and oe.recipeutils.bbappend_recipe

Hi all,

I was trying to use recipetool appendsrcfile to add a file to a recipe and I noticed several issues:
* -m is not correctly supported
* recipetool appendsrfile(s) are missing a usefull dry-run mode
* appendsrc function relies on oe.recipeutils.bbappend_recipe but
duplicates some code: it constructs itself the new src_uri entry
although oe.recipeutils.bbappend_recipe is already doing it
* we are lacking a mode to patch the recipe itself

So this series tries to fix the issues above, fix the selftest accordingly and add new test for -m and for "patch mode" (update recipe) and also add a way to specify the name of the file to add (in oe.recipeutils.bbappend_recipe)

Improvements from v2:
- rebase on latest master fix conflict and update the way to add newname in bbappend_recipe()

Improvements from v1:
- in bbappend_recipe function remove old entry if an entry with different parameters already exists to avoid duplicate entries with different parameters

Link to v1: https://lists.openembedded.org/g/openembedded-core/message/191544
Link to v2: https://lists.openembedded.org/g/openembedded-core/message/191744

Julien Stephan (10):
recipetool: appendsrcfile(s): add dry-run mode
recipeutils: bbappend_recipe: fix undefined variable
recipeutils: bbappend_recipe: fix docstring
recipeutils: bbappend_recipe: add a way to specify the name of the
file to add
recipeutils: bbappend_recipe: remove old srcuri entry if parameters
are different
recipetool: appendsrcfile(s): use params instead of extraline
recipeutils: bbappend_recipe: allow to patch the recipe itself
recipetool: appendsrcfile(s): add a mode to update the recipe itself oeqa/selftest/recipetool: appendsrfile: add test for machine oeqa/selftest/recipetool: appendsrc: add test for update mode

 meta/lib/oe/recipeutils.py                 | 57 +++++++++++----
 meta/lib/oeqa/selftest/cases/recipetool.py | 83 +++++++++++++++++++---
 scripts/lib/recipetool/append.py           | 63 +++++++++++-----
 3 files changed, 164 insertions(+), 39 deletions(-)
Signature · 1 line
2.42.0