Skip to content

Add T114 video support

Svyatoslav Ryhel u-boot 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest18 patches 28 repliesIn review
  2. v513 patches 0 repliesSuperseded
  3. v413 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v310 patches0 repliesSuperseded
v29 patches0 repliesSuperseded
v13 patches0 repliesSuperseded

Changes in v6 from the cover letter

- backlight enable moved to the last step of setup for DSI
- parameterized V- and H-sync polarities
- added framebuffer clearing on probe to avoid glitches
- backlight enable moved after DC is fully configured
- fixed printing framebuffer pointer instead of address
- moved scdiv calculation to tegra DSI if it is used

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18video: tegra20: dc: diverge DC per-SOCarch/arm/dts/tegra114-u-boot.dtsi arch/arm/dts/tegra114.dtsi arch/arm/dts/tegra30-u-boot.dtsi +4 more+133 -383 replies
2/18video: tegra20: dc: fix image shift on rotated panelsdrivers/video/tegra20/tegra-dc.c+2 -21 reply
3/18video: tegra20: consolidate DC headerarch/arm/include/asm/arch-tegra/dc.h arch/arm/include/asm/arch-tegra114/display.h arch/arm/include/asm/arch-tegra20/display.h +5 more+46 -951 reply
4/18video: tegra20: dc: pass DC id to internal devicesdrivers/video/tegra20/tegra-dc.c drivers/video/tegra20/tegra-dc.h+9 -04 replies
5/18video: tegra20: dc: add PLLD2 parent supportdrivers/video/tegra20/tegra-dc.c+6 -01 reply
6/18video: tegra20: dc: add reset supportdrivers/video/tegra20/tegra-dc.c+17 -04 replies
7/18video: tegra20: dc: add powergatedrivers/video/tegra20/tegra-dc.c+27 -01 reply
8/18video: tegra20: dc: configure behavior if PLLD/D2 is useddrivers/video/tegra20/tegra-dc.c drivers/video/tegra20/tegra-dc.h drivers/video/tegra20/tegra-dsi.c+36 -131 reply
9/18video: tegra20: dc: fix printing of framebuffer addressdrivers/video/tegra20/tegra-dc.c+1 -11 reply
10/18video: tegra20: dc: enable backlight after DC is configureddrivers/video/tegra20/tegra-dc.c+1 -71 reply
11/18video: tegra20: dc: clean framebuffer memory blockdrivers/video/tegra20/tegra-dc.c+5 -01 reply
12/18video: tegra20: dc: parameterize V- and H-sync polaritiesarch/arm/include/asm/arch-tegra/dc.h drivers/video/tegra20/tegra-dc.c+25 -21 reply
13/18video: tegra20: add MIPI calibration driverdrivers/video/tegra20/Makefile drivers/video/tegra20/tegra-mipi.c+189 -11 reply
14/18video: tegra20: dsi: add T114 supportdrivers/video/tegra20/tegra-dsi.c drivers/video/tegra20/tegra-dsi.h+96 -61 reply
15/18video: tegra20: dsi: add reset supportdrivers/video/tegra20/tegra-dsi.c+14 -01 reply
16/18video: tegra20: dsi: remove pre-configurationdrivers/video/tegra20/tegra-dsi.c+0 -21 reply
17/18video: tegra20: dsi: set correct fifo depthdrivers/video/tegra20/tegra-dsi.c+1 -11 reply
18/18video: tegra20: dsi: use set_backlight for backlight onlydrivers/video/tegra20/tegra-dsi.c+4 -61 reply

Reviews trailers per patch

13 of 18 patches have a Reviewed-by or Acked-by.

PatchRobert EckelmannAgneliAndreas Westman DorcsakIon AgorriaSvyatoslav RyhelJonas SchwöbelThierry Reding
1/18T-b T-b T-b T-b T-b
2/18T-b R-b
3/18T-b T-b T-b T-b T-b R-b
4/18T-b T-b T-b T-b T-b
5/18T-b T-b T-b T-b T-b R-b
6/18T-b T-b T-b T-b T-b
7/18R-b
8/18T-b T-b T-b T-b A-b
9/18
10/18R-b
11/18R-b
12/18R-b
13/18T-b R-b
14/18T-b T-b R-b
15/18T-b T-b
16/18T-b T-b R-b
17/18T-b T-b R-b
18/18R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/18] Add T114 video support

T114 is not that different from T30 and all T30 drivers will work on T114 as well with some adjustments.

Patches propose general improvements for existing Tegra DC and DSI drivers as well Tegra 114 video support (experimentl).

Commits pass buildman for tegra.

---
Changes from v5:
- backlight enable moved to the last step of setup for DSI
- parameterized V- and H-sync polarities
- added framebuffer clearing on probe to avoid glitches
- backlight enable moved after DC is fully configured
- fixed printing framebuffer pointer instead of address
- moved scdiv calculation to tegra DSI if it is used

Changes from v4:
- fixed typo in max rate to be divided (400KHz > 400MHz)

Changes from v3:
- fixed the clock divider calculation if PLLD/D2 is used
- removed unnecessary pre-configuration
- set correct video FIFO depth for DSI

Changes from v2:
- fixed image distortion on devices with 180deg rotation

Changes from v1:
- reworked patchset entirely
- diverged DC configuration per-SOC
- consolidated dc headers from different SOC gen
- initial support of DC detection (tegra has 2 DC)
- added PLLD2 support, resets and powergating
- added T114+ MIPI calibration
- added DSI detection (tegra has 2 DSI) and resets
---

Jonas Schwöbel (6):
video: tegra20: dc: fix printing of framebuffer address
video: tegra20: dc: enable backlight after DC is configured
video: tegra20: dc: clean framebuffer memory block
video: tegra20: dsi: remove pre-configuration
video: tegra20: dsi: set correct fifo depth
video: tegra20: dsi: use set_backlight for backlight only

Svyatoslav Ryhel (12):
video: tegra20: dc: diverge DC per-SOC
video: tegra20: dc: fix image shift on rotated panels
video: tegra20: consolidate DC header
video: tegra20: dc: pass DC id to internal devices
video: tegra20: dc: add PLLD2 parent support
video: tegra20: dc: add reset support
video: tegra20: dc: add powergate
video: tegra20: dc: configure behavior if PLLD/D2 is used
video: tegra20: dc: parameterize V- and H-sync polarities
video: tegra20: add MIPI calibration driver
video: tegra20: dsi: add T114 support
video: tegra20: dsi: add reset support

 arch/arm/dts/tegra114-u-boot.dtsi             |  13 +
 arch/arm/dts/tegra114.dtsi                    |   4 +-
 arch/arm/dts/tegra30-u-boot.dtsi              |   4 +
 arch/arm/dts/tegra30.dtsi                     |   2 +-
 arch/arm/include/asm/arch-tegra/dc.h          |  13 +-
 arch/arm/include/asm/arch-tegra114/pwm.h      |  13 +
 arch/arm/include/asm/arch-tegra20/display.h   |  28 --
 arch/arm/include/asm/arch-tegra30/display.h   |  28 --
 drivers/video/tegra20/Makefile                |   2 +-
 drivers/video/tegra20/tegra-dc.c              | 239 +++++++++++++-----
 drivers/video/tegra20/tegra-dc.h              |  45 ++++
 drivers/video/tegra20/tegra-dsi.c             | 122 ++++++++-
 .../video/tegra20/tegra-dsi.h                 |  24 +-
 drivers/video/tegra20/tegra-mipi.c            | 188 ++++++++++++++
 drivers/video/tegra20/tegra-pwm-backlight.c   |   3 +-
 15 files changed, 583 insertions(+), 145 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-tegra114/pwm.h
 delete mode 100644 arch/arm/include/asm/arch-tegra20/display.h
 delete mode 100644 arch/arm/include/asm/arch-tegra30/display.h
 create mode 100644 drivers/video/tegra20/tegra-dc.h
 rename arch/arm/include/asm/arch-tegra30/dsi.h => drivers/video/tegra20/tegra-dsi.h (90%)
 create mode 100644 drivers/video/tegra20/tegra-mipi.c
Signature · 1 line
2.40.1