Skip to content

Clean up perf mem

[email protected] linux-arm-kernel linux-perf-users lkml 4 versions – Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 5 repliesApplied
  2. v37 patches 16 repliesSuperseded
  3. v25 patches 24 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v16 patches13 repliesSuperseded

Changes in v4 from the cover letter

- Fix the powerPC building error (Kajol Jain)
- The s390 does not support perf mem. Remove the code. (Thomas)
- Add reviewed-by and tested-by from Kajol Jain for patch 1 and 2
- Add tested-by from Leo

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/7perf mem: Add mem_events into the supported perf_pmutools/perf/arch/arm/util/pmu.c tools/perf/arch/arm64/util/mem-events.c tools/perf/arch/arm64/util/mem-events.h +7 more+44 -70 replies
2/7perf mem: Clean up perf_mem_events__ptr()tools/perf/arch/arm64/util/mem-events.c tools/perf/arch/x86/util/mem-events.c tools/perf/builtin-c2c.c +3 more+104 -920 replies
3/7perf mem: Clean up perf_mem_events__name()tools/perf/arch/arm64/util/mem-events.c tools/perf/arch/powerpc/util/Build tools/perf/arch/powerpc/util/mem-events.c +7 more+97 -1070 replies
4/7perf mem: Clean up perf_mem_event__supported()tools/perf/arch/arm64/util/mem-events.c tools/perf/arch/powerpc/util/mem-events.c tools/perf/arch/x86/util/mem-events.c +2 more+31 -290 replies
5/7perf mem: Clean up is_mem_loads_aux_event()tools/perf/arch/x86/util/mem-events.c tools/perf/util/mem-events.c+16 -210 replies
6/7perf mem: Clean up perf_mem_events__record_args()tools/perf/builtin-c2c.c tools/perf/builtin-mem.c tools/perf/util/mem-events.c +1 more+17 -531 reply
7/7perf mem: Clean up perf_pmus__num_mem_pmus()tools/perf/arch/x86/util/pmu.c tools/perf/builtin-c2c.c tools/perf/builtin-mem.c +4 more+17 -191 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchIan RogersKajol JainRavi BangoriaLeo Yan
1/7R-b R-b T-b T-b T-b
2/7R-b R-b T-b T-b
3/7R-b T-b T-b
4/7R-b T-b T-b
5/7R-b T-b T-b
6/7R-b T-b
7/7R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH V4 0/7] Clean up perf mem

From: Kan Liang <[email protected]>

Changes since V3:
- Fix the powerPC building error (Kajol Jain)
- The s390 does not support perf mem. Remove the code. (Thomas)
- Add reviewed-by and tested-by from Kajol Jain for patch 1 and 2
- Add tested-by from Leo

Changes since V2:
- Fix the Arm64 building error (Leo)
- Add two new patches to clean up perf_mem_events__record_args() and perf_pmus__num_mem_pmus() (Leo)

Changes since V1:
- Fix strcmp of PMU name checking (Ravi)
- Fix "/," typo (Ian)
- Rename several functions with perf_pmu__mem_events prefix. (Ian)
- Fold the header removal patch into the patch where the cleanups made. (Arnaldo)
- Add reviewed-by and tested-by from Ian and Ravi

As discussed in the below thread, the patch set is to clean up perf mem.
https://lore.kernel.org/lkml/[email protected]/

Introduce generic functions perf_mem_events__ptr(), perf_mem_events__name() ,and is_mem_loads_aux_event() to replace the ARCH specific ones.
Simplify the perf_mem_event__supported().

Only keeps the ARCH-specific perf_mem_events array in the corresponding mem-events.c for each ARCH.

There is no functional change.

The patch set touches almost all the ARCHs, Intel, AMD, ARM, Power and etc. But I can only test it on two Intel platforms.
Please give it try, if you have machines with other ARCHs.

Here are the test results:
Intel hybrid machine:

$perf mem record -e list
ldlat-loads : available
ldlat-stores : available

$perf mem record -e ldlat-loads -v --ldlat 50
calling: record -e cpu_atom/mem-loads,ldlat=50/P -e cpu_core/mem-loads,ldlat=50/P

$perf mem record -v
calling: record -e cpu_atom/mem-loads,ldlat=30/P -e cpu_atom/mem-stores/P -e cpu_core/mem-loads,ldlat=30/P -e cpu_core/mem-stores/P

$perf mem record -t store -v
calling: record -e cpu_atom/mem-stores/P -e cpu_core/mem-stores/P

Intel SPR:
$perf mem record -e list
ldlat-loads : available
ldlat-stores : available

$perf mem record -e ldlat-loads -v --ldlat 50
calling: record -e {cpu/mem-loads-aux/,cpu/mem-loads,ldlat=50/}:P

$perf mem record -v
calling: record -e {cpu/mem-loads-aux/,cpu/mem-loads,ldlat=30/}:P -e cpu/mem-stores/P

$perf mem record -t store -v
calling: record -e cpu/mem-stores/P

Kan Liang (7):
perf mem: Add mem_events into the supported perf_pmu perf mem: Clean up perf_mem_events__ptr() perf mem: Clean up perf_mem_events__name() perf mem: Clean up perf_mem_event__supported() perf mem: Clean up is_mem_loads_aux_event() perf mem: Clean up perf_mem_events__record_args() perf mem: Clean up perf_pmus__num_mem_pmus()

 tools/perf/arch/arm/util/pmu.c            |   3 +
 tools/perf/arch/arm64/util/mem-events.c   |  39 +---
 tools/perf/arch/arm64/util/mem-events.h   |   7 +
 tools/perf/arch/powerpc/util/Build        |   1 +
 tools/perf/arch/powerpc/util/mem-events.c |  16 +-
 tools/perf/arch/powerpc/util/mem-events.h |   7 +
 tools/perf/arch/powerpc/util/pmu.c        |  12 ++
 tools/perf/arch/x86/util/mem-events.c     |  99 ++--------
 tools/perf/arch/x86/util/mem-events.h     |  10 +
 tools/perf/arch/x86/util/pmu.c            |  19 +-
 tools/perf/builtin-c2c.c                  |  45 ++---
 tools/perf/builtin-mem.c                  |  48 ++---
 tools/perf/util/mem-events.c              | 217 +++++++++++++---------
 tools/perf/util/mem-events.h              |  19 +-
 tools/perf/util/pmu.c                     |   4 +-
 tools/perf/util/pmu.h                     |   7 +
 tools/perf/util/pmus.c                    |   6 -
 tools/perf/util/pmus.h                    |   1 -
 18 files changed, 279 insertions(+), 281 deletions(-)
 create mode 100644 tools/perf/arch/arm64/util/mem-events.h
 create mode 100644 tools/perf/arch/powerpc/util/mem-events.h
 create mode 100644 tools/perf/arch/powerpc/util/pmu.c
 create mode 100644 tools/perf/arch/x86/util/mem-events.h
Signature · 1 line
2.35.1