Skip to content

Add a property to turn off the max touch controller if not used

Stefan Eichenberger linux-arm-kernel linux-devicetree linux-input lkml 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 2 repliesIn review
  2. v54 patches 0 repliesSuperseded
  3. v44 patches 6 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v3 posting 2/22 patches2 repliesSuperseded
v3 posting 1/22 patches0 repliesSuperseded
v22 patches2 repliesSuperseded
v12 patches9 repliesSuperseded

Changes in v6 from the cover letter

- Keep reset pin untouched in mxt_power_off (Dmitry)
- Generate proper reset signal in mxt_power_on (Dmitry)
- Drop introduction of mxt_device_register (not necessary)

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Input: atmel_mxt_ts - add power off and power on functionsdrivers/input/touchscreen/atmel_mxt_ts.c+34 -220 replies
2/3dt-bindings: input: atmel,maxtouch: add poweroff-sleep propertyDocumentation/devicetree/bindings/input/atmel,maxtouch.yaml+6 -01 reply
3/3Input: atmel_mxt_ts - add support for poweroff-sleepdrivers/input/touchscreen/atmel_mxt_ts.c+70 -121 reply

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJoao Paulo GoncalvesLinus WalleijKrzysztof Kozlowski
1/3R-b
2/3R-b R-b R-b
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/3] Add a property to turn off the max touch controller if not used

Our hardware has a shared regulator that powers various peripherals such as the display, touch, USB hub, etc. Since the Maxtouch controller doesn't currently allow it to be turned off, this regulator has to stay on when not used. This increases the overall power consumption. In order to turn off the controller when the system does not use it, this series adds a device tree property to the Maxtouch driver that allows the controller to be turned off completely and ensures that it can resume from the power off state.

Changes since v5:

- Keep reset pin untouched in mxt_power_off (Dmitry)
- Generate proper reset signal in mxt_power_on (Dmitry)
- Drop introduction of mxt_device_register (not necessary)

Changes since v4:

- Load configuration firmware during probe and not after resume (Dmitry)
- Do some improvements on error handling (Dmitry)
- Add Reviewed-by tag from Joao

Changes since v3:

- Move the power on part to mxt_start and the power off part to mxt_stop. This allows to turn the touch controller off even when not in use and not only when being suspended (Dmitry)

Changes since v2:

- Add Reviewed-by tags from Linus and Krzysztof to the dt-bindings patch

Changes since v1:

- Rename the property and change the description (Krzysztof, Linus, Dmitry, Conor)

Stefan Eichenberger (3):
Input: atmel_mxt_ts - add power off and power on functions
dt-bindings: input: atmel,maxtouch: add poweroff-sleep property
Input: atmel_mxt_ts - add support for poweroff-sleep

 .../bindings/input/atmel,maxtouch.yaml        |   6 +
 drivers/input/touchscreen/atmel_mxt_ts.c      | 134 +++++++++++++-----
 2 files changed, 108 insertions(+), 32 deletions(-)
Signature · 1 line
2.43.0