Skip to content

libceph: fix sparse-read failure bug

[email protected] ceph-devel 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 3 repliesIn review
  2. v53 patches 3 repliesSuperseded
  3. v43 patches 16 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v33 patches7 repliesSuperseded
v22 patches8 repliesSuperseded
v12 patches7 repliesSuperseded

Changes in v6 from the cover letter

- minor fix from Jeff's comments.

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3libceph: fail the sparse-read if the data length doesn't matchnet/ceph/osd_client.c+9 -20 replies
2/3libceph: rename read_sparse_msg_XX to read_partial_sparse_msg_XXnet/ceph/messenger_v1.c+4 -40 replies
3/3libceph: just wait for more data to be available on the socketinclude/linux/ceph/messenger.h net/ceph/messenger_v1.c net/ceph/messenger_v2.c +1 more+19 -213 replies

Reviews trailers per patch

2 of 3 patches have a Reviewed-by or Acked-by.

PatchJeff Layton
1/3R-b
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] libceph: fix sparse-read failure bug

From: Xiubo Li <[email protected]>

V6:
- minor fix from Jeff's comments.

V5:
- remove sr_total_resid and reuse total_resid instead.

V4:
- remove the sr_resid_elen field
- improved the 'read_partial_sparse_msg_data()'

V3:
- rename read_sparse_msg_XX to read_partial_sparse_msg_XX
- fix the sparse-read bug in the messager v1 code.

V2:
- fix the sparse-read bug in the sparse-read code instead

Xiubo Li (3):
libceph: fail the sparse-read if the data length doesn't match
libceph: rename read_sparse_msg_XX to read_partial_sparse_msg_XX
libceph: just wait for more data to be available on the socket

 include/linux/ceph/messenger.h |  2 +-
 net/ceph/messenger_v1.c        | 33 +++++++++++++++++----------------
 net/ceph/messenger_v2.c        |  4 ++--
 net/ceph/osd_client.c          | 20 ++++++++++++--------
 4 files changed, 32 insertions(+), 27 deletions(-)
Signature · 1 line
2.43.0