nvmet: avoid circular locking warning
Get series with b4
b4 am [email protected]Versions newest first
- v3 Latest2 patches 6 repliesIn review
Changes to v2 from the cover letter
- Implement backlog as suggested by Sagi
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | nvmet-tcp: avoid circular locking dependency on install_queue()drivers/ | +15 | 1 reply | |
| 2/2 | nvmet-rdma: avoid circular locking dependency on install_queue()drivers/ | +16 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Shin'ichiro Kawasaki | Sagi Grimberg |
|---|---|---|
| 1/2 | T-b | R-b |
| 2/2 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCHv3 0/2] nvmet: avoid circular locking warning
From: Hannes Reinecke <[email protected]>
nvmet-rdma and nvmet-tcp trigger a circular locking warning when tearing down; reason is a call to 'flush_workqueue' when creating a new controller which tries to cover for the fact that old controller instances might be in the process of tearing down.
However, this is pure speculation as we don't know (and don't check) if there really _are_ controllers in shutdown.
And even if there were, that should be short-lived, and would have been resolved by connecting just a tad later.
So this patch returns 'controller busy' if we really find ourselves in this situation, allowing the caller to reconnect later.
Changes to v2:
- Implement backlog as suggested by Sagi
Changes to the original version:
- Update the rdma patch to implement 'install_queue()'
- Include suggestions from Jens Axboe
Hannes Reinecke (2):
nvmet-tcp: avoid circular locking dependency on install_queue()
nvmet-rdma: avoid circular locking dependency on install_queue()
drivers/nvme/target/rdma.c | 19 ++++++++++++++++--- drivers/nvme/target/tcp.c | 18 +++++++++++++++--- 2 files changed, 31 insertions(+), 6 deletions(-)
Signature · 1 line
2.35.3