Skip to content

virtio-net RSS/hash report fixes and improvements

Akihiko Odaki qemu-devel 11 versions – In review

Get series with b4
b4 am [email protected] change-id 20231210-rss-e7c98e722253

Versions newest first

  1. v10 Latest18 patches 1 replyIn review
  2. v920 patches 22 repliesSuperseded
  3. v819 patches 6 repliesSuperseded inferred link
Earlier versions · 8
VersionPostedPatchesRepliesStatus
v7 posting 2/219 patches0 repliesSuperseded inferred link
v7 posting 1/24 of 19 patches0 repliesSuperseded inferred link
v621 patches37 repliesSuperseded inferred link
v521 patches16 repliesSuperseded inferred link
v420 patches1 replySuperseded inferred link
v311 patches13 repliesSuperseded inferred link
v27 patches4 repliesSuperseded inferred link
v16 patches1 replySuperseded

Changes in v10 from the cover letter

- Dropped an obsolete statement of patch "virtio-net: Do not write hashes to peer buffer". (Yuri Benditovich)
- Dropped patch "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Report RSS warning at device realization".
- Link to v9: https://lore.kernel.org/r/[email protected]

Patches in v10 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/18tap: Remove tap_probe_vnet_hdr_len()net/tap-bsd.c net/tap-linux.c net/tap-solaris.c +3 more+2 -420 replies
2/18tap: Remove qemu_using_vnet_hdr()hw/net/e1000e.c hw/net/igb.c hw/net/net_tx_pkt.c +7 more+5 -741 reply
3/18net: Move virtio-net header length assertionnet/net.c net/tap.c+5 -30 replies
4/18net: Remove receive_raw()include/net/net.h net/net.c net/tap.c+12 -80 replies
5/18tap: Call tap_receive_iov() from tap_receive()net/tap.c+5 -300 replies
6/18tap: Shrink zeroed virtio-net headernet/tap.c+1 -10 replies
7/18virtio-net: Do not propagate ebpf-rss-fds errorshw/net/virtio-net.c+10 -130 replies
8/18virtio-net: Add only one queue pair when realizinghw/net/virtio-net.c+1 -30 replies
9/18virtio-net: Copy header only when necessaryhw/net/virtio-net.c+12 -140 replies
10/18virtio-net: Shrink header byte swapping bufferhw/net/virtio-net.c+6 -110 replies
11/18virtio-net: Disable RSS on resethw/net/virtio-net.c+36 -340 replies
12/18virtio-net: Unify the logic to update NIC state for RSShw/net/virtio-net.c+36 -540 replies
13/18virtio-net: Always set populate_hashhw/net/virtio-net.c+1 -00 replies
14/18virtio-net: Do not write hashes to peer bufferhw/net/virtio-net.c+17 -190 replies
15/18ebpf: Fix RSS error handlingebpf/rss.bpf.skeleton.h tools/ebpf/rss.bpf.c+610 -6200 replies
16/18ebpf: Return 0 when configuration failsebpf/rss.bpf.skeleton.h tools/ebpf/rss.bpf.c+767 -7670 replies
17/18ebpf: Refactor tun_rss_steering_prog()tools/ebpf/rss.bpf.c+11 -150 replies
18/18ebpf: Add a separate target for skeletontools/ebpf/Makefile.ebpf+8 -70 replies

Reviews trailers per patch

2 of 18 patches have a Reviewed-by or Acked-by.

PatchMichael S. TsirkinMichael Tokarev
1/18A-b
2/18
3/18
4/18
5/18
6/18
7/18
8/18
9/18
10/18
11/18R-b
12/18
13/18
14/18
15/18
16/18
17/18
18/18

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v10 thread

Cover letter [PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements

This series contains fixes and improvements for virtio-net RSS and hash reporting feature.

V7 -> V8:
Reset author email addresses.
Rebased.

V6 -> V7:
Dropped patch "virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT". Dropped the changes to remove packet flags.
Re-introduced tap_receive() and changed it to call tap_receive_iov(). Removed tap_get_vnet_hdr_len().
Fixed tap initialization not to call tap_fd_set_vnet_hdr_len() for tap without virtio-net header.
Changed to call error_report() instead of warn_report() for programming errors.

V5 -> V6:
Corrected the message for patch "virtio-net: Return an error when vhost cannot enable RSS".
Removed changes to introduce asserts from "virtio-net: Return an error when vhost cannot enable RSS".
Reorganized patches "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Do not clear VIRTIO_NET_F_RSS". This version now contains patches "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Enable software RSS". Rebased.

V4 -> V5:
Added patch "virtio-net: Do not write hashes to peer buffer".

V3 -> V4:
Extract patches "tap: Remove tap_receive()" and "net: Remove flag propagation" from "net: Remove receive_raw()".
Added patch "virtio-net: Always set populate_hash". Added patch "virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT". Added patch "ebpf: Use standard section name".
Added patch "ebpf: Simplify error handling".
Added patch "ebpf: Return 0 when configuration fails". Added patch "ebpf: Refactor tun_rss_steering_prog()". Added patch "ebpf: Add a separate target for skeleton".

V2 -> V3:
Added patch "tap: Remove tap_probe_vnet_hdr_len()". Added patch "tap: Remove qemu_using_vnet_hdr()". Added patch "net: Move virtio-net header length assertion". Added patch "net: Remove receive_raw()".
Added patch "tap: Shrink zeroed virtio-net header". Dropped patch "tap: Fix virtio-net header buffer size".

V1 -> V2:
Added patch "ebpf: Fix RSS error handling".

---
Changes in v10:
- Dropped an obsolete statement of patch "virtio-net: Do not write hashes to peer buffer". (Yuri Benditovich)
- Dropped patch "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Report RSS warning at device realization".
- Link to v9: https://lore.kernel.org/r/[email protected]

Changes in v9:
- Added patch "virtio-net: Do not propagate ebpf-rss-fds errors".
- Added patch "virtio-net: Shrink header byte swapping buffer".
- Rebased.
- Link to v8: https://lore.kernel.org/r/[email protected]

---
Akihiko Odaki (18):
tap: Remove tap_probe_vnet_hdr_len()
tap: Remove qemu_using_vnet_hdr()
net: Move virtio-net header length assertion
net: Remove receive_raw()
tap: Call tap_receive_iov() from tap_receive()
tap: Shrink zeroed virtio-net header
virtio-net: Do not propagate ebpf-rss-fds errors
virtio-net: Add only one queue pair when realizing
virtio-net: Copy header only when necessary
virtio-net: Shrink header byte swapping buffer
virtio-net: Disable RSS on reset
virtio-net: Unify the logic to update NIC state for RSS
virtio-net: Always set populate_hash
virtio-net: Do not write hashes to peer buffer
ebpf: Fix RSS error handling
ebpf: Return 0 when configuration fails
ebpf: Refactor tun_rss_steering_prog()
ebpf: Add a separate target for skeleton

 ebpf/rss.bpf.skeleton.h  | 1558 +++++++++++++++++++++++-----------------------
 include/net/net.h        |    8 -
 net/tap_int.h            |    1 -
 hw/net/e1000e.c          |    1 -
 hw/net/igb.c             |    1 -
 hw/net/net_tx_pkt.c      |    4 +-
 hw/net/virtio-net.c      |  264 ++++----
 hw/net/vmxnet3.c         |    2 -
 net/dump.c               |    4 +-
 net/net.c                |   47 +-
 net/netmap.c             |    5 -
 net/tap-bsd.c            |    5 -
 net/tap-linux.c          |   20 -
 net/tap-solaris.c        |    5 -
 net/tap-stub.c           |    5 -
 net/tap.c                |   77 +--
 tools/ebpf/rss.bpf.c     |   44 +-
 tools/ebpf/Makefile.ebpf |   15 +-
 18 files changed, 948 insertions(+), 1118 deletions(-)

---
base-commit: e5c6528dce86d7a9ada7ecf02fcb7b8560955131
change-id: 20231210-rss-e7c98e722253

Best regards,

Signature · 1 line
Akihiko Odaki <[email protected]>