virtio-net RSS/hash report fixes and improvements
Get series with b4
b4 am [email protected] change-id 20231210-rss-e7c98e722253Versions newest first
- v10 Latest18 patches 1 replyIn review
- v920 patches 22 repliesSuperseded
- v819 patches 6 repliesSuperseded inferred link
Earlier versions · 8
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v7 posting 2/2 | 19 patches | 0 replies | Superseded inferred link | |
| v7 posting 1/2 | 4 of 19 patches | 0 replies | Superseded inferred link | |
| v6 | 21 patches | 37 replies | Superseded inferred link | |
| v5 | 21 patches | 16 replies | Superseded inferred link | |
| v4 | 20 patches | 1 reply | Superseded inferred link | |
| v3 | 11 patches | 13 replies | Superseded inferred link | |
| v2 | 7 patches | 4 replies | Superseded inferred link | |
| v1 | 6 patches | 1 reply | Superseded |
Changes in v10 from the cover letter
- Dropped an obsolete statement of patch "virtio-net: Do not write hashes to peer buffer". (Yuri Benditovich)
- Dropped patch "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Report RSS warning at device realization".
- Link to v9: https://lore.kernel.org/r/[email protected]
Patches in v10 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/18 | tap: Remove tap_probe_vnet_hdr_len()net/ net/ net/ +3 more | +2 | 0 replies | |
| 2/18 | tap: Remove qemu_using_vnet_hdr()hw/ hw/ hw/ +7 more | +5 | 1 reply | |
| 3/18 | net: Move virtio-net header length assertionnet/ net/ | +5 | 0 replies | |
| 4/18 | net: Remove receive_raw()include/ net/ net/ | +12 | 0 replies | |
| 5/18 | tap: Call tap_receive_iov() from tap_receive()net/ | +5 | 0 replies | |
| 6/18 | tap: Shrink zeroed virtio-net headernet/ | +1 | 0 replies | |
| 7/18 | virtio-net: Do not propagate ebpf-rss-fds errorshw/ | +10 | 0 replies | |
| 8/18 | virtio-net: Add only one queue pair when realizinghw/ | +1 | 0 replies | |
| 9/18 | virtio-net: Copy header only when necessaryhw/ | +12 | 0 replies | |
| 10/18 | virtio-net: Shrink header byte swapping bufferhw/ | +6 | 0 replies | |
| 11/18 | virtio-net: Disable RSS on resethw/ | +36 | 0 replies | |
| 12/18 | virtio-net: Unify the logic to update NIC state for RSShw/ | +36 | 0 replies | |
| 13/18 | virtio-net: Always set populate_hashhw/ | +1 | 0 replies | |
| 14/18 | virtio-net: Do not write hashes to peer bufferhw/ | +17 | 0 replies | |
| 15/18 | ebpf: Fix RSS error handlingebpf/ tools/ | +610 | 0 replies | |
| 16/18 | ebpf: Return 0 when configuration failsebpf/ tools/ | +767 | 0 replies | |
| 17/18 | ebpf: Refactor tun_rss_steering_prog()tools/ | +11 | 0 replies | |
| 18/18 | ebpf: Add a separate target for skeletontools/ | +8 | 0 replies |
Reviews trailers per patch
2 of 18 patches have a Reviewed-by or Acked-by.
| Patch | Michael S. Tsirkin | Michael Tokarev |
|---|---|---|
| 1/18 | A-b | |
| 2/18 | ||
| 3/18 | ||
| 4/18 | ||
| 5/18 | ||
| 6/18 | ||
| 7/18 | ||
| 8/18 | ||
| 9/18 | ||
| 10/18 | ||
| 11/18 | R-b | |
| 12/18 | ||
| 13/18 | ||
| 14/18 | ||
| 15/18 | ||
| 16/18 | ||
| 17/18 | ||
| 18/18 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v10 00/18] virtio-net RSS/hash report fixes and improvements
This series contains fixes and improvements for virtio-net RSS and hash reporting feature.
V7 -> V8:
Reset author email addresses.
Rebased.
V6 -> V7:
Dropped patch "virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT". Dropped the changes to remove packet flags.
Re-introduced tap_receive() and changed it to call tap_receive_iov(). Removed tap_get_vnet_hdr_len().
Fixed tap initialization not to call tap_fd_set_vnet_hdr_len() for tap without virtio-net header.
Changed to call error_report() instead of warn_report() for programming errors.
V5 -> V6:
Corrected the message for patch "virtio-net: Return an error when vhost cannot enable RSS".
Removed changes to introduce asserts from "virtio-net: Return an error when vhost cannot enable RSS".
Reorganized patches "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Do not clear VIRTIO_NET_F_RSS". This version now contains patches "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Enable software RSS". Rebased.
V4 -> V5:
Added patch "virtio-net: Do not write hashes to peer buffer".
V3 -> V4:
Extract patches "tap: Remove tap_receive()" and "net: Remove flag propagation" from "net: Remove receive_raw()".
Added patch "virtio-net: Always set populate_hash". Added patch "virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT". Added patch "ebpf: Use standard section name".
Added patch "ebpf: Simplify error handling".
Added patch "ebpf: Return 0 when configuration fails". Added patch "ebpf: Refactor tun_rss_steering_prog()". Added patch "ebpf: Add a separate target for skeleton".
V2 -> V3:
Added patch "tap: Remove tap_probe_vnet_hdr_len()". Added patch "tap: Remove qemu_using_vnet_hdr()". Added patch "net: Move virtio-net header length assertion". Added patch "net: Remove receive_raw()".
Added patch "tap: Shrink zeroed virtio-net header". Dropped patch "tap: Fix virtio-net header buffer size".
V1 -> V2:
Added patch "ebpf: Fix RSS error handling".
---
Changes in v10:
- Dropped an obsolete statement of patch "virtio-net: Do not write hashes to peer buffer". (Yuri Benditovich)
- Dropped patch "virtio-net: Return an error when vhost cannot enable RSS" and "virtio-net: Report RSS warning at device realization".
- Link to v9: https://lore.kernel.org/r/[email protected]
Changes in v9:
- Added patch "virtio-net: Do not propagate ebpf-rss-fds errors".
- Added patch "virtio-net: Shrink header byte swapping buffer".
- Rebased.
- Link to v8: https://lore.kernel.org/r/[email protected]
---
Akihiko Odaki (18):
tap: Remove tap_probe_vnet_hdr_len()
tap: Remove qemu_using_vnet_hdr()
net: Move virtio-net header length assertion
net: Remove receive_raw()
tap: Call tap_receive_iov() from tap_receive()
tap: Shrink zeroed virtio-net header
virtio-net: Do not propagate ebpf-rss-fds errors
virtio-net: Add only one queue pair when realizing
virtio-net: Copy header only when necessary
virtio-net: Shrink header byte swapping buffer
virtio-net: Disable RSS on reset
virtio-net: Unify the logic to update NIC state for RSS
virtio-net: Always set populate_hash
virtio-net: Do not write hashes to peer buffer
ebpf: Fix RSS error handling
ebpf: Return 0 when configuration fails
ebpf: Refactor tun_rss_steering_prog()
ebpf: Add a separate target for skeleton
ebpf/rss.bpf.skeleton.h | 1558 +++++++++++++++++++++++----------------------- include/net/net.h | 8 - net/tap_int.h | 1 - hw/net/e1000e.c | 1 - hw/net/igb.c | 1 - hw/net/net_tx_pkt.c | 4 +- hw/net/virtio-net.c | 264 ++++---- hw/net/vmxnet3.c | 2 - net/dump.c | 4 +- net/net.c | 47 +- net/netmap.c | 5 - net/tap-bsd.c | 5 - net/tap-linux.c | 20 - net/tap-solaris.c | 5 - net/tap-stub.c | 5 - net/tap.c | 77 +-- tools/ebpf/rss.bpf.c | 44 +- tools/ebpf/Makefile.ebpf | 15 +- 18 files changed, 948 insertions(+), 1118 deletions(-)
---
base-commit: e5c6528dce86d7a9ada7ecf02fcb7b8560955131
change-id: 20231210-rss-e7c98e722253
Best regards,
Signature · 1 line
Akihiko Odaki <[email protected]>