Skip to content

bpf: Simplify checking size of helper accesses

Andrei Matei bpf 4 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesApplied 2/2
  2. v32 patches 3 repliesSuperseded
  3. v21 patch 10 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch4 repliesSuperseded

Changes in v4 from the cover letter

- kept only the minimal change, undoing debatable changes (Andrii)
- dropped the second patch from before, with changes to the error message (Andrii)
- extracted the new test into a separate patch (Andrii)
- added Acked by Andrii

Patches in v4 All 2 applied

#Subject and filesSizeRepliesApplied
1/2bpf: Simplify checking size of helper accesseskernel/bpf/verifier.c tools/testing/selftests/bpf/progs/verifier_helper_value_access.c tools/testing/selftests/bpf/progs/verifier_raw_stack.c+9 -110 repliesApplied
2/2bpf: add a possibly-zero-sized read testtools/testing/selftests/bpf/progs/verifier_helper_value_access.c+38 -10 repliesApplied

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchAndrii Nakryiko
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH bpf-next v4 0/2] bpf: Simplify checking size of helper accesses

v3->v4:
- kept only the minimal change, undoing debatable changes (Andrii)
- dropped the second patch from before, with changes to the error message (Andrii)
- extracted the new test into a separate patch (Andrii)
- added Acked by Andrii

v2->v3:
- split the error-logging function to a separate patch (Andrii)
- make the error buffers smaller (Andrii)
- include size of memory region for PTR_TO_MEM (Andrii)
- nits from Andrii and Eduard

v1->v2:
- make the error message include more info about the context of the zero-sized access (Andrii)

Andrei Matei (2):
bpf: Simplify checking size of helper accesses
bpf: add a possibly-zero-sized read test

 kernel/bpf/verifier.c                         | 10 ++---
 .../bpf/progs/verifier_helper_value_access.c  | 45 +++++++++++++++++--
 .../selftests/bpf/progs/verifier_raw_stack.c  |  2 +-
 3 files changed, 46 insertions(+), 11 deletions(-)
Signature · 1 line
2.40.1

Read the cover letter in its thread