Skip to content

Omnivision OV4689 refactoring and improvements

Mikhail Rudenko linux-media lkml 5 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest16 patches 0 repliesNew
  2. v420 patches 6 repliesSuperseded
  3. v320 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v220 patches34 repliesSuperseded
v119 patches21 repliesSuperseded

Changes in v5 from the cover letter

- add spaces inside {} in the register tables

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16media: i2c: ov4689: Clean up and annotate the register tabledrivers/media/i2c/ov4689.c+119 -860 replies
2/16media: i2c: ov4689: Sort register definitions by addressdrivers/media/i2c/ov4689.c+5 -50 replies
3/16media: i2c: ov4689: Fix typo in a commentdrivers/media/i2c/ov4689.c+1 -10 replies
4/16media: i2c: ov4689: CCI conversiondrivers/media/i2c/Kconfig drivers/media/i2c/ov4689.c+133 -2260 replies
5/16media: i2c: ov4689: Remove i2c_client from ov4689 structdrivers/media/i2c/ov4689.c+18 -180 replies
6/16media: i2c: ov4689: Refactor ov4689_set_ctrldrivers/media/i2c/ov4689.c+6 -60 replies
7/16media: i2c: ov4689: Use sub-device active statedrivers/media/i2c/ov4689.c+31 -440 replies
8/16media: i2c: ov4689: Enable runtime PM before registering sub-devicedrivers/media/i2c/ov4689.c+8 -60 replies
9/16media: i2c: ov4689: Use runtime PM autosuspenddrivers/media/i2c/ov4689.c+11 -40 replies
10/16media: i2c: ov4689: Remove max_fps field from struct ov4689_modedrivers/media/i2c/ov4689.c+0 -20 replies
11/16media: i2c: ov4689: Make horizontal blanking configurabledrivers/media/i2c/ov4689.c+20 -110 replies
12/16media: i2c: ov4689: Implement vflip/hflip controlsdrivers/media/i2c/ov4689.c+22 -20 replies
13/16media: i2c: ov4689: Implement digital gain controldrivers/media/i2c/ov4689.c+14 -20 replies
14/16media: i2c: ov4689: Implement manual color balance controlsdrivers/media/i2c/ov4689.c+22 -10 replies
15/16media: i2c: ov4689: Move pixel array size out of struct ov4689_modedrivers/media/i2c/ov4689.c+13 -160 replies
16/16media: i2c: ov4689: Set timing registers programmaticallydrivers/media/i2c/ov4689.c+68 -150 replies

Reviews trailers per patch

All 16 patches have a Reviewed-by or Acked-by.

PatchLaurent PinchartKieran Bingham
1/16A-b
2/16R-b
3/16R-b
4/16R-b
5/16R-b
6/16R-b
7/16R-b
8/16R-b
9/16R-b
10/16R-b
11/16R-b
12/16R-b
13/16R-b
14/16R-b
15/16R-b
16/16R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 00/16] Omnivision OV4689 refactoring and improvements

Hi,

this is the fourth revision of the series containing refactoring and new features implementation for the Omnivision OV4689 sensor driver. Specifically, patches 1, 2, 3, 5, 6, 10, 15, 16 are refactorings, and are not supposed to introduce any functional change. Patches 4 and 7 perform migration to CCI helpers and subdevice active state respectively, and should not introduce any hardware- and/or user-visible change either. Patch 8 fixes a possible race condition due to v4l2_async_register_subdev_sensor being called too early in ov4689_probe, and patch 9 migrates power management to PM autosuspend.

Patches 11-14 expose more sensor controls to the userspace, such as (read-write) HBLANK, VFLIP/HFLIP, digital gain, and color balance. It should be noted that publicly available sensor documentation is lacking description of many registers and their value ranges, so a lot of values had to be found by experimentation.

Patches 17-20 from v4 are dropped and will be reintroduced as a separate series later.

Changes in v5:
- add spaces inside {} in the register tables

Changes in v4:
- rebase on top of media_stage
- collect Reviewed-by's from v3
- add comments "Horizontal" and "Vertical" to TIMING_FORMAT registers
- fix a typo in the commit message in patch 17/20
- remove "__" prefix from stream on/off functions
- rename the label in ov4689_stream_off and remove extra space

Changes in v3:
- rebase on top of media_stage
- collect Reviewed-by and Acked-by from v2
- update copyright year
- zero-initialize ret in ov4689_set_ctrl
- get back blank line before return in ov4689_set_ctrl
- move sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE before ov4689_initialize_controls() in ov4689_probe
- remove blank line after v4l2_subdev_init_finalize(sd)
- use pm_runtime_put instead of pm_runtime_put_sync
- add comment for dummy columns/rows defines
- fix OV4689_PIXEL_ARRAY_WIDTH use instead of OV4689_PIXEL_ARRAY_HEIGHT in ov4689_get_selection
- split s_stream into two functions for start and stop

Changes in v2:
- collect Laurent's r-b's
- squash together "CCI conversion" and "Set gain in one 16 bit write"
- use ctrl->val in ov4689_set_ctrl
- rename try_fmt to fmt in ov4689_init_cfg and drop corresponding comment
- rebase on top of media-stage and rename init_cfg->init_state
- sort register definitions by address throughout the whole series
- fix number of controls hint in v4l2_ctrl_handler_init
- make all hexadecimal constants lowercase
- disable runtime pm in probe error path
- implement pm autosuspend

Mikhail Rudenko (16):
media: i2c: ov4689: Clean up and annotate the register table
media: i2c: ov4689: Sort register definitions by address
media: i2c: ov4689: Fix typo in a comment
media: i2c: ov4689: CCI conversion
media: i2c: ov4689: Remove i2c_client from ov4689 struct
media: i2c: ov4689: Refactor ov4689_set_ctrl
media: i2c: ov4689: Use sub-device active state
media: i2c: ov4689: Enable runtime PM before registering sub-device
media: i2c: ov4689: Use runtime PM autosuspend
media: i2c: ov4689: Remove max_fps field from struct ov4689_mode
media: i2c: ov4689: Make horizontal blanking configurable
media: i2c: ov4689: Implement vflip/hflip controls
media: i2c: ov4689: Implement digital gain control
media: i2c: ov4689: Implement manual color balance controls
media: i2c: ov4689: Move pixel array size out of struct ov4689_mode
media: i2c: ov4689: Set timing registers programmatically

 drivers/media/i2c/Kconfig  |   1 +
 drivers/media/i2c/ov4689.c | 671 ++++++++++++++++++++-----------------
 2 files changed, 359 insertions(+), 313 deletions(-)

--
2.44.0