Skip to content

arm64: dts: qcom: fix USB wakeup interrupts again

Johan Hovold linux-arm-msm linux-devicetree lkml stable 1 version Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5arm64: dts: qcom: sc8180x: fix USB DP/DM HS PHY interruptsarch/arm64/boot/dts/qcom/sc8180x.dtsi+8 -81 reply
2/5arm64: dts: qcom: sdm845: fix USB DP/DM HS PHY interruptsarch/arm64/boot/dts/qcom/sdm845.dtsi+8 -81 reply
3/5arm64: dts: qcom: sdm845: fix USB SS wakeuparch/arm64/boot/dts/qcom/sdm845.dtsi+2 -21 reply
4/5arm64: dts: qcom: sm8150: fix USB DP/DM HS PHY interruptsarch/arm64/boot/dts/qcom/sm8150.dtsi+8 -81 reply
5/5arm64: dts: qcom: sm8150: fix USB SS wakeuparch/arm64/boot/dts/qcom/sm8150.dtsi+2 -21 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchKonrad Dybcio
1/5R-b T-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] arm64: dts: qcom: fix USB wakeup interrupts again

The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt controller in order to be able to wake the system up from low-power states and to be able to detect disconnect events, which requires triggering on falling edges.

A recent commit updated the trigger type but failed to change the interrupt provider as required. This leads to the current Linux driver failing to probe instead of printing an error during suspend and USB wakeup not working as intended.

While at it, fix also the SS PHY interrupt so that it too can be used to wakeup the system up.

Thanks to Konrad for reporting the probe failure on sc8180x and providing the corresponding PDC interrupts and to Krishna for providing the remaining PDC interrupts. The exception is for the second controller on sm8150 whose PDC vectors I inferred from sdm845.

Note sdm670 and sm6375 need similar fixes and I believe Bjorn is trying to dig out the corresponding vectors. The SS PHY interrupt on sc8180x should also be fixed.

Also note that these patches have only been compile tested.

Johan

Johan Hovold (5):
arm64: dts: qcom: sc8180x: fix USB DP/DM HS PHY interrupts
arm64: dts: qcom: sdm845: fix USB DP/DM HS PHY interrupts
arm64: dts: qcom: sdm845: fix USB SS wakeup
arm64: dts: qcom: sm8150: fix USB DP/DM HS PHY interrupts
arm64: dts: qcom: sm8150: fix USB SS wakeup

 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 16 ++++++++--------
 arch/arm64/boot/dts/qcom/sdm845.dtsi  | 16 ++++++++--------
 arch/arm64/boot/dts/qcom/sm8150.dtsi  | 16 ++++++++--------
 3 files changed, 24 insertions(+), 24 deletions(-)
Signature · 1 line
2.41.0