Skip to content

big header dependency cleanup targeting sched.h

Kent Overstreet intel-gfx linux-fsdevel linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest50 patches 45 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/50drivers/gpu/drm/i915/i915_memcpy.c: fix missing includesdrivers/gpu/drm/i915/i915_memcpy.c+2 -01 reply
2/50x86/kernel/fpu/bugs.c: fix missing includearch/x86/kernel/fpu/bugs.c+1 -02 replies
3/50x86/lib/cache-smp.c: fix missing includearch/x86/lib/cache-smp.c+1 -03 replies
4/50x86/include/asm/debugreg.h: fix missing includearch/x86/include/asm/debugreg.h+1 -00 replies
5/50x86/include/asm/paravirt_types.h: fix missing includearch/x86/include/asm/paravirt_types.h+2 -00 replies
6/50task_stack.h: add missing includeinclude/linux/sched/task_stack.h+1 -00 replies
7/50nsproxy.h: add missing includeinclude/linux/nsproxy.h+1 -00 replies
8/50kernel/fork.c: add missing includekernel/fork.c+1 -00 replies
9/50kmsan: add missing types.h dependencyinclude/linux/kmsan_types.h+2 -00 replies
10/50time_namespace.h: fix missing includeinclude/linux/time_namespace.h+1 -00 replies
11/50nodemask: Split out include/linux/nodemask_types.hinclude/linux/nodemask.h include/linux/nodemask_types.h include/linux/sched.h+12 -20 replies
12/50prandom: Remove unused includeinclude/linux/prandom.h+0 -12 replies
13/50timekeeping: Kill percpu.h dependencyinclude/linux/hrtimer.h include/linux/time_namespace.h+3 -10 replies
14/50arm64: Fix circular header dependencyarch/arm64/include/asm/spectre.h+2 -20 replies
15/50kernel/numa.c: Move logging out of numa.hinclude/linux/numa.h kernel/Makefile kernel/numa.c+30 -134 replies
16/50sched.h: Move (spin|rwlock)_needbreak() to spinlock.hinclude/linux/sched.h include/linux/spinlock.h+31 -311 reply
17/50ktime.h: move ktime_t to types.hinclude/linux/ktime.h include/linux/types.h+6 -50 replies
18/50hrtimers: Split out hrtimer_types.hinclude/linux/hrtimer.h include/linux/hrtimer_types.h include/linux/sched.h+53 -430 replies
19/50locking/mutex: split out mutex_types.hinclude/linux/mutex.h include/linux/mutex_types.h include/linux/sched.h+73 -526 replies
20/50posix-cpu-timers: Split out posix-timers_types.hinclude/linux/posix-timers.h include/linux/posix-timers_types.h include/linux/sched.h+76 -660 replies
21/50locking/seqlock: Split out seqlock_types.hinclude/linux/sched.h include/linux/seqlock.h include/linux/seqlock_types.h+96 -781 reply
22/50pid: Split out pid_types.hdrivers/target/target_core_xcopy.c include/linux/pid.h include/linux/pid_types.h +2 more+22 -141 reply
23/50sched.h: move pid helpers to pid.hinclude/linux/pid.h include/linux/sched.h include/linux/sched/signal.h+126 -1220 replies
24/50plist: Split out plist_types.hinclude/linux/plist.h include/linux/plist_types.h include/linux/sched.h +5 more+24 -120 replies
25/50wait: Remove uapi header file from main header fileinclude/linux/wait.h kernel/exit.c kernel/pid_namespace.c+4 -21 reply
26/50rslib: kill bogus dependency on list.hinclude/linux/rslib.h+0 -13 replies
27/50timerqueue: Split out timerqueue_types.hinclude/linux/hrtimer_types.h include/linux/posix-timers_types.h include/linux/timerqueue.h +1 more+20 -140 replies
28/50signal: Kill bogus dependency on list.hinclude/linux/signal.h include/linux/signal_types.h+2 -10 replies
29/50timers: Split out timer_types.hinclude/linux/timer.h include/linux/timer_types.h+24 -150 replies
30/50workqueue: Split out workqueue_types.hinclude/linux/dma-fence.h include/linux/rhashtable-types.h include/linux/timekeeping.h +2 more+29 -160 replies
31/50shm: Slim down dependenciesinclude/linux/shm.h ipc/shm.c security/selinux/hooks.c +1 more+5 -20 replies
32/50ipc: Kill bogus dependency on spinlock.hinclude/linux/ipc.h include/linux/sched.h+3 -10 replies
33/50Split out irqflags_types.hinclude/linux/irqflags.h include/linux/irqflags_types.h include/linux/sched.h+24 -140 replies
34/50mm_types_task.h: Trim dependenciesinclude/linux/mm_types_task.h+2 -50 replies
35/50cpumask: Split out cpumask_types.harch/x86/include/asm/tlbbatch.h include/linux/cpumask.h include/linux/cpumask_types.h+14 -40 replies
36/50syscall_user_dispatch.h: split out *_types.hinclude/linux/sched.h include/linux/syscall_user_dispatch.h include/linux/syscall_user_dispatch_types.h+24 -90 replies
37/50x86/signal: kill dependency on time.harch/x86/include/uapi/asm/signal.h+0 -10 replies
38/50uapi/linux/resource.h: fix includeinclude/uapi/linux/resource.h+1 -10 replies
39/50refcount: Split out refcount_types.hinclude/linux/refcount.h include/linux/refcount_types.h include/linux/sched.h+21 -130 replies
40/50seccomp: Split out seccomp_types.hinclude/linux/sched.h include/linux/seccomp.h include/linux/seccomp_types.h+28 -200 replies
41/50uidgid: Split out uidgid_types.hinclude/linux/sched.h include/linux/uidgid.h include/linux/uidgid_types.h+17 -101 reply
42/50sem: Split out sem_types.hinclude/linux/audit.h include/linux/sched.h include/linux/sem.h +1 more+17 -103 replies
43/50lockdep: move held_lock to lockdep_types.hinclude/linux/lockdep.h include/linux/lockdep_types.h+57 -571 reply
44/50restart_block: Trim includesinclude/linux/restart_block.h include/linux/sched.h+2 -10 replies
45/50rseq: Split out rseq.h from sched.harch/x86/kernel/signal.c fs/exec.c include/linux/resume_user_mode.h +4 more+137 -1240 replies
46/50preempt.h: Kill dependency on list.hinclude/linux/preempt.h+4 -210 replies
47/50thread_info, uaccess.h: Move HARDENED_USERCOPY to better locationinclude/linux/thread_info.h include/linux/uaccess.h include/linux/uio.h+50 -500 replies
48/50Kill unnecessary kernel.h includearch/x86/include/asm/current.h arch/x86/include/asm/percpu.h+2 -10 replies
49/50kill unnecessary thread_info.h includearch/x86/include/asm/fpu/types.h arch/x86/include/asm/preempt.h+2 -10 replies
50/50Kill sched.h dependency on rcupdate.hinclude/linux/rcupdate.h include/linux/sched.h+14 -105 replies

Reviews trailers per patch

5 of 50 patches have a Reviewed-by or Acked-by.

PatchChristian BraunerWaiman LongGeert Uytterhoeven
1/50
2/50
3/50
4/50
5/50
6/50
7/50
8/50
9/50
10/50
11/50
12/50
13/50
14/50
15/50
16/50
17/50
18/50
19/50
20/50
21/50A-b
22/50
23/50
24/50
25/50R-b
26/50
27/50
28/50
29/50
30/50
31/50
32/50
33/50
34/50
35/50
36/50
37/50
38/50
39/50
40/50
41/50R-b
42/50
43/50A-b
44/50
45/50
46/50
47/50
48/50
49/50
50/50A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 00/50] big header dependency cleanup targeting sched.h

the issue being targeted here is that sched.h is entirely too much of an everything header, and a nexus of recursive header dependencies.

the main strategy is to try to only pull type definitions into sched.h, by splitting out *_types.h versions of sched.h dependencies, and secondarily moving code out of sched.h into more appropriate locations.

this patchset does not go quite as far as I would have liked; arch/x86/include/asm/processor.h also pulls in way too much, and I would like to also split out a _types.h version for that, but that would entail changing every arch's version of that header and I'm not going to tackle that yet.

if we do get that done, the number of headers pulled in by sched.h will be cut approximately in half (from well over 300 to 170-180) on an allyesconfig.

build tested on x86, still needs build testing on other archs

https://evilpiepirate.org/git/bcachefs.git/log/?h=header_cleanup

Kent Overstreet (49):
drivers/gpu/drm/i915/i915_memcpy.c: fix missing includes x86/kernel/fpu/bugs.c: fix missing include x86/lib/cache-smp.c: fix missing include x86/include/asm/debugreg.h: fix missing include x86/include/asm/paravirt_types.h: fix missing include task_stack.h: add missing include
nsproxy.h: add missing include
kernel/fork.c: add missing include
kmsan: add missing types.h dependency time_namespace.h: fix missing include
nodemask: Split out include/linux/nodemask_types.h
prandom: Remove unused include
timekeeping: Kill percpu.h dependency
arm64: Fix circular header dependency
kernel/numa.c: Move logging out of numa.h
sched.h: Move (spin|rwlock)_needbreak() to spinlock.h ktime.h: move ktime_t to types.h
hrtimers: Split out hrtimer_types.h
locking/mutex: split out mutex_types.h
posix-cpu-timers: Split out posix-timers_types.h locking/seqlock: Split out seqlock_types.h
pid: Split out pid_types.h
sched.h: move pid helpers to pid.h
plist: Split out plist_types.h
rslib: kill bogus dependency on list.h
timerqueue: Split out timerqueue_types.h
signal: Kill bogus dependency on list.h
timers: Split out timer_types.h
workqueue: Split out workqueue_types.h
shm: Slim down dependencies
ipc: Kill bogus dependency on spinlock.h
Split out irqflags_types.h
mm_types_task.h: Trim dependencies
cpumask: Split out cpumask_types.h syscall_user_dispatch.h: split out *_types.h x86/signal: kill dependency on time.h uapi/linux/resource.h: fix include
refcount: Split out refcount_types.h
seccomp: Split out seccomp_types.h
uidgid: Split out uidgid_types.h
sem: Split out sem_types.h
lockdep: move held_lock to lockdep_types.h
restart_block: Trim includes
rseq: Split out rseq.h from sched.h
preempt.h: Kill dependency on list.h
thread_info, uaccess.h: Move HARDENED_USERCOPY to better location Kill unnecessary kernel.h include
kill unnecessary thread_info.h include
Kill sched.h dependency on rcupdate.h

Matthew Wilcox (Oracle) (1):
wait: Remove uapi header file from main header file

 arch/arm64/include/asm/spectre.h            |   4 +-
 arch/x86/include/asm/current.h              |   1 +
 arch/x86/include/asm/debugreg.h             |   1 +
 arch/x86/include/asm/fpu/types.h            |   2 +
 arch/x86/include/asm/paravirt_types.h       |   2 +
 arch/x86/include/asm/percpu.h               |   2 +-
 arch/x86/include/asm/preempt.h              |   1 -
 arch/x86/include/asm/tlbbatch.h             |   2 +-
 arch/x86/include/uapi/asm/signal.h          |   1 -
 arch/x86/kernel/fpu/bugs.c                  |   1 +
 arch/x86/kernel/signal.c                    |   1 +
 arch/x86/lib/cache-smp.c                    |   1 +
 drivers/gpu/drm/i915/i915_memcpy.c          |   2 +
 drivers/target/target_core_xcopy.c          |   1 +
 fs/exec.c                                   |   1 +
 include/linux/audit.h                       |   1 +
 include/linux/cpumask.h                     |   4 +-
 include/linux/cpumask_types.h               |  12 +
 include/linux/dma-fence.h                   |   1 +
 include/linux/hrtimer.h                     |  46 +--
 include/linux/hrtimer_types.h               |  50 +++
 include/linux/ipc.h                         |   2 +-
 include/linux/irqflags.h                    |  14 +-
 include/linux/irqflags_types.h              |  22 ++
 include/linux/kmsan_types.h                 |   2 +
 include/linux/ktime.h                       |   8 +-
 include/linux/lockdep.h                     |  57 ----
 include/linux/lockdep_types.h               |  57 ++++
 include/linux/mm_types_task.h               |   7 +-
 include/linux/mutex.h                       |  52 +---
 include/linux/mutex_types.h                 |  71 +++++
 include/linux/nodemask.h                    |   2 +-
 include/linux/nodemask_types.h              |  10 +
 include/linux/nsproxy.h                     |   1 +
 include/linux/numa.h                        |  18 +-
 include/linux/pid.h                         | 140 ++++++++-
 include/linux/pid_types.h                   |  16 +
 include/linux/plist.h                       |  12 +-
 include/linux/plist_types.h                 |  17 ++
 include/linux/posix-timers.h                |  68 +----
 include/linux/posix-timers_types.h          |  72 +++++
 include/linux/prandom.h                     |   1 -
 include/linux/preempt.h                     |   6 +-
 include/linux/rcupdate.h                    |  11 +
 include/linux/refcount.h                    |  13 +-
 include/linux/refcount_types.h              |  19 ++
 include/linux/restart_block.h               |   2 +-
 include/linux/resume_user_mode.h            |   1 +
 include/linux/rhashtable-types.h            |   2 +-
 include/linux/rseq.h                        | 131 ++++++++
 include/linux/rslib.h                       |   1 -
 include/linux/sched.h                       | 320 ++------------------
 include/linux/sched/signal.h                |   1 +
 include/linux/sched/task_stack.h            |   1 +
 include/linux/seccomp.h                     |  22 +-
 include/linux/seccomp_types.h               |  26 ++
 include/linux/sem.h                         |  10 +-
 include/linux/sem_types.h                   |  13 +
 include/linux/seqlock.h                     |  79 +----
 include/linux/seqlock_types.h               |  93 ++++++
 include/linux/shm.h                         |   4 +-
 include/linux/signal.h                      |   1 +
 include/linux/signal_types.h                |   2 +-
 include/linux/spinlock.h                    |  31 ++
 include/linux/syscall_user_dispatch.h       |   9 +-
 include/linux/syscall_user_dispatch_types.h |  22 ++
 include/linux/thread_info.h                 |  49 ---
 include/linux/time_namespace.h              |   3 +
 include/linux/timekeeping.h                 |   1 +
 include/linux/timer.h                       |  16 +-
 include/linux/timer_types.h                 |  23 ++
 include/linux/timerqueue.h                  |  13 +-
 include/linux/timerqueue_types.h            |  17 ++
 include/linux/types.h                       |   3 +
 include/linux/uaccess.h                     |  49 +++
 include/linux/uidgid.h                      |  11 +-
 include/linux/uidgid_types.h                |  15 +
 include/linux/uio.h                         |   2 +-
 include/linux/wait.h                        |   1 -
 include/linux/workqueue.h                   |  16 +-
 include/linux/workqueue_types.h             |  25 ++
 include/uapi/linux/resource.h               |   2 +-
 init/init_task.c                            |   1 +
 ipc/shm.c                                   |   1 +
 kernel/Makefile                             |   1 +
 kernel/exit.c                               |   4 +-
 kernel/fork.c                               |   2 +
 kernel/futex/core.c                         |   1 +
 kernel/futex/requeue.c                      |   1 +
 kernel/futex/waitwake.c                     |   1 +
 kernel/numa.c                               |  24 ++
 kernel/pid_namespace.c                      |   1 +
 kernel/sched/core.c                         |   1 +
 mm/swapfile.c                               |   1 +
 security/selinux/hooks.c                    |   1 +
 security/smack/smack_lsm.c                  |   1 +
 96 files changed, 1068 insertions(+), 825 deletions(-)
 create mode 100644 include/linux/cpumask_types.h
 create mode 100644 include/linux/hrtimer_types.h
 create mode 100644 include/linux/irqflags_types.h
 create mode 100644 include/linux/mutex_types.h
 create mode 100644 include/linux/nodemask_types.h
 create mode 100644 include/linux/pid_types.h
 create mode 100644 include/linux/plist_types.h
 create mode 100644 include/linux/posix-timers_types.h
 create mode 100644 include/linux/refcount_types.h
 create mode 100644 include/linux/rseq.h
 create mode 100644 include/linux/seccomp_types.h
 create mode 100644 include/linux/sem_types.h
 create mode 100644 include/linux/seqlock_types.h
 create mode 100644 include/linux/syscall_user_dispatch_types.h
 create mode 100644 include/linux/timer_types.h
 create mode 100644 include/linux/timerqueue_types.h
 create mode 100644 include/linux/uidgid_types.h
 create mode 100644 include/linux/workqueue_types.h
 create mode 100644 kernel/numa.c
Signature · 1 line
2.43.0