big header dependency cleanup targeting sched.h
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest50 patches 45 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/50 | drivers/gpu/drm/i915/i915_memcpy.c: fix missing includesdrivers/ | +2 | 1 reply | |
| 2/50 | x86/kernel/fpu/bugs.c: fix missing includearch/ | +1 | 2 replies | |
| 3/50 | x86/lib/cache-smp.c: fix missing includearch/ | +1 | 3 replies | |
| 4/50 | x86/include/asm/debugreg.h: fix missing includearch/ | +1 | 0 replies | |
| 5/50 | x86/include/asm/paravirt_types.h: fix missing includearch/ | +2 | 0 replies | |
| 6/50 | task_stack.h: add missing includeinclude/ | +1 | 0 replies | |
| 7/50 | nsproxy.h: add missing includeinclude/ | +1 | 0 replies | |
| 8/50 | kernel/fork.c: add missing includekernel/ | +1 | 0 replies | |
| 9/50 | kmsan: add missing types.h dependencyinclude/ | +2 | 0 replies | |
| 10/50 | time_namespace.h: fix missing includeinclude/ | +1 | 0 replies | |
| 11/50 | nodemask: Split out include/linux/nodemask_types.hinclude/ include/ include/ | +12 | 0 replies | |
| 12/50 | prandom: Remove unused includeinclude/ | +0 | 2 replies | |
| 13/50 | timekeeping: Kill percpu.h dependencyinclude/ include/ | +3 | 0 replies | |
| 14/50 | arm64: Fix circular header dependencyarch/ | +2 | 0 replies | |
| 15/50 | kernel/numa.c: Move logging out of numa.hinclude/ kernel/ kernel/ | +30 | 4 replies | |
| 16/50 | sched.h: Move (spin|rwlock)_needbreak() to spinlock.hinclude/ include/ | +31 | 1 reply | |
| 17/50 | ktime.h: move ktime_t to types.hinclude/ include/ | +6 | 0 replies | |
| 18/50 | hrtimers: Split out hrtimer_types.hinclude/ include/ include/ | +53 | 0 replies | |
| 19/50 | locking/mutex: split out mutex_types.hinclude/ include/ include/ | +73 | 6 replies | |
| 20/50 | posix-cpu-timers: Split out posix-timers_types.hinclude/ include/ include/ | +76 | 0 replies | |
| 21/50 | locking/seqlock: Split out seqlock_types.hinclude/ include/ include/ | +96 | 1 reply | |
| 22/50 | pid: Split out pid_types.hdrivers/ include/ include/ +2 more | +22 | 1 reply | |
| 23/50 | sched.h: move pid helpers to pid.hinclude/ include/ include/ | +126 | 0 replies | |
| 24/50 | plist: Split out plist_types.hinclude/ include/ include/ +5 more | +24 | 0 replies | |
| 25/50 | wait: Remove uapi header file from main header fileinclude/ kernel/ kernel/ | +4 | 1 reply | |
| 26/50 | rslib: kill bogus dependency on list.hinclude/ | +0 | 3 replies | |
| 27/50 | timerqueue: Split out timerqueue_types.hinclude/ include/ include/ +1 more | +20 | 0 replies | |
| 28/50 | signal: Kill bogus dependency on list.hinclude/ include/ | +2 | 0 replies | |
| 29/50 | timers: Split out timer_types.hinclude/ include/ | +24 | 0 replies | |
| 30/50 | workqueue: Split out workqueue_types.hinclude/ include/ include/ +2 more | +29 | 0 replies | |
| 31/50 | shm: Slim down dependenciesinclude/ ipc/ security/ +1 more | +5 | 0 replies | |
| 32/50 | ipc: Kill bogus dependency on spinlock.hinclude/ include/ | +3 | 0 replies | |
| 33/50 | Split out irqflags_types.hinclude/ include/ include/ | +24 | 0 replies | |
| 34/50 | mm_types_task.h: Trim dependenciesinclude/ | +2 | 0 replies | |
| 35/50 | cpumask: Split out cpumask_types.harch/ include/ include/ | +14 | 0 replies | |
| 36/50 | syscall_user_dispatch.h: split out *_types.hinclude/ include/ include/ | +24 | 0 replies | |
| 37/50 | x86/signal: kill dependency on time.harch/ | +0 | 0 replies | |
| 38/50 | uapi/linux/resource.h: fix includeinclude/ | +1 | 0 replies | |
| 39/50 | refcount: Split out refcount_types.hinclude/ include/ include/ | +21 | 0 replies | |
| 40/50 | seccomp: Split out seccomp_types.hinclude/ include/ include/ | +28 | 0 replies | |
| 41/50 | uidgid: Split out uidgid_types.hinclude/ include/ include/ | +17 | 1 reply | |
| 42/50 | sem: Split out sem_types.hinclude/ include/ include/ +1 more | +17 | 3 replies | |
| 43/50 | lockdep: move held_lock to lockdep_types.hinclude/ include/ | +57 | 1 reply | |
| 44/50 | restart_block: Trim includesinclude/ include/ | +2 | 0 replies | |
| 45/50 | rseq: Split out rseq.h from sched.harch/ fs/ include/ +4 more | +137 | 0 replies | |
| 46/50 | preempt.h: Kill dependency on list.hinclude/ | +4 | 10 replies | |
| 47/50 | thread_info, uaccess.h: Move HARDENED_USERCOPY to better locationinclude/ include/ include/ | +50 | 0 replies | |
| 48/50 | Kill unnecessary kernel.h includearch/ arch/ | +2 | 0 replies | |
| 49/50 | kill unnecessary thread_info.h includearch/ arch/ | +2 | 0 replies | |
| 50/50 | Kill sched.h dependency on rcupdate.hinclude/ include/ | +14 | 5 replies |
Reviews trailers per patch
5 of 50 patches have a Reviewed-by or Acked-by.
| Patch | Christian Brauner | Waiman Long | Geert Uytterhoeven |
|---|---|---|---|
| 1/50 | |||
| 2/50 | |||
| 3/50 | |||
| 4/50 | |||
| 5/50 | |||
| 6/50 | |||
| 7/50 | |||
| 8/50 | |||
| 9/50 | |||
| 10/50 | |||
| 11/50 | |||
| 12/50 | |||
| 13/50 | |||
| 14/50 | |||
| 15/50 | |||
| 16/50 | |||
| 17/50 | |||
| 18/50 | |||
| 19/50 | |||
| 20/50 | |||
| 21/50 | A-b | ||
| 22/50 | |||
| 23/50 | |||
| 24/50 | |||
| 25/50 | R-b | ||
| 26/50 | |||
| 27/50 | |||
| 28/50 | |||
| 29/50 | |||
| 30/50 | |||
| 31/50 | |||
| 32/50 | |||
| 33/50 | |||
| 34/50 | |||
| 35/50 | |||
| 36/50 | |||
| 37/50 | |||
| 38/50 | |||
| 39/50 | |||
| 40/50 | |||
| 41/50 | R-b | ||
| 42/50 | |||
| 43/50 | A-b | ||
| 44/50 | |||
| 45/50 | |||
| 46/50 | |||
| 47/50 | |||
| 48/50 | |||
| 49/50 | |||
| 50/50 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 00/50] big header dependency cleanup targeting sched.h
the issue being targeted here is that sched.h is entirely too much of an everything header, and a nexus of recursive header dependencies.
the main strategy is to try to only pull type definitions into sched.h, by splitting out *_types.h versions of sched.h dependencies, and secondarily moving code out of sched.h into more appropriate locations.
this patchset does not go quite as far as I would have liked; arch/x86/include/asm/processor.h also pulls in way too much, and I would like to also split out a _types.h version for that, but that would entail changing every arch's version of that header and I'm not going to tackle that yet.
if we do get that done, the number of headers pulled in by sched.h will be cut approximately in half (from well over 300 to 170-180) on an allyesconfig.
build tested on x86, still needs build testing on other archs
https://evilpiepirate.org/git/bcachefs.git/log/?h=header_cleanup
Kent Overstreet (49):
drivers/gpu/drm/i915/i915_memcpy.c: fix missing includes x86/kernel/fpu/bugs.c: fix missing include x86/lib/cache-smp.c: fix missing include x86/include/asm/debugreg.h: fix missing include x86/include/asm/paravirt_types.h: fix missing include task_stack.h: add missing include
nsproxy.h: add missing include
kernel/fork.c: add missing include
kmsan: add missing types.h dependency time_namespace.h: fix missing include
nodemask: Split out include/linux/nodemask_types.h
prandom: Remove unused include
timekeeping: Kill percpu.h dependency
arm64: Fix circular header dependency
kernel/numa.c: Move logging out of numa.h
sched.h: Move (spin|rwlock)_needbreak() to spinlock.h ktime.h: move ktime_t to types.h
hrtimers: Split out hrtimer_types.h
locking/mutex: split out mutex_types.h
posix-cpu-timers: Split out posix-timers_types.h locking/seqlock: Split out seqlock_types.h
pid: Split out pid_types.h
sched.h: move pid helpers to pid.h
plist: Split out plist_types.h
rslib: kill bogus dependency on list.h
timerqueue: Split out timerqueue_types.h
signal: Kill bogus dependency on list.h
timers: Split out timer_types.h
workqueue: Split out workqueue_types.h
shm: Slim down dependencies
ipc: Kill bogus dependency on spinlock.h
Split out irqflags_types.h
mm_types_task.h: Trim dependencies
cpumask: Split out cpumask_types.h syscall_user_dispatch.h: split out *_types.h x86/signal: kill dependency on time.h uapi/linux/resource.h: fix include
refcount: Split out refcount_types.h
seccomp: Split out seccomp_types.h
uidgid: Split out uidgid_types.h
sem: Split out sem_types.h
lockdep: move held_lock to lockdep_types.h
restart_block: Trim includes
rseq: Split out rseq.h from sched.h
preempt.h: Kill dependency on list.h
thread_info, uaccess.h: Move HARDENED_USERCOPY to better location Kill unnecessary kernel.h include
kill unnecessary thread_info.h include
Kill sched.h dependency on rcupdate.h
Matthew Wilcox (Oracle) (1):
wait: Remove uapi header file from main header file
arch/arm64/include/asm/spectre.h | 4 +- arch/x86/include/asm/current.h | 1 + arch/x86/include/asm/debugreg.h | 1 + arch/x86/include/asm/fpu/types.h | 2 + arch/x86/include/asm/paravirt_types.h | 2 + arch/x86/include/asm/percpu.h | 2 +- arch/x86/include/asm/preempt.h | 1 - arch/x86/include/asm/tlbbatch.h | 2 +- arch/x86/include/uapi/asm/signal.h | 1 - arch/x86/kernel/fpu/bugs.c | 1 + arch/x86/kernel/signal.c | 1 + arch/x86/lib/cache-smp.c | 1 + drivers/gpu/drm/i915/i915_memcpy.c | 2 + drivers/target/target_core_xcopy.c | 1 + fs/exec.c | 1 + include/linux/audit.h | 1 + include/linux/cpumask.h | 4 +- include/linux/cpumask_types.h | 12 + include/linux/dma-fence.h | 1 + include/linux/hrtimer.h | 46 +-- include/linux/hrtimer_types.h | 50 +++ include/linux/ipc.h | 2 +- include/linux/irqflags.h | 14 +- include/linux/irqflags_types.h | 22 ++ include/linux/kmsan_types.h | 2 + include/linux/ktime.h | 8 +- include/linux/lockdep.h | 57 ---- include/linux/lockdep_types.h | 57 ++++ include/linux/mm_types_task.h | 7 +- include/linux/mutex.h | 52 +--- include/linux/mutex_types.h | 71 +++++ include/linux/nodemask.h | 2 +- include/linux/nodemask_types.h | 10 + include/linux/nsproxy.h | 1 + include/linux/numa.h | 18 +- include/linux/pid.h | 140 ++++++++- include/linux/pid_types.h | 16 + include/linux/plist.h | 12 +- include/linux/plist_types.h | 17 ++ include/linux/posix-timers.h | 68 +---- include/linux/posix-timers_types.h | 72 +++++ include/linux/prandom.h | 1 - include/linux/preempt.h | 6 +- include/linux/rcupdate.h | 11 + include/linux/refcount.h | 13 +- include/linux/refcount_types.h | 19 ++ include/linux/restart_block.h | 2 +- include/linux/resume_user_mode.h | 1 + include/linux/rhashtable-types.h | 2 +- include/linux/rseq.h | 131 ++++++++ include/linux/rslib.h | 1 - include/linux/sched.h | 320 ++------------------ include/linux/sched/signal.h | 1 + include/linux/sched/task_stack.h | 1 + include/linux/seccomp.h | 22 +- include/linux/seccomp_types.h | 26 ++ include/linux/sem.h | 10 +- include/linux/sem_types.h | 13 + include/linux/seqlock.h | 79 +---- include/linux/seqlock_types.h | 93 ++++++ include/linux/shm.h | 4 +- include/linux/signal.h | 1 + include/linux/signal_types.h | 2 +- include/linux/spinlock.h | 31 ++ include/linux/syscall_user_dispatch.h | 9 +- include/linux/syscall_user_dispatch_types.h | 22 ++ include/linux/thread_info.h | 49 --- include/linux/time_namespace.h | 3 + include/linux/timekeeping.h | 1 + include/linux/timer.h | 16 +- include/linux/timer_types.h | 23 ++ include/linux/timerqueue.h | 13 +- include/linux/timerqueue_types.h | 17 ++ include/linux/types.h | 3 + include/linux/uaccess.h | 49 +++ include/linux/uidgid.h | 11 +- include/linux/uidgid_types.h | 15 + include/linux/uio.h | 2 +- include/linux/wait.h | 1 - include/linux/workqueue.h | 16 +- include/linux/workqueue_types.h | 25 ++ include/uapi/linux/resource.h | 2 +- init/init_task.c | 1 + ipc/shm.c | 1 + kernel/Makefile | 1 + kernel/exit.c | 4 +- kernel/fork.c | 2 + kernel/futex/core.c | 1 + kernel/futex/requeue.c | 1 + kernel/futex/waitwake.c | 1 + kernel/numa.c | 24 ++ kernel/pid_namespace.c | 1 + kernel/sched/core.c | 1 + mm/swapfile.c | 1 + security/selinux/hooks.c | 1 + security/smack/smack_lsm.c | 1 + 96 files changed, 1068 insertions(+), 825 deletions(-) create mode 100644 include/linux/cpumask_types.h create mode 100644 include/linux/hrtimer_types.h create mode 100644 include/linux/irqflags_types.h create mode 100644 include/linux/mutex_types.h create mode 100644 include/linux/nodemask_types.h create mode 100644 include/linux/pid_types.h create mode 100644 include/linux/plist_types.h create mode 100644 include/linux/posix-timers_types.h create mode 100644 include/linux/refcount_types.h create mode 100644 include/linux/rseq.h create mode 100644 include/linux/seccomp_types.h create mode 100644 include/linux/sem_types.h create mode 100644 include/linux/seqlock_types.h create mode 100644 include/linux/syscall_user_dispatch_types.h create mode 100644 include/linux/timer_types.h create mode 100644 include/linux/timerqueue_types.h create mode 100644 include/linux/uidgid_types.h create mode 100644 include/linux/workqueue_types.h create mode 100644 kernel/numa.c
Signature · 1 line
2.43.0