Skip to content

tap: Use g_spawn_sync() and g_spawn_check_wait_status()

Akihiko Odaki qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected] change-id 20231219-glib-034a34bb05d8

Versions newest first

  1. v4 Latest2 patches 2 repliesIn review
  2. v32 patches 0 repliesSuperseded
  3. v22 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches1 replySuperseded

Changes in v4 from the cover letter

- Changed to use g_spawn_async_with_pipes_and_fds() when available. (Daniel P. Berrangé)
- Link to v3: https://lore.kernel.org/r/[email protected]

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2glib-compat: Define g_spawn_check_wait_status()include/glib-compat.h+11 -01 reply
2/2tap: Use g_spawn_sync() and g_spawn_check_wait_status()net/tap.c+117 -1031 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLei YangDaniel P. Berrangé
1/2T-b R-b
2/2T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()

g_spawn_sync() gives an informative message if it fails to execute the script instead of reporting exiting status 1.

g_spawn_check_wait_status() also gives an message easier to understand than the raw value returned by waitpid().

---
Changes in v4:
- Changed to use g_spawn_async_with_pipes_and_fds() when available. (Daniel P. Berrangé)
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Added GLIB_CHECK_VERSION(2, 70, 0) for patch "glib-compat: Define g_spawn_check_wait_status()". (Daniel P. Berrangé)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Rebased.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Akihiko Odaki (2):
glib-compat: Define g_spawn_check_wait_status()
tap: Use g_spawn_sync() and g_spawn_check_wait_status()

 include/glib-compat.h |  11 +++
 net/tap.c             | 220 +++++++++++++++++++++++++++-----------------------
 2 files changed, 128 insertions(+), 103 deletions(-)

---
base-commit: 38d0939b86e2eef6f6a622c6f1f7befda0146595
change-id: 20231219-glib-034a34bb05d8

Best regards,

Signature · 1 line
Akihiko Odaki <[email protected]>