tap: Use g_spawn_sync() and g_spawn_check_wait_status()
Get series with b4
b4 am [email protected] change-id 20231219-glib-034a34bb05d8Versions newest first
- v4 Latest2 patches 2 repliesIn review
- v32 patches 0 repliesSuperseded
- v22 patches 5 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 2 patches | 1 reply | Superseded |
Changes in v4 from the cover letter
- Changed to use g_spawn_async_with_pipes_and_fds() when available. (Daniel P. Berrangé)
- Link to v3: https://lore.kernel.org/r/[email protected]
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | glib-compat: Define g_spawn_check_wait_status()include/ | +11 | 1 reply | |
| 2/2 | tap: Use g_spawn_sync() and g_spawn_check_wait_status()net/ | +117 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Lei Yang | Daniel P. Berrangé |
|---|---|---|
| 1/2 | T-b | R-b |
| 2/2 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/2] tap: Use g_spawn_sync() and g_spawn_check_wait_status()
g_spawn_sync() gives an informative message if it fails to execute the script instead of reporting exiting status 1.
g_spawn_check_wait_status() also gives an message easier to understand than the raw value returned by waitpid().
---
Changes in v4:
- Changed to use g_spawn_async_with_pipes_and_fds() when available. (Daniel P. Berrangé)
- Link to v3: https://lore.kernel.org/r/[email protected]
Changes in v3:
- Added GLIB_CHECK_VERSION(2, 70, 0) for patch "glib-compat: Define g_spawn_check_wait_status()". (Daniel P. Berrangé)
- Link to v2: https://lore.kernel.org/r/[email protected]
Changes in v2:
- Rebased.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Akihiko Odaki (2):
glib-compat: Define g_spawn_check_wait_status()
tap: Use g_spawn_sync() and g_spawn_check_wait_status()
include/glib-compat.h | 11 +++ net/tap.c | 220 +++++++++++++++++++++++++++----------------------- 2 files changed, 128 insertions(+), 103 deletions(-)
---
base-commit: 38d0939b86e2eef6f6a622c6f1f7befda0146595
change-id: 20231219-glib-034a34bb05d8
Best regards,
Signature · 1 line
Akihiko Odaki <[email protected]>