Skip to content

bcachefs: fiemap delalloc support and cleanup

Brian Foster linux-bcachefs 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest4 patches 0 repliesNew
  2. v34 patches 4 repliesSuperseded
  3. v24 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches8 repliesSuperseded

Changes in v4 from the cover letter

- Implement a do_drop_locks() like pattern in bch2_fiemap_hole() to
avoid deadlock and livelock or excessive spinning.
v3: https://lore.kernel.org/linux-bcachefs/[email protected]/
- Use nonblocking pagecache seek to address extent btree vs. folio deadlocks.
v2: https://lore.kernel.org/linux-bcachefs/[email protected]/
- Clean up bch2_fiemap() a bit to use processing helpers.
- Added patch for sync flag fixup.
v1: https://lore.kernel.org/linux-bcachefs/[email protected]/

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4bcachefs: drop duplicate fiemap sync flagfs/bcachefs/fs.c+1 -10 replies
2/4bcachefs: track current fiemap offset in start variablefs/bcachefs/fs.c+2 -20 replies
3/4bcachefs: refactor fiemap processing into extent helper and structfs/bcachefs/fs.c+55 -350 replies
4/4bcachefs: add fiemap delalloc extent detectionfs/bcachefs/fs.c+112 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/4] bcachefs: fiemap delalloc support and cleanup

Hi all,

This is mostly equivalent to v3 except that bch2_fiemap_hole() now implements a do_drop_locks() style pattern to manage locking order between folios and the extent tree. The pagecache scan is factored out into a new helper to facilitate the retry.

Patches also available in my test branch:

https://evilpiepirate.org/~testdashboard/ci?branch=bfoster

Brian

v4:
- Implement a do_drop_locks() like pattern in bch2_fiemap_hole() to
avoid deadlock and livelock or excessive spinning.
v3: https://lore.kernel.org/linux-bcachefs/[email protected]/
- Use nonblocking pagecache seek to address extent btree vs. folio deadlocks.
v2: https://lore.kernel.org/linux-bcachefs/[email protected]/
- Clean up bch2_fiemap() a bit to use processing helpers.
- Added patch for sync flag fixup.
v1: https://lore.kernel.org/linux-bcachefs/[email protected]/

Brian Foster (4):
bcachefs: drop duplicate fiemap sync flag
bcachefs: track current fiemap offset in start variable
bcachefs: refactor fiemap processing into extent helper and struct
bcachefs: add fiemap delalloc extent detection

 fs/bcachefs/fs.c | 207 +++++++++++++++++++++++++++++++++++++----------
 1 file changed, 166 insertions(+), 41 deletions(-)
Signature · 1 line
2.44.0