Skip to content

Surface fan monitoring driver

Ivor Wanders linux-doc linux-hwmon lkml platform-driver-x86 5 versions – Applied

Status from this message: Applied.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest2 patches 6 repliesApplied
  2. v42 patches 2 repliesSuperseded
  3. v32 patches 3 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches6 repliesSuperseded
v12 patches3 repliesSuperseded

Changes in v5 from the cover letter

- Rebased on mainline kernel tree's master branch.

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/2hwmon: add fan speed monitoring driver for Surface devicesDocumentation/hwmon/index.rst Documentation/hwmon/surface_fan.rst MAINTAINERS +3 more+139 -01 reply
2/2platform/surface: aggregator_registry: add entry for fan speeddrivers/platform/surface/surface_aggregator_registry.c+7 -05 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMaximilian LuzArmin Wolf
1/2R-b R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/2] Surface fan monitoring driver

Fifth version of a hwmon driver to monitor the fan's rpm on Microsoft Surface devices, originally submitted in [1], [2], [3], v4 at [4]. Only change since v4 is rebasing on mainline kernel tree's master.

Changes in v5:
- Rebased on mainline kernel tree's master branch.
Changes in v4:
- Return 0 from surface_fan_hwmon_read instead of ret.
- Use PTR_ERR_OR_ZERO in probe instead of if statement.
Changes in v3:
- Removed type and attr checks in read and is_visible.
- Removed assigning sdev to ssam_device drvdata.
- Propagate return from __ssam_fan_rpm_get.
- Renamed hwmon chip name from 'fan' to 'surface_fan'.
- Removed unnecessary platform_device header.
Changes in v2:
- Removed all unsupported sysfs attributes from the hwmon driver, leaving the fan input as the only supported attribute.

[1] https://lore.kernel.org/linux-hwmon/[email protected]/T/
[2] https://lore.kernel.org/linux-hwmon/[email protected]/T/
[3] https://lore.kernel.org/linux-hwmon/[email protected]/T/
[4] https://lore.kernel.org/linux-hwmon/[email protected]/T/

Ivor Wanders (2):
hwmon: add fan speed monitoring driver for Surface devices platform/surface: aggregator_registry: add entry for fan speed

 Documentation/hwmon/index.rst                 |  1 +
 Documentation/hwmon/surface_fan.rst           | 25 +++++
 MAINTAINERS                                   |  8 ++
 drivers/hwmon/Kconfig                         | 13 +++
 drivers/hwmon/Makefile                        |  1 +
 drivers/hwmon/surface_fan.c                   | 91 +++++++++++++++++++
 .../surface/surface_aggregator_registry.c     |  7 ++
 7 files changed, 146 insertions(+)
 create mode 100644 Documentation/hwmon/surface_fan.rst
 create mode 100644 drivers/hwmon/surface_fan.c
Signature · 1 line
2.17.1