Skip to content

Fix some kernel panics due to the host sending invalid PDUs

Maurizio Lombardi linux-nvme 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 7 repliesIn review
  2. v12 patches 3 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nvmet-tcp: Fix a kernel panic when host sends an invalid H2C PDU lengthdrivers/nvme/target/tcp.c+12 -11 reply
2/3nvmet-tcp: fix a crash in nvmet_req_complete()drivers/nvme/target/tcp.c+1 -24 replies
3/3nvmet-tcp: remove boilerplate codedrivers/nvme/target/tcp.c+8 -81 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchKeith BuschSagi Grimberg
1/3R-b
2/3R-b R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH V2 0/3] Fix some kernel panics due to the host sending invalid PDUs

I used the reproducer that was published here:
https://lore.kernel.org/linux-nvme/[email protected]/T/#m57f25abc944dc706125fed02cb99d86b56c5d36e

I didn't get the same call trace, however.

V2: Be sure the DATAL field is consistent with the packet size.
Add a third patch that cleans up the error code path.

Maurizio Lombardi (3):
nvmet-tcp: Fix a kernel panic when host sends an invalid H2C PDU
length
nvmet-tcp: fix a crash in nvmet_req_complete()
nvmet-tcp: remove boilerplate code

 drivers/nvme/target/tcp.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)
Signature · 1 line
2.39.3