PCI: Solve two bridge window sizing issues
Status from this message: Applied to pci/resource for v6.11, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest8 patches 7 repliesApplied
- v27 patches 22 repliesSuperseded
- v17 patches 11 repliesSuperseded
Changes in v3 from the cover letter
- Removed "slot" wording
- Renamed find_empty_resource_slot() -> find_resource_space()
- find_resource_space() returns bool instead of int
- Added patch to convert literal 20 related to bridge win minimum alignment to __ffs(SZ_1M)
- Fixed kerneldoc missing "struct"
- Tweaked prints (one dbg -> info, added new dbg one for success case)
- Changelog tweaks
- Take account largest >> 1 (in alignment calc)
- Adjust to minor changes made into calculate_memsize()
- Take logs from more recent kernel to get rid of reg 0xXX
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | PCI: Fix resource double counting on remove & rescandrivers/ | +2 | 0 replies | |
| 2/8 | resource: Rename find_resource() to find_resource_space()kernel/ | +11 | 0 replies | |
| 3/8 | resource: Document find_resource_space() and resource_constraintkernel/ | +26 | 0 replies | |
| 4/8 | resource: Use typedef for alignf callbackdrivers/ include/ include/ +1 more | +23 | 0 replies | |
| 5/8 | resource: Handle simple alignment inside __find_resource_space()kernel/ | +7 | 0 replies | |
| 6/8 | resource: Export find_resource_space()include/ kernel/ | +26 | 0 replies | |
| 7/8 | PCI: Make minimum bridge window alignment reference more obviousdrivers/ | +4 | 3 replies | |
| 8/8 | PCI: Relax bridge window tail sizing rulesdrivers/ | +77 | 1 reply |
Reviews trailers per patch
All 8 patches have a Reviewed-by or Acked-by.
| Patch | Lidong Wang | Mika Westerberg | Andy Shevchenko |
|---|---|---|---|
| 1/8 | T-b | R-b | |
| 2/8 | T-b | R-b | R-b |
| 3/8 | T-b | R-b | R-b |
| 4/8 | T-b | R-b | R-b |
| 5/8 | T-b | R-b | R-b |
| 6/8 | T-b | R-b | R-b |
| 7/8 | R-b | ||
| 8/8 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v3 0/8] PCI: Solve two bridge window sizing issues
Hi all,
Here's a series that contains two fixes to PCI bridge window sizing algorithm. Together, they should enable remove & rescan cycle to work for a PCI bus that has PCI devices with optional resources and/or disparity in BAR sizes.
For the second fix, I chose to expose find_resource_space() from kernel/resource.c because it should increase accuracy of the cannot-fit decision (currently that function is called find_resource()). In order to do that sensibly, a few improvements seemed in order to make its interface and name of the function sane before exposing it. Thus, the few extra patches on resource side.
v3:
- Removed "slot" wording
- Renamed find_empty_resource_slot() -> find_resource_space()
- find_resource_space() returns bool instead of int
- Added patch to convert literal 20 related to bridge win minimum alignment to __ffs(SZ_1M)
- Fixed kerneldoc missing "struct"
- Tweaked prints (one dbg -> info, added new dbg one for success case)
- Changelog tweaks
- Take account largest >> 1 (in alignment calc)
- Adjust to minor changes made into calculate_memsize()
- Take logs from more recent kernel to get rid of reg 0xXX
v2:
- Add "typedef" to kerneldoc to get correct formatting
- Use RESOURCE_SIZE_MAX instead of literal
- Remove unnecessary checks for io{port/mem}_resource
- Apply a few style tweaks from Andy
Ilpo Järvinen (8):
PCI: Fix resource double counting on remove & rescan
resource: Rename find_resource() to find_resource_space()
resource: Document find_resource_space() and resource_constraint
resource: Use typedef for alignf callback
resource: Handle simple alignment inside __find_resource_space()
resource: Export find_resource_space()
PCI: Make minimum bridge window alignment reference more obvious
PCI: Relax bridge window tail sizing rules
drivers/pci/bus.c | 10 +---- drivers/pci/setup-bus.c | 91 +++++++++++++++++++++++++++++++++++++---- include/linux/ioport.h | 44 ++++++++++++++++++-- include/linux/pci.h | 5 +-- kernel/resource.c | 68 ++++++++++++++---------------- 5 files changed, 157 insertions(+), 61 deletions(-)
Signature · 1 line
2.39.2