Skip to content

PCI: Solve two bridge window sizing issues

Ilpo Järvinen linux-pci lkml 3 versions – Applied

Status from this message: Applied to pci/resource for v6.11, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest8 patches 7 repliesApplied
  2. v27 patches 22 repliesSuperseded
  3. v17 patches 11 repliesSuperseded

Changes in v3 from the cover letter

- Removed "slot" wording
- Renamed find_empty_resource_slot() -> find_resource_space()
- find_resource_space() returns bool instead of int
- Added patch to convert literal 20 related to bridge win minimum alignment to __ffs(SZ_1M)
- Fixed kerneldoc missing "struct"
- Tweaked prints (one dbg -> info, added new dbg one for success case)
- Changelog tweaks
- Take account largest >> 1 (in alignment calc)
- Adjust to minor changes made into calculate_memsize()
- Take logs from more recent kernel to get rid of reg 0xXX

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/8PCI: Fix resource double counting on remove & rescandrivers/pci/setup-bus.c+2 -40 replies
2/8resource: Rename find_resource() to find_resource_space()kernel/resource.c+11 -120 replies
3/8resource: Document find_resource_space() and resource_constraintkernel/resource.c+26 -30 replies
4/8resource: Use typedef for alignf callbackdrivers/pci/bus.c include/linux/ioport.h include/linux/pci.h +1 more+23 -220 replies
5/8resource: Handle simple alignment inside __find_resource_space()kernel/resource.c+7 -130 replies
6/8resource: Export find_resource_space()include/linux/ioport.h kernel/resource.c+26 -220 replies
7/8PCI: Make minimum bridge window alignment reference more obviousdrivers/pci/setup-bus.c+4 -23 replies
8/8PCI: Relax bridge window tail sizing rulesdrivers/pci/setup-bus.c+77 -21 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchLidong WangMika WesterbergAndy Shevchenko
1/8T-b R-b
2/8T-b R-b R-b
3/8T-b R-b R-b
4/8T-b R-b R-b
5/8T-b R-b R-b
6/8T-b R-b R-b
7/8R-b
8/8T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/8] PCI: Solve two bridge window sizing issues

Hi all,

Here's a series that contains two fixes to PCI bridge window sizing algorithm. Together, they should enable remove & rescan cycle to work for a PCI bus that has PCI devices with optional resources and/or disparity in BAR sizes.

For the second fix, I chose to expose find_resource_space() from kernel/resource.c because it should increase accuracy of the cannot-fit decision (currently that function is called find_resource()). In order to do that sensibly, a few improvements seemed in order to make its interface and name of the function sane before exposing it. Thus, the few extra patches on resource side.

v3:
- Removed "slot" wording
- Renamed find_empty_resource_slot() -> find_resource_space()
- find_resource_space() returns bool instead of int
- Added patch to convert literal 20 related to bridge win minimum alignment to __ffs(SZ_1M)
- Fixed kerneldoc missing "struct"
- Tweaked prints (one dbg -> info, added new dbg one for success case)
- Changelog tweaks
- Take account largest >> 1 (in alignment calc)
- Adjust to minor changes made into calculate_memsize()
- Take logs from more recent kernel to get rid of reg 0xXX

v2:
- Add "typedef" to kerneldoc to get correct formatting
- Use RESOURCE_SIZE_MAX instead of literal
- Remove unnecessary checks for io{port/mem}_resource
- Apply a few style tweaks from Andy

Ilpo Järvinen (8):
PCI: Fix resource double counting on remove & rescan
resource: Rename find_resource() to find_resource_space()
resource: Document find_resource_space() and resource_constraint
resource: Use typedef for alignf callback
resource: Handle simple alignment inside __find_resource_space()
resource: Export find_resource_space()
PCI: Make minimum bridge window alignment reference more obvious
PCI: Relax bridge window tail sizing rules

 drivers/pci/bus.c       | 10 +----
 drivers/pci/setup-bus.c | 91 +++++++++++++++++++++++++++++++++++++----
 include/linux/ioport.h  | 44 ++++++++++++++++++--
 include/linux/pci.h     |  5 +--
 kernel/resource.c       | 68 ++++++++++++++----------------
 5 files changed, 157 insertions(+), 61 deletions(-)
Signature · 1 line
2.39.2