Skip to content

IIO: Clean up ACPI_PTR() usage.

Jonathan Cameron linux-iio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest24 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/24iio: accel: da280: Stop using ACPI_PTR()drivers/iio/accel/da280.c+1 -11 reply
2/24iio: accel: kxcjk-1013: Move acpi_device_id table under ifdef CONFIG_ACPIdrivers/iio/accel/kxcjk-1013.c+17 -162 replies
3/24iio: accel: mma9551: Drop ACPI_PTR() usagedrivers/iio/accel/mma9551.c+2 -20 replies
4/24iio: accel: mma9553: Drop ACPI_PTR() usagedrivers/iio/accel/mma9553.c+2 -20 replies
5/24iio: accel: mxc4005: Drop ACPI_PTR() usagedrivers/iio/accel/mxc4005.c+2 -21 reply
6/24iio: accel: mxc6255: Drop ACPI_PTR() usagedrivers/iio/accel/mxc6255.c+2 -20 replies
7/24iio: accel: stk8ba50: Drop ACPI_PTR() usagedrivers/iio/accel/stk8ba50.c+2 -20 replies
8/24iio: accel: bmc150: Drop ACPI_PTR()drivers/iio/accel/bmc150-accel-i2c.c drivers/iio/accel/bmc150-accel-spi.c+2 -30 replies
9/24iio: gyro: bmg160: Drop ACPI_PTR() usagedrivers/iio/gyro/bmg160_i2c.c+2 -20 replies
10/24iio: humidity: hts221: Drop ACPI_PTR() usagedrivers/iio/humidity/hts221_i2c.c+2 -20 replies
11/24iio: imu: fxos8700: Drop ACPI_PTR() usagedrivers/iio/imu/fxos8700_i2c.c drivers/iio/imu/fxos8700_spi.c+2 -40 replies
12/24iio: imu: kmx61: Drop ACPI_PTR() usagedrivers/iio/imu/kmx61.c+1 -10 replies
13/24iio: light: jsa1212: Drop ACPI_PTR() usagedrivers/iio/light/jsa1212.c+2 -20 replies
14/24iio: light: ltr501: Drop ACPI_PTR() usagedrivers/iio/light/ltr501.c+2 -10 replies
15/24iio: light: rpr0521: Drop ACPI_PTR() usagedrivers/iio/light/rpr0521.c+2 -20 replies
16/24iio: light: stk3310: Drop ACPI_PTR() usagedrivers/iio/light/stk3310.c+2 -20 replies
17/24iio: light: us5182d: Drop ACPI_PTR() usagedrivers/iio/light/us5182d.c+2 -20 replies
18/24iio: magnetometer: bmc150: Drop ACPI_PTR() usagedrivers/iio/magnetometer/bmc150_magn_i2c.c drivers/iio/magnetometer/bmc150_magn_spi.c+2 -40 replies
19/24iio: magnetometer: mmc35240: Drop ACPI_PTR() usagedrivers/iio/magnetometer/mmc35240.c+2 -20 replies
20/24iio: potentiometer: max5487: Drop ACPI_PTR() usagedrivers/iio/potentiometer/max5487.c+2 -20 replies
21/24iio: st_sensors: drop ACPI_PTR() and CONFIG_ACPI guardsdrivers/iio/accel/st_accel_i2c.c drivers/iio/pressure/st_pressure_i2c.c+2 -80 replies
22/24iio: pressure: hp206c: drop ACPI_PTR() and CONFIG_ACPI guardsdrivers/iio/pressure/hp206c.c+2 -40 replies
23/24iio: light: max44000: drop ACPI_PTR() and CONFIG_ACPI guardsdrivers/iio/light/max44000.c+2 -40 replies
24/24iio: adc: ti-adc109s102: drop ACPI_PTR() and CONFIG_ACPI guardsdrivers/iio/adc/ti-adc108s102.c+1 -30 replies

Reviews trailers per patch

2 of 24 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchHans de GoedeAndy Shevchenko
SeriesR-b
1/24R-b
2/24R-b
3/24
4/24
5/24
6/24
7/24
8/24
9/24
10/24
11/24
12/24
13/24
14/24
15/24
16/24
17/24
18/24
19/24
20/24
21/24
22/24
23/24
24/24

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/24] IIO: Clean up ACPI_PTR() usage.

From: Jonathan Cameron <[email protected]>

Many of these patches touch ancient drivers so the authors have long moved on to other things. As such I'd appreciate it if anyone has time to take a look!

The initial part of this series deals with cases where unused variable warnings are generated with !CONFIG_ACPI but they most date back long enough to predate this being reported by lkp in general and the lkp folk have gotten push back not to push out such reports due to the high level of noise. I think some of these were reported to me directly on my Huawei.com account but aren't on lore.kernel.org. If I can easily track down appropriate closes tags I will add them when applying.

The last few patches are for drivers that did have the right protections but where the usage was so trivial I'm not convinced they took the best approach. In the interests of not leaving cases of what I consider an undesirable pattern around for people to copy I have dropped the ACPI_PTR() usage and config guards from those as well.

There are 3 remaining cases of ACPI_PTR() in IIO. In each of those there is a significant chunk of ACPI specific handling so the relevant guards are there anyway and the complexity is more easily justified. I have not intent to touch those at this time.

Jonathan Cameron (24):
iio: accel: da280: Stop using ACPI_PTR()
iio: accel: kxcjk-1013: Move acpi_device_id table under ifdef
CONFIG_ACPI
iio: accel: mma9551: Drop ACPI_PTR() usage
iio: accel: mma9553: Drop ACPI_PTR() usage
iio: accel: mxc4005: Drop ACPI_PTR() usage
iio: accel: mxc6255: Drop ACPI_PTR() usage
iio: accel: stk8ba50: Drop ACPI_PTR() usage
iio: accel: bmc150: Drop ACPI_PTR()
iio: gyro: bmg160: Drop ACPI_PTR() usage
iio: humidity: hts221: Drop ACPI_PTR() usage
iio: imu: fxos8700: Drop ACPI_PTR() usage
iio: imu: kmx61: Drop ACPI_PTR() usage
iio: light: jsa1212: Drop ACPI_PTR() usage
iio: light: ltr501: Drop ACPI_PTR() usage
iio: light: rpr0521: Drop ACPI_PTR() usage
iio: light: stk3310: Drop ACPI_PTR() usage
iio: light: us5182d: Drop ACPI_PTR() usage
iio: magnetometer: bmc150: Drop ACPI_PTR() usage
iio: magnetometer: mmc35240: Drop ACPI_PTR() usage
iio: potentiometer: max5487: Drop ACPI_PTR() usage
iio: st_sensors: drop ACPI_PTR() and CONFIG_ACPI guards
iio: pressure: hp206c: drop ACPI_PTR() and CONFIG_ACPI guards
iio: light: max44000: drop ACPI_PTR() and CONFIG_ACPI guards
iio: adc: ti-adc109s102: drop ACPI_PTR() and CONFIG_ACPI guards

 drivers/iio/accel/bmc150-accel-i2c.c       |  2 +-
 drivers/iio/accel/bmc150-accel-spi.c       |  3 +-
 drivers/iio/accel/da280.c                  |  2 +-
 drivers/iio/accel/kxcjk-1013.c             | 33 +++++++++++-----------
 drivers/iio/accel/mma9551.c                |  4 +--
 drivers/iio/accel/mma9553.c                |  4 +--
 drivers/iio/accel/mxc4005.c                |  4 +--
 drivers/iio/accel/mxc6255.c                |  4 +--
 drivers/iio/accel/st_accel_i2c.c           |  5 +---
 drivers/iio/accel/stk8ba50.c               |  4 +--
 drivers/iio/adc/ti-adc108s102.c            |  4 +--
 drivers/iio/gyro/bmg160_i2c.c              |  4 +--
 drivers/iio/humidity/hts221_i2c.c          |  4 +--
 drivers/iio/imu/fxos8700_i2c.c             |  3 +-
 drivers/iio/imu/fxos8700_spi.c             |  3 +-
 drivers/iio/imu/kmx61.c                    |  2 +-
 drivers/iio/light/jsa1212.c                |  4 +--
 drivers/iio/light/ltr501.c                 |  3 +-
 drivers/iio/light/max44000.c               |  6 ++--
 drivers/iio/light/rpr0521.c                |  4 +--
 drivers/iio/light/stk3310.c                |  4 +--
 drivers/iio/light/us5182d.c                |  4 +--
 drivers/iio/magnetometer/bmc150_magn_i2c.c |  3 +-
 drivers/iio/magnetometer/bmc150_magn_spi.c |  3 +-
 drivers/iio/magnetometer/mmc35240.c        |  4 +--
 drivers/iio/potentiometer/max5487.c        |  4 +--
 drivers/iio/pressure/hp206c.c              |  6 ++--
 drivers/iio/pressure/st_pressure_i2c.c     |  5 +---
 28 files changed, 60 insertions(+), 75 deletions(-)
Signature · 1 line
2.43.0