Skip to content

Fix regression in "Ignore journal log writes for jdata holes"

Bob Peterson cluster-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 2 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 2 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Cluster-devel] [GFS2 PATCH 0/2] Fix regression in "Ignore journal log writes for jdata holes"

----- Original Message -----

Quoted 13 lines

Patch b2a846dbef4e ("gfs2: Ignore journal log writes for jdata holes" caused a regression. It fixed one specific problem while breaking others. The problem was that it changed the behavior of function gfs2_block_map which is used by multiple callers so it had unintended consequences for other callers.

This patch set reverts the patch and replaces it with a more targeted solution that fixes just the one case it needs to.

Bob Peterson (2):
Revert "gfs2: Ignore journal log writes for jdata holes"
gfs2: Make special version of gfs2_get_block_noalloc for jdata

Quoted 7 lines
 fs/gfs2/aops.c | 30 ++++++++++++++++++++++++++++--
 fs/gfs2/bmap.c |  8 ++------
 fs/gfs2/log.c  |  2 ++
 3 files changed, 32 insertions(+), 8 deletions(-)

--
2.26.2

NACK. Ignore this for now. Something's wrong and I'm investigating.

Regards,

Bob Peterson