Skip to content

RFC device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling.

Jonathan Cameron linux-acpi linux-iio 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest13 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13device property: Add cleanup.h based fwnode_handle_put() scope based cleanup.include/linux/property.h+2 -04 replies
2/13iio: adc: max11410: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/adc/max11410.c+7 -190 replies
3/13iio: adc: mcp3564: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/adc/mcp3564.c+7 -80 replies
4/13iio: adc: qcom-spmi-adc5: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/adc/qcom-spmi-adc5.c+2 -40 replies
5/13iio: adc: rzg2l_adc: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/adc/rzg2l_adc.c+3 -70 replies
6/13iio: adc: stm32: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/adc/stm32-adc.c+24 -380 replies
7/13iio: adc: ti-ads1015: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/adc/ti-ads1015.c+1 -30 replies
8/13iio: adc: ti-ads131e08: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/adc/ti-ads131e08.c+4 -80 replies
9/13iio: addac: ad74413r: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/addac/ad74413r.c+2 -70 replies
10/13iio: dac: ad3552: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/dac/ad3552r.c+19 -310 replies
11/13iio: dac: ad5770r: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/dac/ad5770r.c+6 -120 replies
12/13iio: dac: ltc2688: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/dac/ltc2688.c+6 -170 replies
13/13iio: temp: ltc2983: Use __free(fwnode_handle) to replace fwnode_handle_put() callsdrivers/iio/temperature/ltc2983.c+21 -490 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 00/13] device property / IIO: Use cleanup.h magic for fwnode_handle_put() handling.

From: Jonathan Cameron <[email protected]>

RFC mainly because it's untested. I have none of the relevant hardware and haven't yet emulated the firmware descriptions to test this.
I have tested the device tree only version:
https://lore.kernel.org/linux-iio/[email protected]/
which is very similar.

Failing to release the references on early exit from loops over child nodes and similar are a fairly common source of bugs. The need to explicitly release the references via fwnode_handle_put() also complicate the code.

The first patch enables

	struct fwnode_handle *child __free(fwnode_handle) = NULL;

	device_for_each_child_node(dev, child) {
		if (err)
			/*
			 * Previously needed a fwnode_handle_put() here,
			 * will now be called automatically as well leave
			 * the scope within which the cleanup is registered
			 */
			return err;
	}

/*
* fwnode_handle_put() no automatically called here - but child == NULL so
* that call is a noop
*/
}

As can be seen by the examples from IIO that follow this can save a reasonable amount of complexity and boiler plate code, often enabling additional cleanups in related code such as use of
return dev_err_probe().

Jonathan Cameron (13):
device property: Add cleanup.h based fwnode_handle_put() scope based
cleanup.
iio: adc: max11410: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: adc: mcp3564: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: adc: qcom-spmi-adc5: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: adc: rzg2l_adc: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: adc: stm32: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: adc: ti-ads1015: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: adc: ti-ads131e08: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: addac: ad74413r: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: dac: ad3552: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: dac: ad5770r: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: dac: ltc2688: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls
iio: temp: ltc2983: Use __free(fwnode_handle) to replace
fwnode_handle_put() calls

 drivers/iio/adc/max11410.c        | 26 ++++--------
 drivers/iio/adc/mcp3564.c         | 15 ++++---
 drivers/iio/adc/qcom-spmi-adc5.c  |  6 +--
 drivers/iio/adc/rzg2l_adc.c       | 10 ++---
 drivers/iio/adc/stm32-adc.c       | 62 +++++++++++----------------
 drivers/iio/adc/ti-ads1015.c      |  4 +-
 drivers/iio/adc/ti-ads131e08.c    | 12 ++----
 drivers/iio/addac/ad74413r.c      |  9 +---
 drivers/iio/dac/ad3552r.c         | 50 +++++++++-------------
 drivers/iio/dac/ad5770r.c         | 18 +++-----
 drivers/iio/dac/ltc2688.c         | 23 +++-------
 drivers/iio/temperature/ltc2983.c | 70 ++++++++++---------------------
 include/linux/property.h          |  2 +
 13 files changed, 104 insertions(+), 203 deletions(-)
Signature · 1 line
2.43.0