Refactor xe_exec_queue_create to fix user extensions
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest4 patches 0 repliesNew
- v25 patches 6 repliesSuperseded
- v14 patches 7 repliesSuperseded
Patches in v3 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | drm/xe: Refactor __xe_exec_queue_create()drivers/ | +39 | 0 replies | |
| 2/4 | drm/xe: Add exec_queue.sched_props.job_timeout_msdrivers/ drivers/ drivers/ | +5 | 0 replies | |
| 3/4 | drm/xe: Finish refactoring of exec_queue_createdrivers/ drivers/ drivers/ +2 more | +57 | 0 replies | |
| 4/4 | drm/xe: Remove set_job_timeout_ms() from exec_queue_opsdrivers/ drivers/ drivers/ | +0 | 0 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by.
| Patch | Matthew Brost |
|---|---|
| 1/4 | R-b |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v3 0/4] Refactor xe_exec_queue_create to fix user extensions
We have an issue in that exec_queue_user_extensions are applied too late. In the case of USM properties, these need to be set prior to xe_lrc_init().
Split __xe_exec_queue_create() into two functions, alloc and init. Setting of exec_queue user extensions is moved from the end of the ioctl function earlier, into __xe_exec_queue_alloc(). This fixes above issue with USM properties being set too late.
However, in order to apply user extensions this early, we can no longer call q->ops functions. Instead, make it more efficient. User extension functions can simply update the q->sched_props values and they will be applied by the backend during q->ops->init().
Note to reviewers, perhaps review patch #3 first.
v2: readability cleanup, added a patch to remove now unused
exec_queue_ops.set_job_timeout_ms()
v3: rebased, sched_props.priority fixes and changes are already
merged
Brian Welty (4):
drm/xe: Refactor __xe_exec_queue_create() drm/xe: Add exec_queue.sched_props.job_timeout_ms drm/xe: Finish refactoring of exec_queue_create drm/xe: Remove set_job_timeout_ms() from exec_queue_ops
drivers/gpu/drm/xe/xe_exec_queue.c | 128 ++++++++++++++++------- drivers/gpu/drm/xe/xe_exec_queue.h | 3 +- drivers/gpu/drm/xe/xe_exec_queue_types.h | 4 +- drivers/gpu/drm/xe/xe_execlist.c | 8 -- drivers/gpu/drm/xe/xe_gsc.c | 2 +- drivers/gpu/drm/xe/xe_gt.c | 4 +- drivers/gpu/drm/xe/xe_guc_submit.c | 18 +--- drivers/gpu/drm/xe/xe_migrate.c | 2 +- 8 files changed, 98 insertions(+), 71 deletions(-)
Signature · 1 line
2.43.0