Open block devices as files
Get series with b4
b4 am [email protected] change-id 20240103-vfs-bdev-file-1208da73d7eaVersions newest first
- v2 Latest34 patches 93 repliesIn review
- v1 RFC34 patches 17 repliesSuperseded
Changes in v2 from the cover letter
- This is not an RFC anymore.
- The patches to convert all of fs/buffer.c and associated helpers to
struct file have been split out of the core infrastructure.
- Various renaming of helpers in response to v1.
- Link to v1: https://lore.kernel.org/r/[email protected]
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/34 | bdev: open block device as filesblock/ fs/ fs/ +8 more | +160 | 18 replies | |
| 2/34 | block/ioctl: port blkdev_bszset() to fileblock/ | +4 | 2 replies | |
| 3/34 | block/genhd: port disk_scan_partitions() to fileblock/ | +6 | 2 replies | |
| 4/34 | md: port block device access to filedrivers/ drivers/ drivers/ +1 more | +21 | 11 replies | |
| 5/34 | swap: port block device usage to fileinclude/ mm/ | +12 | 2 replies | |
| 6/34 | power: port block device access to filekernel/ | +14 | 2 replies | |
| 7/34 | xfs: port block device access to filesfs/ fs/ fs/ | +28 | 3 replies | |
| 8/34 | drbd: port block device access to filedrivers/ drivers/ | +31 | 1 reply | |
| 9/34 | pktcdvd: port block device access to filedrivers/ include/ | +36 | 1 reply | |
| 10/34 | rnbd: port block device access to filedrivers/ drivers/ | +15 | 1 reply | |
| 11/34 | xen: port block device access to filedrivers/ drivers/ drivers/ | +22 | 1 reply | |
| 12/34 | zram: port block device access to filedrivers/ drivers/ | +14 | 1 reply | |
| 13/34 | bcache: port block device access to filesdrivers/ drivers/ | +39 | 1 reply | |
| 14/34 | block2mtd: port device access to filesdrivers/ | +21 | 1 reply | |
| 15/34 | nvme: port block device access to filedrivers/ drivers/ | +9 | 1 reply | |
| 16/34 | s390: port block device access to filedrivers/ drivers/ drivers/ +1 more | +25 | 1 reply | |
| 17/34 | target: port block device access to filedrivers/ drivers/ drivers/ +1 more | +22 | 1 reply | |
| 18/34 | bcachefs: port block device access to filefs/ fs/ | +11 | 1 reply | |
| 19/34 | btrfs: port device access to filefs/ fs/ fs/ +1 more | +63 | 1 reply | |
| 20/34 | erofs: port device access to filefs/ fs/ fs/ | +12 | 1 reply | |
| 21/34 | ext4: port block device access to filefs/ fs/ fs/ | +31 | 1 reply | |
| 22/34 | f2fs: port block device access to filesfs/ fs/ | +7 | 1 reply | |
| 23/34 | jfs: port block device access to filefs/ fs/ fs/ | +15 | 1 reply | |
| 24/34 | nfs: port block device access to filesfs/ fs/ | +35 | 1 reply | |
| 25/34 | ocfs2: port block device access to filefs/ | +16 | 1 reply | |
| 26/34 | reiserfs: port block device access to filefs/ fs/ fs/ | +24 | 1 reply | |
| 27/34 | bdev: remove bdev_open_by_path()block/ include/ | +0 | 2 replies | |
| 28/34 | bdev: make bdev_release() private to block layerblock/ block/ include/ | +4 | 3 replies | |
| 29/34 | bdev: make struct bdev_handle private to the block layerblock/ block/ block/ +2 more | +92 | 7 replies | |
| 30/34 | bdev: remove bdev pointer from struct bdev_handleblock/ block/ block/ | +14 | 2 replies | |
| 31/34 | block: use file->f_op to indicate restricted writesblock/ block/ block/ | +17 | 9 replies | |
| 32/34 | block: remove bdev_handle completelyblock/ block/ block/ | +18 | 3 replies | |
| 33/34 | block: expose bdev_file_inode()block/ block/ include/ | +6 | 1 reply | |
| 34/34 | ext4: rely on sb->f_bdev onlyfs/ fs/ fs/ +1 more | +22 | 2 replies |
Reviews trailers per patch
31 of 34 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Christoph Hellwig | Jan Kara | Yi Zhang |
|---|---|---|---|
| Series | R-b | ||
| 1/34 | R-b | R-b | T-b |
| 2/34 | R-b | R-b | |
| 3/34 | R-b | R-b | |
| 4/34 | R-b | R-b | |
| 5/34 | R-b | R-b | |
| 6/34 | R-b | R-b | |
| 7/34 | R-b | R-b | |
| 8/34 | R-b | ||
| 9/34 | R-b | ||
| 10/34 | R-b | ||
| 11/34 | R-b | ||
| 12/34 | R-b | ||
| 13/34 | R-b | ||
| 14/34 | R-b | ||
| 15/34 | R-b | ||
| 16/34 | R-b | ||
| 17/34 | R-b | ||
| 18/34 | R-b | ||
| 19/34 | R-b | ||
| 20/34 | R-b | ||
| 21/34 | R-b | ||
| 22/34 | R-b | ||
| 23/34 | R-b | ||
| 24/34 | R-b | ||
| 25/34 | R-b | ||
| 26/34 | R-b | ||
| 27/34 | R-b | R-b | |
| 28/34 | R-b | R-b | |
| 29/34 | R-b | ||
| 30/34 | R-b | R-b | |
| 31/34 | |||
| 32/34 | R-b | ||
| 33/34 | |||
| 34/34 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/34] Open block devices as files
Hey Christoph,
Hey Jan,
Hey Jens,
This opens block devices as files. Instead of introducing a separate indirection into bdev_open_by_*() vis struct bdev_handle we can just make bdev_file_open_by_*() return a struct file. Opening and closing a block device from setup_bdev_super() and in all other places just becomes equivalent to opening and closing a file.
This has held up in xfstests and in blktests so far and it seems stable and clean. The equivalence of opening and closing block devices to regular files is a win in and of itself imho. Added to that is the ability to do away with struct bdev_handle completely and make various low-level helpers private to the block layer.
All places were we currently stash a struct bdev_handle we just stash a file and use an accessor such as file_bdev() akin to I_BDEV() to get to the block device.
It's now also possible to use file->f_mapping as a replacement for bdev->bd_inode->i_mapping and file->f_inode or file->f_mapping->host as an alternative to bdev->bd_inode allowing us to significantly reduce or even fully remove bdev->bd_inode in follow-up patches.
In addition, we could get rid of sb->s_bdev and various other places that stash the block device directly and instead stash the block device file. Again, this is follow-up work.
Thanks!
Christian
---
Changes in v2:
- This is not an RFC anymore.
- The patches to convert all of fs/buffer.c and associated helpers to
struct file have been split out of the core infrastructure.
- Various renaming of helpers in response to v1.
- Link to v1: https://lore.kernel.org/r/[email protected]
---
Christian Brauner (34):
bdev: open block device as files
block/ioctl: port blkdev_bszset() to file block/genhd: port disk_scan_partitions() to file
md: port block device access to file
swap: port block device usage to file
power: port block device access to file
xfs: port block device access to files
drbd: port block device access to file
pktcdvd: port block device access to file
rnbd: port block device access to file
xen: port block device access to file
zram: port block device access to file
bcache: port block device access to files
block2mtd: port device access to files
nvme: port block device access to file
s390: port block device access to file
target: port block device access to file
bcachefs: port block device access to file
btrfs: port device access to file
erofs: port device access to file
ext4: port block device access to file
f2fs: port block device access to files
jfs: port block device access to file
nfs: port block device access to files
ocfs2: port block device access to file
reiserfs: port block device access to file
bdev: remove bdev_open_by_path()
bdev: make bdev_release() private to block layer
bdev: make struct bdev_handle private to the block layer
bdev: remove bdev pointer from struct bdev_handle
block: use file->f_op to indicate restricted writes
block: remove bdev_handle completely
block: expose bdev_file_inode()
ext4: rely on sb->f_bdev only
block/bdev.c | 249 ++++++++++++++++++++++-------------- block/blk.h | 6 + block/fops.c | 48 ++++--- block/genhd.c | 12 +- block/ioctl.c | 9 +- drivers/block/drbd/drbd_int.h | 4 +- drivers/block/drbd/drbd_nl.c | 58 ++++----- drivers/block/pktcdvd.c | 68 +++++----- drivers/block/rnbd/rnbd-srv.c | 28 ++-- drivers/block/rnbd/rnbd-srv.h | 2 +- drivers/block/xen-blkback/blkback.c | 4 +- drivers/block/xen-blkback/common.h | 4 +- drivers/block/xen-blkback/xenbus.c | 37 +++--- drivers/block/zram/zram_drv.c | 26 ++-- drivers/block/zram/zram_drv.h | 2 +- drivers/md/bcache/bcache.h | 4 +- drivers/md/bcache/super.c | 74 +++++------ drivers/md/dm.c | 23 ++-- drivers/md/md.c | 12 +- drivers/md/md.h | 2 +- drivers/mtd/devices/block2mtd.c | 46 +++---- drivers/nvme/target/io-cmd-bdev.c | 16 +-- drivers/nvme/target/nvmet.h | 2 +- drivers/s390/block/dasd.c | 10 +- drivers/s390/block/dasd_genhd.c | 36 +++--- drivers/s390/block/dasd_int.h | 2 +- drivers/s390/block/dasd_ioctl.c | 2 +- drivers/target/target_core_iblock.c | 18 +-- drivers/target/target_core_iblock.h | 2 +- drivers/target/target_core_pscsi.c | 22 ++-- drivers/target/target_core_pscsi.h | 2 +- fs/bcachefs/super-io.c | 20 +-- fs/bcachefs/super_types.h | 2 +- fs/btrfs/dev-replace.c | 14 +- fs/btrfs/ioctl.c | 16 +-- fs/btrfs/volumes.c | 92 ++++++------- fs/btrfs/volumes.h | 4 +- fs/cramfs/inode.c | 2 +- fs/erofs/data.c | 6 +- fs/erofs/internal.h | 2 +- fs/erofs/super.c | 16 +-- fs/ext4/dir.c | 2 +- fs/ext4/ext4.h | 2 +- fs/ext4/ext4_jbd2.c | 2 +- fs/ext4/fast_commit.c | 2 +- fs/ext4/fsmap.c | 8 +- fs/ext4/super.c | 87 ++++++------- fs/f2fs/f2fs.h | 2 +- fs/f2fs/super.c | 12 +- fs/file_table.c | 36 +++++- fs/jfs/jfs_logmgr.c | 26 ++-- fs/jfs/jfs_logmgr.h | 2 +- fs/jfs/jfs_mount.c | 2 +- fs/nfs/blocklayout/blocklayout.h | 2 +- fs/nfs/blocklayout/dev.c | 68 +++++----- fs/ocfs2/cluster/heartbeat.c | 32 ++--- fs/reiserfs/journal.c | 38 +++--- fs/reiserfs/procfs.c | 2 +- fs/reiserfs/reiserfs.h | 8 +- fs/romfs/super.c | 2 +- fs/super.c | 18 +-- fs/xfs/xfs_buf.c | 10 +- fs/xfs/xfs_buf.h | 4 +- fs/xfs/xfs_super.c | 43 +++---- include/linux/blkdev.h | 18 +-- include/linux/device-mapper.h | 2 +- include/linux/file.h | 2 + include/linux/fs.h | 4 +- include/linux/pktcdvd.h | 4 +- include/linux/swap.h | 2 +- kernel/power/swap.c | 28 ++-- mm/swapfile.c | 22 ++-- 72 files changed, 791 insertions(+), 705 deletions(-)
---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240103-vfs-bdev-file-1208da73d7ea