Skip to content

Fix PIC interrupt handling of x86 CPUs if APIC is globally disabled

Bernhard Beschow qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 2 repliesIn review
  2. v12 patches 3 repliesSuperseded

Changes in v2 from the cover letter

* Pick up R-b tag
* Split and rework interrupt handling patch to consider i486 SMP systems. This required dropping Alex' R-b tag.

[1] https://github.com/shentok/qemu/tree/via-apollo-pro-133t

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/i386/x86: Reverse if statementhw/i386/x86.c+3 -30 replies
2/3hw/i386/x86: Fix PIC interrupt handling if APIC is globally disabledhw/i386/x86.c hw/intc/apic_common.c include/hw/i386/apic.h+16 -20 replies
3/3target/i386/cpu: Fix typo in commenttarget/i386/cpu.c+1 -10 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchAlex Bennée
1/3
2/3
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Fix PIC interrupt handling of x86 CPUs if APIC is globally disabled

This series is part of my work emulating the VIA Apollo Pro 133T chipset in QEMU
[1] and testing it by running real-world BIOSes on it. The first two patches fix an issue regarding PIC interrupt handling, the third one just fixes a typo in a comment.

During testing, I've found that the boot process gets stuck for some BIOSes that disable the LAPIC globally (by disabling the enable bit in the base address register). QEMU seems to emulate PIC interrupt handling only if a CPU doesn't have a LAPIC, and always emulates LAPIC interrupt handling if one is present. According to the Intel documentation, a CPU should resort to PIC interrupt handling if its LAPIC is globally didabled. This series fixes this corner case which makes the boot process succeed. More details can be found in the commit message.

Testing done:
* make check
* make check-avocado

v2:
* Pick up R-b tag
* Split and rework interrupt handling patch to consider i486 SMP systems. This required dropping Alex' R-b tag.

[1] https://github.com/shentok/qemu/tree/via-apollo-pro-133t

Bernhard Beschow (3):
hw/i386/x86: Reverse if statement
hw/i386/x86: Fix PIC interrupt handling if APIC is globally disabled target/i386/cpu: Fix typo in comment

 include/hw/i386/apic.h |  1 +
 hw/i386/x86.c          |  8 ++++----
 hw/intc/apic_common.c  | 13 +++++++++++++
 target/i386/cpu.c      |  2 +-
 4 files changed, 19 insertions(+), 5 deletions(-)
Signature · 1 line
2.43.0