Skip to content

hyperv, sysfb: Do not use screen_info in drivers

Thomas Zimmermann dri-devel linux-fbdev linux-hyperv 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/hyperv: Remove firmware framebuffers with aperture helperdrivers/gpu/drm/hyperv/hyperv_drm_drv.c+2 -62 replies
2/4fbdev/hyperv_fb: Remove firmware framebuffers with aperture helpersdrivers/video/fbdev/hyperv_fb.c+6 -51 reply
3/4firmware/sysfb: Clear screen_info state after consuming itdrivers/firmware/sysfb.c+13 -11 reply
4/4fbdev/hyperv_fb: Do not clear global screen_infodrivers/video/fbdev/hyperv_fb.c+1 -81 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchJavier Martinez Canillas
1/4R-b
2/4R-b
3/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] hyperv, sysfb: Do not use screen_info in drivers

The global screen_info state is only meant for architecture and firmware code. Replace its use in hyperv graphics drivers with the correct aperture helpers.

Patches 1 and 2 update hyperv-drm and hyperv-fb to use the correct aperture helpers instead of screen_info for removing existing firmware framebuffers.

Hyperv-fb also modifies screen_info for better use with kexec. While that update makes sense, it's not supposed to be done by the driver. Patch 3 adds similar code to sysfb and patch 4 removes the code from the driver.

An intented side effect of this patchset is that all systems now benefit from better kexec support. After rebooting with kexec, the kernel operated on stale settings on screen_info. Patch 3 fixes this and the kexec kernel will use screen_info in any meaningful way.

Thomas Zimmermann (4):
drm/hyperv: Remove firmware framebuffers with aperture helper fbdev/hyperv_fb: Remove firmware framebuffers with aperture helpers firmware/sysfb: Clear screen_info state after consuming it fbdev/hyperv_fb: Do not clear global screen_info

 drivers/firmware/sysfb.c                | 14 +++++++++++++-
 drivers/gpu/drm/hyperv/hyperv_drm_drv.c |  8 ++------
 drivers/video/fbdev/hyperv_fb.c         | 20 +++++++-------------
 3 files changed, 22 insertions(+), 20 deletions(-)

base-commit: 25232eb8a9ac7fa0dac7e846a4bf7fba2b6db39a

Signature · 1 line
2.43.0