Skip to content

drm/i915: Fix HPD handling during driver init/shutdown

Imre Deak intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 23 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12drm/i915: Init DRM connector polled field earlydrivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dvo.c +3 more+7 -02 replies
2/12drm/i915: Keep the connector polled state disabled after stormdrivers/gpu/drm/i915/display/intel_hotplug.c+7 -04 replies
3/12drm/i915: Move audio deinit after disabling pollingdrivers/gpu/drm/i915/display/intel_display_driver.c+3 -21 reply
4/12drm/i915: Disable intel HPD poll after DRM poll init/enabledrivers/gpu/drm/i915/display/intel_display_driver.c drivers/gpu/drm/i915/i915_driver.c+2 -21 reply
5/12drm/i915: Suspend the framebuffer console during driver shutdowndrivers/gpu/drm/i915/i915_driver.c+1 -01 reply
6/12drm/i915: Suspend the framebuffer console earlier during system suspenddrivers/gpu/drm/i915/i915_driver.c+1 -21 reply
7/12drm/i915: Prevent modesets during driver init/shutdowndrivers/gpu/drm/i915/display/intel_display.c drivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/display/intel_display_driver.c +2 more+104 -25 replies
8/12drm/i915: Disable hotplug detection works during driver init/shutdowndrivers/gpu/drm/i915/display/intel_display_core.h drivers/gpu/drm/i915/display/intel_display_driver.c drivers/gpu/drm/i915/display/intel_dp.c +2 more+154 -201 reply
9/12drm/i915: Disable hotplug detection handlers during driver init/shutdowndrivers/gpu/drm/i915/display/intel_crt.c drivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_dp_mst.c +5 more+39 -01 reply
10/12drm/i915: Add intel_digital_port lock/unlock hooksdrivers/gpu/drm/i915/display/intel_ddi.c drivers/gpu/drm/i915/display/intel_display_types.h drivers/gpu/drm/i915/display/intel_dp.c +4 more+56 -311 reply
11/12drm/i915: Filter out glitches on HPD lines during hotplug detectiondrivers/gpu/drm/i915/display/intel_dp.c drivers/gpu/drm/i915/display/intel_tc.c drivers/gpu/drm/i915/display/intel_tc.h+21 -21 reply
12/12drm/i915/dp: Abort AUX on disconnected native DP portsdrivers/gpu/drm/i915/display/intel_dp_aux.c+1 -41 reply

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchJouni Högander
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] drm/i915: Fix HPD handling during driver init/shutdown

Fix the handling of display connector hotplug handling during the driver init/shutdown sequences. A hotplug event can result in a connector detection/modeset running in parallel with the HW programming of the init/shutdown sequence, or when the display IRQs are disabled already.

Also fix incorrectly detecting a disconnected state due to glitches on the HPD line and prevent long timeout/retry delays during DP AUX transfers on all DP connectors.

Imre Deak (12):
drm/i915: Init DRM connector polled field early
drm/i915: Keep the connector polled state disabled after storm drm/i915: Move audio deinit after disabling polling drm/i915: Disable intel HPD poll after DRM poll init/enable drm/i915: Suspend the framebuffer console during driver shutdown drm/i915: Suspend the framebuffer console earlier during system
suspend
drm/i915: Prevent modesets during driver init/shutdown drm/i915: Disable hotplug detection works during driver init/shutdown drm/i915: Disable hotplug detection handlers during driver
init/shutdown
drm/i915: Add intel_digital_port lock/unlock hooks drm/i915: Filter out glitches on HPD lines during hotplug detection drm/i915/dp: Abort AUX on disconnected native DP ports

 drivers/gpu/drm/i915/display/intel_crt.c      |   5 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   3 +
 drivers/gpu/drm/i915/display/intel_display.c  |   3 +
 .../gpu/drm/i915/display/intel_display_core.h |  13 ++
 .../drm/i915/display/intel_display_driver.c   |  85 ++++++++-
 .../drm/i915/display/intel_display_driver.h   |   6 +
 .../drm/i915/display/intel_display_types.h    |   3 +
 drivers/gpu/drm/i915/display/intel_dp.c       |  58 +++++-
 drivers/gpu/drm/i915/display/intel_dp.h       |   3 +
 drivers/gpu/drm/i915/display/intel_dp_aux.c   |  29 ++-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   4 +
 drivers/gpu/drm/i915/display/intel_dvo.c      |   5 +
 drivers/gpu/drm/i915/display/intel_hdmi.c     |   8 +
 drivers/gpu/drm/i915/display/intel_hotplug.c  | 165 ++++++++++++++++--
 drivers/gpu/drm/i915/display/intel_hotplug.h  |   4 +
 drivers/gpu/drm/i915/display/intel_panel.c    |   4 +
 drivers/gpu/drm/i915/display/intel_sdvo.c     |   6 +
 drivers/gpu/drm/i915/display/intel_tc.c       |  24 ++-
 drivers/gpu/drm/i915/display/intel_tc.h       |   2 +-
 drivers/gpu/drm/i915/display/intel_tv.c       |   5 +
 drivers/gpu/drm/i915/i915_driver.c            |  22 ++-
 21 files changed, 394 insertions(+), 63 deletions(-)
Signature · 1 line
2.39.2