Skip to content

pds_core: Various improvements and AQ race condition cleanup

Brett Creeley lkml netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 4 repliesIn review
  2. v18 patches 3 repliesSuperseded

Changes in v2 from the cover letter

- Combined the RCT clean-ups with an incorrect goto label fix
- Added a couple more patches related to reset flows
- Slightly updated the cover letter to mention the extra patches that were added
- Changed a function used only once to be static

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10pds_core: Prevent health thread from running during reset/removedrivers/net/ethernet/amd/pds_core/main.c+17 -20 replies
2/10pds_core: Cancel AQ work on teardowndrivers/net/ethernet/amd/pds_core/core.c+2 -00 replies
3/10pds_core: Use struct pdsc for the pdsc_adminq_isr private datadrivers/net/ethernet/amd/pds_core/adminq.c drivers/net/ethernet/amd/pds_core/core.c+4 -30 replies
4/10pds_core: Prevent race issues involving the adminqdrivers/net/ethernet/amd/pds_core/adminq.c drivers/net/ethernet/amd/pds_core/core.c drivers/net/ethernet/amd/pds_core/core.h+47 -60 replies
5/10pds_core: Clear BARs on resetdrivers/net/ethernet/amd/pds_core/adminq.c drivers/net/ethernet/amd/pds_core/core.c drivers/net/ethernet/amd/pds_core/dev.c +3 more+45 -110 replies
6/10pds_core: Don't assign interrupt index/bound_intr to notifyqdrivers/net/ethernet/amd/pds_core/core.c drivers/net/ethernet/amd/pds_core/debugfs.c+3 -50 replies
7/10pds_core: Unmask adminq interrupt in work threaddrivers/net/ethernet/amd/pds_core/adminq.c+3 -70 replies
8/10pds_core: Fix up some minor issuesdrivers/net/ethernet/amd/pds_core/debugfs.c drivers/net/ethernet/amd/pds_core/dev.c+4 -70 replies
9/10pds_core: Rework teardown/setup flow to be more commondrivers/net/ethernet/amd/pds_core/core.c drivers/net/ethernet/amd/pds_core/core.h drivers/net/ethernet/amd/pds_core/debugfs.c +2 more+9 -180 replies
10/10pds_core: Clean up init/uninit flows to be more readabledrivers/net/ethernet/amd/pds_core/core.c drivers/net/ethernet/amd/pds_core/core.h drivers/net/ethernet/amd/pds_core/dev.c+61 -430 replies

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchShannon NelsonPrzemek Kitszel
1/10R-b R-b
2/10R-b R-b
3/10R-b R-b
4/10R-b R-b
5/10R-b R-b
6/10R-b R-b
7/10R-b R-b
8/10R-b
9/10R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net-next 0/10] pds_core: Various improvements and AQ race condition cleanup

This series includes the following changes:

There can be many users of the pds_core's adminq. This includes pds_core's uses and any clients that depend on it. When the pds_core device goes through a reset for any reason the adminq is freed and reconfigured. There are some gaps in the current implementation that will cause crashes during reset if any of the previously mentioned users of the adminq attempt to use it after it's been freed.

Issues around how resets are handled, specifically regarding the driver's error handlers.

Some general cleanups.

v1:
https://lore.kernel.org/netdev/[email protected]/

v2:
- Combined the RCT clean-ups with an incorrect goto label fix
- Added a couple more patches related to reset flows
- Slightly updated the cover letter to mention the extra patches that were added
- Changed a function used only once to be static

Brett Creeley (10):
pds_core: Prevent health thread from running during reset/remove
pds_core: Cancel AQ work on teardown
pds_core: Use struct pdsc for the pdsc_adminq_isr private data
pds_core: Prevent race issues involving the adminq
pds_core: Clear BARs on reset
pds_core: Don't assign interrupt index/bound_intr to notifyq
pds_core: Unmask adminq interrupt in work thread
pds_core: Fix up some minor issues
pds_core: Rework teardown/setup flow to be more common
pds_core: Clean up init/uninit flows to be more readable

 drivers/net/ethernet/amd/pds_core/adminq.c  |  74 +++++++----
 drivers/net/ethernet/amd/pds_core/core.c    | 130 ++++++++++++--------
 drivers/net/ethernet/amd/pds_core/core.h    |   3 +-
 drivers/net/ethernet/amd/pds_core/debugfs.c |  12 +-
 drivers/net/ethernet/amd/pds_core/dev.c     |  30 +++--
 drivers/net/ethernet/amd/pds_core/devlink.c |   3 +-
 drivers/net/ethernet/amd/pds_core/fw.c      |   3 +
 drivers/net/ethernet/amd/pds_core/main.c    |  26 +++-
 8 files changed, 187 insertions(+), 94 deletions(-)
Signature · 1 line
2.17.1