Skip to content

target/hppa qemu v8.2 regression fixes

[email protected] qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 15 repliesIn review
  2. v29 patches 16 repliesSuperseded
  3. v19 patches 8 repliesSuperseded

Changes in v3 from the cover letter

- Added comment about Figures H-10 and H-11 in the parisc2.0 spec in patch which calculate PDC address translation if PSW.W=0
- Introduce and use hppa_set_ior_and_isr()
- Use drive_get_max_bus(IF_SCSI), nd_table[] and serial_hd() to check if default devices should be created
- Added Tested-by and Reviewed-by tags

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9hw/hppa/machine: Allow up to 3840 MB total memoryhw/hppa/machine.c+6 -30 replies
2/9hw/hppa/machine: Disable default devices with --nodefaults optionhw/hppa/machine.c+6 -44 replies
3/9hw/pci-host/astro: Add missing astro & elroy registers for NetBSDhw/pci-host/astro.c+23 -30 replies
4/9target/hppa: Fix PDC address translation on PA2.0 with PSW.W=0target/hppa/mem_helper.c+1 -13 replies
5/9hw/hppa: Move software power button address back into PDChw/hppa/machine.c+5 -45 replies
6/9target/hppa: Avoid accessing %gr0 when raising exceptiontarget/hppa/mem_helper.c+1 -10 replies
7/9target/hppa: Export function hppa_set_ior_and_isr()target/hppa/cpu.h target/hppa/mem_helper.c+13 -111 reply
8/9target/hppa: Fix IOR and ISR on unaligned access traptarget/hppa/cpu.c+1 -51 reply
9/9target/hppa: Fix IOR and ISR on error in probetarget/hppa/op_helper.c+1 -51 reply

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchBruno HaibleRichard HendersonNelson H. F. Beebe
1/9T-b R-b Noticed-by
2/9R-b
3/9T-b
4/9T-b T-b R-b
5/9T-b T-b R-b
6/9T-b R-b
7/9R-b
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/9] target/hppa qemu v8.2 regression fixes

From: Helge Deller <[email protected]>

There were some regressions introduced with Qemu v8.2 on the hppa/hppa64 target, e.g.:

- 32-bit HP-UX crashes on B160L (32-bit) machine
- NetBSD boot failure due to power button in page zero
- NetBSD FPU detection failure
- OpenBSD 7.4 boot failure

This patch series fixes those known regressions and additionally:

- allows usage of the max. 3840MB of memory (instead of 3GB),
- adds support for the qemu --nodefaults option (to debug other devices)

This patch set will not fix those known (non-regression) bugs:
- HP-UX and NetBSD still fail to boot on the new 64-bit C3700 machine
- Linux kernel will still fail to boot on C3700 as long as kernel modules are used.

The whole series can be pulled from the "hppa-fixes-8.2" branch from:
https://github.com/hdeller/qemu-hppa.git hppa-fixes-8.2

SeaBIOS v15 has not changed in v3, so it is not included in this patch review series but will be added in final pull request.

Please review.

Changes v2->v3:
- Added comment about Figures H-10 and H-11 in the parisc2.0 spec in patch which calculate PDC address translation if PSW.W=0
- Introduce and use hppa_set_ior_and_isr()
- Use drive_get_max_bus(IF_SCSI), nd_table[] and serial_hd() to check if default devices should be created
- Added Tested-by and Reviewed-by tags

Changes v1->v2:
- fix OpenBSD boot with SeaBIOS v15 instead of v14
- commit message enhancements suggested by BALATON Zoltan
- use uint64_t for ram_max in patch #1

Helge Deller (9):
hw/hppa/machine: Allow up to 3840 MB total memory hw/hppa/machine: Disable default devices with --nodefaults option hw/pci-host/astro: Add missing astro & elroy registers for NetBSD target/hppa: Fix PDC address translation on PA2.0 with PSW.W=0 hw/hppa: Move software power button address back into PDC target/hppa: Avoid accessing %gr0 when raising exception target/hppa: Export function hppa_set_ior_and_isr() target/hppa: Fix IOR and ISR on unaligned access trap target/hppa: Fix IOR and ISR on error in probe

 hw/hppa/machine.c        | 28 +++++++++++++++++-----------
 hw/pci-host/astro.c      | 26 +++++++++++++++++++++++---
 target/hppa/cpu.c        |  6 +-----
 target/hppa/cpu.h        |  1 +
 target/hppa/mem_helper.c | 27 ++++++++++++++-------------
 target/hppa/op_helper.c  |  6 +-----
 6 files changed, 57 insertions(+), 37 deletions(-)
Signature · 1 line
2.43.0