Skip to content

virtio-net: Clarify virtio_net_hdr size and rx buffer size

Parav Pandit virtio-comment 6 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest3 patches 0 repliesNew
  2. v53 patches 3 repliesSuperseded
  3. v42 patches 0 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v32 patches0 repliesSuperseded
v22 patches17 repliesSuperseded
v12 patches3 repliesSuperseded

Changes in v6 from the cover letter

- addressed comments from Michael and Xuan to change 'must' to 'MUST' v4->v5:
- added vnet hdr structure annotation patch

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3virtio-net: Fix receive buffer size calculation textdevice-types/net/description.tex+19 -70 replies
2/3virtio-net: Clarify the size of the struct virtio_net_hdr for txdevice-types/net/description.tex+3 -00 replies
3/3virtio-net: Annotate virtio_net_hdr as fielddevice-types/net/description.tex+4 -40 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchXuan Zhuo
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v6 thread

Cover letter [PATCH v6 0/3] virtio-net: Clarify virtio_net_hdr size and rx buffer size

There are few small issues around size of receive buffer and size of the struct virtio_net_hdr as following.

1. VIRTIO_NET_F_HASH_REPORT is only applicable on the rx side processing. However it changes the size of the struct virtio_net_hdr for the tx side as well. This was not clarified when VIRTIO_NET_F_HASH_REPORT feature was introduced.

2. Receive buffer size calculation description and requirements did not reflect negotiation of VIRTIO_NET_F_HASH_REPORT.

3. Receive buffer size calculation was incorrect for ipv6 guest gso feature.

Above issue 2 was reported in [1].
Since issue 2 and 3 both touches the same set of requirements and description, they are updated under a new issue along with tx side fix as well touching the clarification needed for VIRTIO_NET_F_HASH_REPORT.

Hence above three issues are fixed under issue of [2].

Patch summary:
patch-1 fixes receive side description and requirement patch-2 adds transmit side clarification for VIRTIO_NET_F_HASH_REPORT patch-3 to fix virtio_net_hdr annotation

changelog:
v5->v6:
- addressed comments from Michael and Xuan to change 'must' to 'MUST' v4->v5:
- added vnet hdr structure annotation patch
v3->v4:
- addressed comments from Cornelia
- rephrase for virtio_net_hdr size calculation
v2->v3:
- addressed comments from Cornelia and Xuan
- added virtio_net_hdr inclusion description in buffer size calculation text
- rephrase tx to refer to the rx side virtio_net_hdr consideration
- addressed comments from Xuan
- replaced 'field' with 'structure'
v1->v2:
- addressed comments from Cornelia
- rephrase buffer size wording without explicit length of virtio_net_hdr at 3 places.
- replaced otherwise to ', otherwise'
- rephrase non normative to write as driver normative
v0->v1:
- addressed comments from Xuan to rewrite tx normative

Parav Pandit (3):
virtio-net: Fix receive buffer size calculation text
virtio-net: Clarify the size of the struct virtio_net_hdr for tx
virtio-net: Annotate virtio_net_hdr as field

 device-types/net/description.tex | 37 ++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 11 deletions(-)
Signature · 1 line
2.34.1