Skip to content

sparc/leon3: Add support for -smp

Clément Chigot qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest9 patches 4 repliesIn review
  2. v28 patches 11 repliesSuperseded
  3. v19 patches 12 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9sparc/grlib: split out the headers for each peripheralshw/char/grlib_apbuart.c hw/intc/grlib_irqmp.c hw/sparc/leon3.c +4 more+88 -180 replies
2/9intc/grlib_irqmp: add ncpus propertyhw/intc/grlib_irqmp.c hw/sparc/leon3.c+22 -100 replies
3/9intc/grlib_irqmp: implements the multiprocessor status registerhw/intc/grlib_irqmp.c+32 -30 replies
4/9intc/grlib_irqmp: implements multicore irqhw/intc/grlib_irqmp.c hw/sparc/leon3.c include/hw/intc/grlib_irqmp.h+23 -230 replies
5/9target/sparc: implement asr17 feature for smptarget/sparc/helper.c target/sparc/helper.h target/sparc/translate.c+20 -100 replies
6/9leon3: remove SP initializationhw/sparc/leon3.c+0 -31 reply
7/9leon3: implement multiprocessorhw/sparc/leon3.c+70 -280 replies
8/9leon3: check cpu_id in the tiny bootloaderhw/sparc/leon3.c+20 -20 replies
9/9MAINTAINERS: replace Fabien by myself as Leon3 maintainerMAINTAINERS+1 -10 replies

Reviews trailers per patch

8 of 9 patches have a Reviewed-by or Acked-by.

PatchFabien ChouteauPhilippe Mathieu-DaudéRichard Henderson
1/9R-b
2/9R-b
3/9R-b
4/9R-b
5/9R-b R-b
6/9R-b
7/9
8/9R-b
9/9R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/9] sparc/leon3: Add support for -smp

V3 modifications
- Patch 3: Fix indentation
- Patch 4: Fix types and improves variable declarations
- Patch 6 (NEW): Remove SP initialization in leon3
- Patch 7: Add assert in leon3_start_cpu
- Patch 8: Improve comment

---

V2 modifications
- Patch1: Add SPDX copyright tags.
- Patch3: Add defines for MP_STATUS fields. Improve comments.
- Patch4: Improve a comment.
- Patch6: Dropped as already merged.

---

This series allows leon3 emulations to record up 4 CPUs.

It requires some enhancements in the grlib_irqmp device and adding the cpu_index field in the asr17 instruction.

It has been tested locally with various bareboard runtimes.

CC Frederic Konrad <[email protected]> (maintainer:Leon3)
CC Mark Cave-Ayland <[email protected]> (maintainer:SPARC TCG CPUs)
CC Artyom Tarasenko <[email protected]> (maintainer:SPARC TCG CPUs)
CC Philippe Mathieu-Daudé <[email protected]>

Clément Chigot (9):
sparc/grlib: split out the headers for each peripherals intc/grlib_irqmp: add ncpus property intc/grlib_irqmp: implements the multiprocessor status register intc/grlib_irqmp: implements multicore irq target/sparc: implement asr17 feature for smp
leon3: remove SP initialization
leon3: implement multiprocessor
leon3: check cpu_id in the tiny bootloader
MAINTAINERS: replace Fabien by myself as Leon3 maintainer

 MAINTAINERS                                   |   2 +-
 hw/char/grlib_apbuart.c                       |   6 +-
 hw/intc/grlib_irqmp.c                         | 110 ++++++++++-----
 hw/sparc/leon3.c                              | 130 +++++++++++++-----
 hw/timer/grlib_gptimer.c                      |   6 +-
 include/hw/char/grlib_uart.h                  |  32 +++++
 .../hw/{sparc/grlib.h => intc/grlib_irqmp.h}  |  18 +--
 include/hw/timer/grlib_gptimer.h              |  32 +++++
 target/sparc/helper.c                         |  16 +++
 target/sparc/helper.h                         |   1 +
 target/sparc/translate.c                      |  13 +-
 11 files changed, 272 insertions(+), 94 deletions(-)
 create mode 100644 include/hw/char/grlib_uart.h
 rename include/hw/{sparc/grlib.h => intc/grlib_irqmp.h} (83%)
 create mode 100644 include/hw/timer/grlib_gptimer.h
Signature · 1 line
2.25.1