Skip to content

hw/pflash: implement update buffer for block writes

Gerd Hoffmann qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- add patch to use ldn_{be,le}_p and stn_{be,le}_p
- add/update tracing

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3hw/pflash: refactor pflash_data_write()hw/block/pflash_cfi01.c+16 -140 replies
2/3hw/pflash: use ldn_{be,le}_p and stn_{be,le}_phw/block/pflash_cfi01.c+8 -550 replies
3/3hw/pflash: implement update buffer for block writeshw/block/pflash_cfi01.c hw/block/pflash_cfi02.c hw/block/trace-events+89 -300 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchPhilippe Mathieu-Daudé
SeriesR-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] hw/pflash: implement update buffer for block writes

When running qemu with edk2 efi firmware on aarch64 the efi variable store in pflash can get corrupted. qemu not doing proper block writes -- flush all or nothing to storage -- is a hot candidate for being the root cause.

This little series tries to fix that with an update buffer where block writes are staged, so we can commit or discard the changes when the block write is completed or canceled.

v2:
- add patch to use ldn_{be,le}_p and stn_{be,le}_p
- add/update tracing

Gerd Hoffmann (3):
hw/pflash: refactor pflash_data_write() hw/pflash: use ldn_{be,le}_p and stn_{be,le}_p hw/pflash: implement update buffer for block writes

 hw/block/pflash_cfi01.c | 171 +++++++++++++++++++++-------------------
 hw/block/pflash_cfi02.c |   2 +-
 hw/block/trace-events   |   7 +-
 3 files changed, 97 insertions(+), 83 deletions(-)
Signature · 1 line
2.43.0