Skip to content

drm/msm/dpu: debug commit_done timeouts

Dmitry Baryshkov dri-devel linux-arm-msm lkml 4 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20240106-fd-dpu-debug-timeout-e917f0bc8063

Versions newest first

  1. v4 Latest3 patches 1 replyApplied
  2. v33 patches 8 repliesSuperseded
  3. v21 patch 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Changes in v4 from the cover letter

- Reworded documentation for new funcsions (Abhinav)
- Link to v3: https://lore.kernel.org/r/[email protected]

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/3drm/msm/dpu: make "vblank timeout" more usefuldrivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c+1 -10 replies
2/3drm/msm/dpu: split dpu_encoder_wait_for_event into two functionsdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +1 more+55 -490 replies
3/3drm/msm/dpu: capture snapshot on the first commit_done timeoutdrivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c+9 -00 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchAbhinav Kumar
1/3R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] drm/msm/dpu: debug commit_done timeouts

In order to debug commit_done timeouts ([1]) display the sticky bits of the CTL_FLUSH register and capture the devcore dump when the first such timeout occurs.

[1] https://gitlab.freedesktop.org/drm/msm/-/issues/33

---
Changes in v4:
- Reworded documentation for new funcsions (Abhinav)
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Capture the snapshot only on the first comit_done timeout (Abhinav)
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Added a call to msm_disp_snapshot_state() to trigger devcore dump
(Abhinav)
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Dmitry Baryshkov (3):
drm/msm/dpu: make "vblank timeout" more useful drm/msm/dpu: split dpu_encoder_wait_for_event into two functions drm/msm/dpu: capture snapshot on the first commit_done timeout

 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c        | 79 ++++++++++++++++------
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h        | 22 +-----
 .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c   |  2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c            |  2 +-
 drivers/gpu/drm/msm/msm_drv.h                      | 10 ---
 5 files changed, 65 insertions(+), 50 deletions(-)

---
base-commit: 33e1d31873f87d119e5120b88cd350efa68ef276
change-id: 20240106-fd-dpu-debug-timeout-e917f0bc8063

Best regards,

Signature · 1 line
Dmitry Baryshkov <[email protected]>