Skip to content

netfs, cachefiles: More additional patches

David Howells ceph-devel linux-cifs linux-erofs linux-fsdevel linux-mm linux-nfs lkml netdev v9fs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6netfs: Mark netfs_unbuffered_write_iter_locked() staticfs/netfs/direct_write.c fs/netfs/internal.h+2 -80 replies
2/6netfs: Count DIO writesfs/netfs/direct_write.c fs/netfs/internal.h fs/netfs/stats.c+9 -40 replies
3/6netfs: Fix interaction between write-streaming and cachefiles cullingfs/cachefiles/io.c fs/netfs/buffered_write.c fs/netfs/fscache_stats.c +4 more+41 -150 replies
4/6netfs: Fix the loop that unmarks folios after writing to the cachefs/netfs/buffered_write.c fs/netfs/io.c+2 -10 replies
5/6cachefiles: Fix signed/unsigned mixupfs/cachefiles/io.c+3 -32 replies
6/6netfs: Fix wrong #ifdef hiding waitfs/netfs/buffered_write.c+1 -10 replies

Reviews trailers per patch

1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSimon HormanGao XiangMarc DionneJeff LaytonJia Zhu
SeriesT-b R-b
1/6
2/6
3/6
4/6
5/6R-b R-b T-b
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 0/6] netfs, cachefiles: More additional patches

Hi Christian, Jeff, Gao,

Here are some additional patches for my netfs-lib tree:

(1) Mark netfs_unbuffered_write_iter_locked() static as it's only used in the file in which it is defined.

(2) Display a counter for DIO writes in /proc/fs/netfs/stats.

(3) Fix the interaction between write-streaming (dirty data in non-uptodate pages) and the culling of a cache file trying to write that to the cache.

(4) Fix the loop that unmarks folios after writing to the cache. The xarray iterator only advances the index by 1, so if we unmarked a multipage folio and that got split before we advance to the next folio, we see a repeat of a fragment of the folio.

(5) Fix a mixup with signed/unsigned offsets when prepping for writing to the cache that leads to missing error detection.

(6) Fix a wrong ifdef hiding a wait.

David

The netfslib postings:

David Howells (6):
netfs: Mark netfs_unbuffered_write_iter_locked() static
netfs: Count DIO writes
netfs: Fix interaction between write-streaming and cachefiles culling
netfs: Fix the loop that unmarks folios after writing to the cache
cachefiles: Fix signed/unsigned mixup
netfs: Fix wrong #ifdef hiding wait

 fs/cachefiles/io.c            | 18 +++++++++---------
 fs/netfs/buffered_write.c     | 27 ++++++++++++++++++++++-----
 fs/netfs/direct_write.c       |  5 +++--
 fs/netfs/fscache_stats.c      |  9 ++++++---
 fs/netfs/internal.h           |  8 ++------
 fs/netfs/io.c                 |  2 +-
 fs/netfs/stats.c              | 13 +++++++++----
 include/linux/fscache-cache.h |  3 +++
 include/linux/netfs.h         |  1 +
 9 files changed, 56 insertions(+), 30 deletions(-)