Skip to content

set related parser fixes

Florian Westphal netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest3 patches 1 replyIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3intervals: allow low-level interval code to return errorssrc/evaluate.c src/intervals.c tests/shell/testcases/bogons/nft-f/unhandled_key_type_13_assert+63 -150 replies
2/3src: do not merge a set with a erroneous oneinclude/rule.h src/evaluate.c src/intervals.c +1 more+20 -10 replies
3/3evaluate: don't assert if set->data is NULLsrc/evaluate.c tests/shell/testcases/bogons/nft-f/expr_evaluate_mapping_no_data_assert+16 -11 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 nft 0/3] set related parser fixes

This patchset makes parsing and evaluation of sets and set elements more robust.

See individual patches and the included bogus-input-tests for details.

Florian Westphal (3):
intervals: allow low-level interval code to return errors
src: do not merge a set with a erroneous one
evaluate: don't assert if set->data is NULL

 include/rule.h                                |  2 +
 src/evaluate.c                                | 31 +++++++++-
 src/intervals.c                               | 62 ++++++++++++++-----
 .../expr_evaluate_mapping_no_data_assert      |  4 ++
 .../nft-f/invalid_range_expr_type_binop       | 12 ++++
 .../bogons/nft-f/unhandled_key_type_13_assert |  5 ++
 6 files changed, 99 insertions(+), 17 deletions(-)
 create mode 100644 tests/shell/testcases/bogons/nft-f/expr_evaluate_mapping_no_data_assert
 create mode 100644 tests/shell/testcases/bogons/nft-f/invalid_range_expr_type_binop
 create mode 100644 tests/shell/testcases/bogons/nft-f/unhandled_key_type_13_assert
Signature · 1 line
2.41.0