Skip to content

iptables-save: Avoid /etc/protocols lookups

Phil Sutter netfilter-devel 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 1 replyIn review
  2. v12 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Revert "xshared: Print protocol numbers if --numeric was given"iptables/tests/shell/testcases/ip6tables/0002-verbose-output_0 iptables/tests/shell/testcases/ipt-restore/0011-noflush-empty-line_0 iptables/tests/shell/testcases/iptables/0002-verbose-output_0 +1 more+11 -110 replies
2/3libxtables: Add dccp and ipcomp to xtables_chain_protoslibxtables/xtables.c+2 -00 replies
3/3iptables-save: Avoid /etc/protocols lookupsiptables/tests/shell/testcases/ipt-save/0001load-dumps_0 iptables/xshared.c+2 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [iptables PATCH v2 0/3] iptables-save: Avoid /etc/protocols lookups

V1 was a tad too simple: The revert is fine, but the (now) third patch changes iptables-save output and thus potentially breaks test cases. To avoid that, add patch 2 which enables "dccp" and "ipcomp" protocol names in output. Apart from that, a single shell test case expected '-p gre' in the dump. Replace the actually printed '-p 47' using sed in there.

Phil Sutter (3):
Revert "xshared: Print protocol numbers if --numeric was given"
libxtables: Add dccp and ipcomp to xtables_chain_protos
iptables-save: Avoid /etc/protocols lookups

 .../shell/testcases/ip6tables/0002-verbose-output_0    | 10 +++++-----
 .../testcases/ipt-restore/0011-noflush-empty-line_0    |  2 +-
 .../tests/shell/testcases/ipt-save/0001load-dumps_0    |  1 +
 .../shell/testcases/iptables/0002-verbose-output_0     |  4 ++--
 iptables/xshared.c                                     |  8 ++++----
 libxtables/xtables.c                                   |  2 ++
 6 files changed, 15 insertions(+), 12 deletions(-)
Signature · 1 line
2.43.0