RFC dump_stack: Allow runtime updates of the hardware description
Get series with b4
b4 am 20240118-update-dump-stack-arch-str-v1-0-5c0f98d017b5@linux.ibm.com change-id 20240111-update-dump-stack-arch-str-7f0880d23f30Versions newest first
- v1 RFC Latest5 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | dump_stack: Make arch description buffer __ro_after_initlib/ | +2 | 0 replies | |
| 2/5 | dump_stack: Allow update of arch description string at runtimeinclude/ lib/ | +55 | 0 replies | |
| 3/5 | powerpc/prom: Add CPU info to hardware description string laterarch/ | +8 | 0 replies | |
| 4/5 | powerpc/pseries: Prepare pseries_add_hw_description() for runtime usearch/ | +5 | 0 replies | |
| 5/5 | powerpc/pseries: Update hardware description string after migrationarch/ arch/ arch/ | +76 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RFC 0/5] dump_stack: Allow runtime updates of the hardware description
When the kernel emits a stack trace, typically it includes a hardware description string, e.g.
Kernel panic - not syncing: sysrq triggered crash CPU: 6 PID: 46433 Comm: bash Tainted: G W 6.7.0-rc2+ #83
Quoted 1 line
Hardware name: IBM,9040-MR9 POWER9 (architected) 0x4e2102 0xf000005 of:IBM,FW950.01 (VM950_047) hv:phyp pSeries
Call Trace: dump_stack_lvl+0xc4/0x170 (unreliable) panic+0x39c/0x584 sysrq_handle_crash+0x80/0xe0 __handle_sysrq+0x208/0x4bc [...]
This string is a statically allocated buffer populated during boot by arch code calling dump_stack_set_arch_desc(). For most platforms this is sufficient.
But the string may become inaccurate on the IBM PowerVM platform due to live migration between machine models and firmware versions. Stack dumps emitted after a migration reflect the machine on which the kernel booted, not necessarily the machine on which it is currently running. This is potentially confusing for anyone investigating kernel issues on the platform.
To address this, this series introduces a new function that safely updates the hardware description string and updates the powerpc pseries platform code to call it after a migration. The series also includes changes addressing minor latent issues identified during the implementation.
Platforms which do not need the new functionality remain unchanged.
For this initial version at least, the powerpc/pseries part includes some "self-test" code that 1. verifies that reconstructing the hardware description string late in boot matches the one that was built earlier, and 2. fully exercises the update path before any migrations occur. This could be dropped or made configurable in the future.
---
Nathan Lynch (5):
dump_stack: Make arch description buffer __ro_after_init
dump_stack: Allow update of arch description string at runtime powerpc/prom: Add CPU info to hardware description string later powerpc/pseries: Prepare pseries_add_hw_description() for runtime use powerpc/pseries: Update hardware description string after migration
arch/powerpc/kernel/prom.c | 12 +++-- arch/powerpc/platforms/pseries/mobility.c | 5 ++ arch/powerpc/platforms/pseries/pseries.h | 1 + arch/powerpc/platforms/pseries/setup.c | 80 +++++++++++++++++++++++++++++-- include/linux/printk.h | 5 ++ lib/dump_stack.c | 57 ++++++++++++++++++++-- 6 files changed, 146 insertions(+), 14 deletions(-)
---
base-commit: 44a1aad2fe6c10bfe0589d8047057b10a4c18a19
change-id: 20240111-update-dump-stack-arch-str-7f0880d23f30
Best regards,
Signature · 1 line
Nathan Lynch <[email protected]>