mptcp: better validation of MPTCPOPT_MP_JOIN option
Status from this message: This series was applied to netdev/net.git (main)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 5 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | mptcp: mptcp_parse_option() fix for MPTCPOPT_MP_JOINnet/ | +3 | 1 reply | Applied |
| 2/5 | mptcp: strict validation before using mp_opt->hmacnet/ | +1 | 1 reply | Applied |
| 3/5 | mptcp: use OPTION_MPTCP_MPJ_SYNACK in subflow_finish_connect()net/ | +1 | 1 reply | Applied |
| 4/5 | mptcp: use OPTION_MPTCP_MPJ_SYN in subflow_check_req()net/ | +2 | 1 reply | Applied |
| 5/5 | mptcp: refine opt_mp_capable determinationnet/ | +4 | 2 replies | Applied |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Paolo Abeni | Mat Martineau | Simon Horman |
|---|---|---|---|
| Series | A-b | R-b | |
| 1/5 | R-b | ||
| 2/5 | R-b | ||
| 3/5 | R-b | ||
| 4/5 | R-b | ||
| 5/5 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net 0/5] mptcp: better validation of MPTCPOPT_MP_JOIN option
Based on a syzbot report (see 4th patch in the series).
We need to be more explicit about which one of the following flag is set by mptcp_parse_option():
- OPTION_MPTCP_MPJ_SYN
- OPTION_MPTCP_MPJ_SYNACK
- OPTION_MPTCP_MPJ_ACK
Then select the appropriate values instead of OPTIONS_MPTCP_MPJ
Paolo suggested to do the same for OPTIONS_MPTCP_MPC (5th patch)
Eric Dumazet (5):
mptcp: mptcp_parse_option() fix for MPTCPOPT_MP_JOIN
mptcp: strict validation before using mp_opt->hmac
mptcp: use OPTION_MPTCP_MPJ_SYNACK in subflow_finish_connect()
mptcp: use OPTION_MPTCP_MPJ_SYN in subflow_check_req()
mptcp: refine opt_mp_capable determination
net/mptcp/options.c | 6 +++--- net/mptcp/subflow.c | 16 ++++++++-------- 2 files changed, 11 insertions(+), 11 deletions(-)
Signature · 1 line
2.43.0.275.g3460e3d667-goog