Skip to content

Fix kernelshark issues introduced by the migration to Qt6

Benjamin ROBIN linux-trace-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest34 patches 15 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/34kernelshark: Fix modelReset() signaling, rename update to updateGeomsrc/KsGLWidget.cpp src/KsGLWidget.hpp src/KsTraceGraph.cpp+4 -40 replies
2/34kernelshark: Add .gitignore.gitignore+15 -00 replies
3/34kernelshark: Remove function param when not used, whenever possiblesrc/KsAdvFilteringDialog.cpp src/KsAdvFilteringDialog.hpp src/KsMainWindow.cpp+5 -50 replies
4/34kernelshark: Do not create a temporary container for looping over QMapsrc/KsAdvFilteringDialog.cpp+3 -34 replies
5/34kernelshark: Prevent potential detach of QMap containersrc/KsGLWidget.cpp src/plugins/KVMComboDialog.cpp+7 -42 replies
6/34kernelshark: Fix used after free of QByteArray raw datasrc/KsAdvFilteringDialog.cpp+3 -110 replies
7/34kernelshark: Fix potential memory leak in KsGLWidgetsrc/KsGLWidget.cpp+9 -160 replies
8/34kernelshark: Use lambda parameter instead of captured local variablesrc/KsGLWidget.cpp+6 -60 replies
9/34kernelshark: Keep overridden method protected instead of publicsrc/KsGLWidget.hpp src/KsModels.hpp src/KsPlotTools.hpp +2 more+37 -330 replies
10/34kernelshark: Use sliced() or first() instead of mid/right/left()src/KsMainWindow.cpp src/KsUtils.cpp+3 -30 replies
11/34kernelshark: Prevent potential divide by zero in Shape::center()src/KsPlotTools.cpp+8 -62 replies
12/34kernelshark: Fix potential access to uninitialized variablesrc/KsSession.cpp+2 -20 replies
13/34kernelshark: Remove unused locals variablessrc/KsTraceGraph.cpp src/KsUtils.cpp src/plugins/KVMComboDialog.cpp+0 -30 replies
14/34kernelshark: Fix range-loop-reference Clazy warningsrc/KsUtils.cpp+1 -10 replies
15/34kernelshark: Fix moving a temp object prevents copy elision warningsrc/KsTraceViewer.cpp+1 -10 replies
16/34kernelshark: Add receiver object to connect() callsrc/KsTraceViewer.cpp+1 -10 replies
17/34kernelshark: Return by reference the list of header in KsModelssrc/KsModels.hpp+1 -10 replies
18/34kernelshark: Fix detaching-temporary Clazy warningsrc/KsTraceViewer.cpp src/KsUtils.hpp+4 -40 replies
19/34kernelshark: Fix qfileinfo-exists Clazy warningsrc/KsUtils.cpp+1 -10 replies
20/34kernelshark: Fix potential memory leaks in libkshark-configiosrc/libkshark-configio.c+41 -332 replies
21/34kernelshark: Fix potential access to uninitialized variablesrc/libkshark-configio.c+2 -20 replies
22/34kernelshark: Fix potential double free of histo->map, histo->bin_countsrc/libkshark-model.c+2 -10 replies
23/34kernelshark: Fix 'const' type qualifier on return type has no effectsrc/libkshark-tepdata.c src/libkshark.h tests/test-input.c +1 more+20 -200 replies
24/34kernelshark: Fix potential memory leaks in libkshark-tepdatasrc/libkshark-tepdata.c+11 -52 replies
25/34kernelshark: Fix typo in comment of KsGLWidget::resizeGL()src/KsGLWidget.cpp+1 -10 replies
26/34kernelshark: Remove unused KsDataWidget::wipPtr() and broken functionsrc/KsWidgetsLib.hpp+0 -60 replies
27/34kernelshark: In KsTimeOffsetDialog() constructor use parent paramsrc/KsWidgetsLib.cpp+1 -10 replies
28/34kernelshark: Fixed loop counter incremented suspiciously twiceexamples/datafilter.c+0 -60 replies
29/34kernelshark: Fix tepdata_dump_entry() for event_id = KS_EVENT_OVERFLOWsrc/libkshark-tepdata.c+1 -00 replies
30/34kernelshark: Use static_cast instead of C cast in KsMainWindowsrc/KsMainWindow.cpp+1 -10 replies
31/34kernelshark: Fix comparison of integers of different signs warningsexamples/configio.c examples/datafilter.c examples/datahisto.c +7 more+44 -321 reply
32/34kernelshark: Fix KsTableView columns width, and KsTraceViewer sizesrc/KsTraceViewer.cpp src/KsTraceViewer.hpp+20 -490 replies
33/34kernelshark: Allow to reduce a bit more the graph heightsrc/KsTraceGraph.cpp+2 -22 replies
34/34kernelshark: Cleanup of KsDualMarker methodssrc/KsDualMarker.hpp+2 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/34] Fix kernelshark issues introduced by the migration to Qt6

There were 3 majors issues:
- A segfault when loading a trace file (patch 0001)
- The trace table height was very small (patch 0032)
- The trace table columns width were reducing when clicking Marker A or B (patch 0032)

Also fix most of the warnings reported by Clang-Tidy and Clazy, and by gcc with -Wextra.

Benjamin ROBIN (34):
kernelshark: Fix modelReset() signaling, rename update to updateGeom
kernelshark: Add .gitignore
kernelshark: Remove function param when not used, whenever possible
kernelshark: Do not create a temporary container for looping over QMap
kernelshark: Prevent potential detach of QMap container
kernelshark: Fix used after free of QByteArray raw data
kernelshark: Fix potential memory leak in KsGLWidget
kernelshark: Use lambda parameter instead of captured local variable
kernelshark: Keep overridden method protected instead of public
kernelshark: Use sliced() or first() instead of mid/right/left()
kernelshark: Prevent potential divide by zero in Shape::center()
kernelshark: Fix potential access to uninitialized variable
kernelshark: Remove unused locals variables
kernelshark: Fix range-loop-reference Clazy warning
kernelshark: Fix moving a temp object prevents copy elision warning
kernelshark: Add receiver object to connect() call
kernelshark: Return by reference the list of header in KsModels
kernelshark: Fix detaching-temporary Clazy warning
kernelshark: Fix qfileinfo-exists Clazy warning
kernelshark: Fix potential memory leaks in libkshark-configio
kernelshark: Fix potential access to uninitialized variable
kernelshark: Fix potential double free of histo->map, histo->bin_count
kernelshark: Fix 'const' type qualifier on return type has no effect
kernelshark: Fix potential memory leaks in libkshark-tepdata
kernelshark: Fix typo in comment of KsGLWidget::resizeGL()
kernelshark: Remove unused KsDataWidget::wipPtr() and broken function
kernelshark: In KsTimeOffsetDialog() constructor use parent param
kernelshark: Fixed loop counter incremented suspiciously twice
kernelshark: Fix tepdata_dump_entry() for event_id = KS_EVENT_OVERFLOW
kernelshark: Use static_cast instead of C cast in KsMainWindow
kernelshark: Fix comparison of integers of different signs warnings
kernelshark: Fix KsTableView columns width, and KsTraceViewer size
kernelshark: Allow to reduce a bit more the graph height
kernelshark: Cleanup of KsDualMarker methods

 .gitignore                     | 15 ++++++
 examples/configio.c            |  3 +-
 examples/datafilter.c          | 15 +++---
 examples/datahisto.c           |  2 +-
 src/KsAdvFilteringDialog.cpp   | 24 ++++------
 src/KsAdvFilteringDialog.hpp   |  2 +-
 src/KsDualMarker.hpp           | 10 +---
 src/KsGLWidget.cpp             | 48 +++++++++----------
 src/KsGLWidget.hpp             | 43 ++++++++---------
 src/KsMainWindow.cpp           |  8 ++--
 src/KsModels.hpp               | 11 +++--
 src/KsPlotTools.cpp            | 14 +++---
 src/KsPlotTools.hpp            |  2 +-
 src/KsSession.cpp              |  4 +-
 src/KsTraceGraph.cpp           |  7 ++-
 src/KsTraceViewer.cpp          | 71 ++++++++--------------------
 src/KsTraceViewer.hpp          | 11 +++--
 src/KsUtils.cpp                |  9 ++--
 src/KsUtils.hpp                |  4 +-
 src/KsWidgetsLib.cpp           |  2 +-
 src/KsWidgetsLib.hpp           | 15 ++----
 src/libkshark-collection.c     | 14 +++---
 src/libkshark-configio.c       | 84 +++++++++++++++++++---------------
 src/libkshark-hash.c           |  5 +-
 src/libkshark-model.c          | 19 ++++----
 src/libkshark-tepdata.c        | 31 ++++++++-----
 src/libkshark.c                | 17 +++----
 src/libkshark.h                | 20 ++++----
 src/plugins/KVMComboDialog.cpp |  7 +--
 src/plugins/sched_events.c     |  2 +-
 tests/test-input.c             |  4 +-
 tests/test-input_ctrl.c        |  4 +-
 32 files changed, 257 insertions(+), 270 deletions(-)
 create mode 100644 .gitignore

--
2.43.0