Skip to content

benchmarks/gem_wsim: Extend engine selection syntax

Marcin Bernatowicz igt-dev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 8 repliesIn review
  2. v26 patches 2 repliesSuperseded
  3. v12 patches 5 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6benchmarks/gem_wsim: Introduce intel_engines structurebenchmarks/gem_wsim.c+37 -351 reply
2/6benchmarks/gem_wsim: Unify bond handlingbenchmarks/gem_wsim.c+7 -131 reply
3/6benchmarks/gem_wsim: Introduce engine_idx to streamline engine selectionbenchmarks/gem_wsim.c+82 -581 reply
4/6benchmarks/gem_wsim: Update request_idx in prepare phasebenchmarks/gem_wsim.c+20 -161 reply
5/6benchmarks/gem_wsim: Extend engine selection syntaxbenchmarks/gem_wsim.c+323 -3201 reply
6/6benchmarks/gem_wsim: Option to list physical enginesbenchmarks/gem_wsim.c+42 -11 reply

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchKamil Konieczny
SeriesA-b
1/6A-b
2/6A-b
3/6A-b
4/6A-b
5/6A-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 i-g-t 0/6] benchmarks/gem_wsim: Extend engine selection syntax

Introduces significant changes to the engine selection syntax:
- Dynamically generates the list of available physical engines.
- Identifies engines using [class:instance:gt] tuples.
- Allows specifying engine instance and gt as engine_class[<engine_instance>-<gt_id>].
- Adds support for compute engine class (CCS).
- Maintains 1-based engine instance ids for compatibility with existing workload definitions.
- Enhances w_step with engine_idx
and request_idx for throttling functionality (both populated during prepare workload phase).

Adds command line option (-l) to list physical engines.

v2: Split into multiple patches for easier review (Tvrtko)
v3: Rebase patchseries (Kamil)
Corrected indentation, unbalanced braces, multiple assignments.

Marcin Bernatowicz (6):
benchmarks/gem_wsim: Introduce intel_engines structure benchmarks/gem_wsim: Unify bond handling benchmarks/gem_wsim: Introduce engine_idx to streamline engine
selection
benchmarks/gem_wsim: Update request_idx in prepare phase benchmarks/gem_wsim: Extend engine selection syntax benchmarks/gem_wsim: Option to list physical engines

 benchmarks/gem_wsim.c | 840 +++++++++++++++++++++++-------------------
 1 file changed, 454 insertions(+), 386 deletions(-)
Signature · 1 line
2.31.1