Constify all the things
Get series with b4
b4 am [email protected] change-id 20240116-const-bc91df591e93Versions newest first
- v1 Latest20 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | src: const annotate the bluetooth plugin APIsrc/ src/ src/ +1 more | +9 | 1 reply | |
| 2/20 | monitor: const annotate util_ltv_debugger instances and APImonitor/ | +6 | 0 replies | |
| 3/20 | monitor: const annotate cmd/handler tablesmonitor/ | +17 | 0 replies | |
| 4/20 | monitor: const annotate misc arraysmonitor/ monitor/ monitor/ +3 more | +10 | 0 replies | |
| 5/20 | monitor: const annotate intel_version_tlv_desc::type_str and APImonitor/ | +13 | 0 replies | |
| 6/20 | monitor: const annotate type_table and related APImonitor/ | +3 | 0 replies | |
| 7/20 | profiles: annotate immutable data as constprofiles/ profiles/ profiles/ +5 more | +24 | 0 replies | |
| 8/20 | attrib: annotate immutable data as constattrib/ attrib/ | +5 | 0 replies | |
| 9/20 | client: annotate struct option instances as constclient/ | +20 | 0 replies | |
| 10/20 | emulator: const annotate rfcomm_crc_table[]emulator/ | +1 | 0 replies | |
| 11/20 | gobex: const annotate RO arrays, use G_N_ELEMENTSgobex/ | +4 | 0 replies | |
| 12/20 | lib: const annotate hci_map instances and related APIclient/ lib/ lib/ | +24 | 0 replies | |
| 13/20 | lib: const annotate tupla instances and APIlib/ | +10 | 0 replies | |
| 14/20 | mesh: const annotate misc datamesh/ | +2 | 0 replies | |
| 15/20 | obexd: remove obex_mime_type_driver::set_io_watchobexd/ obexd/ obexd/ | +12 | 0 replies | |
| 16/20 | obexd: const obex_mime_type_driver instances and APIobexd/ obexd/ obexd/ +7 more | +30 | 0 replies | |
| 17/20 | obexd: const obex_service_driver instances and APIobexd/ obexd/ obexd/ +10 more | +25 | 0 replies | |
| 18/20 | obexd: const obex_transport_driver instances and APIobexd/ obexd/ obexd/ +3 more | +18 | 0 replies | |
| 19/20 | obexd: const annotate misc immutable dataobexd/ obexd/ obexd/ +3 more | +10 | 0 replies | |
| 20/20 | obexd: const annotate obex_plugin_desc entrypointobexd/ obexd/ obexd/ | +8 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH BlueZ 00/20] Constify all the things
Hello list,
Here is series#2 of the paper cut fixes. Here we annotate a handful of the data as constant alongside updating all the respective APIs.
There's nothing particularly existing or controversial here, despite the size of the series. That said, I'm not 100% sure that all code-paths have been (runtime) tested.
As always - any input will be appreciated.
Thanks
Emil
---
Emil Velikov (20):
src: const annotate the bluetooth plugin API
monitor: const annotate util_ltv_debugger instances and API
monitor: const annotate cmd/handler tables
monitor: const annotate misc arrays
monitor: const annotate intel_version_tlv_desc::type_str and API
monitor: const annotate type_table and related API
profiles: annotate immutable data as const
attrib: annotate immutable data as const
client: annotate struct option instances as const
emulator: const annotate rfcomm_crc_table[]
gobex: const annotate RO arrays, use G_N_ELEMENTS
lib: const annotate hci_map instances and related API
lib: const annotate tupla instances and API
mesh: const annotate misc data
obexd: remove obex_mime_type_driver::set_io_watch
obexd: const obex_mime_type_driver instances and API
obexd: const obex_service_driver instances and API
obexd: const obex_transport_driver instances and API
obexd: const annotate misc immutable data
obexd: const annotate obex_plugin_desc entrypoint
attrib/gatttool.c | 8 +++--- attrib/interactive.c | 2 +- client/mgmt.c | 42 ++++++++++++++++---------------- emulator/bthost.c | 2 +- gobex/gobex.c | 8 +++--- lib/hci.c | 42 ++++++++++++++++---------------- lib/hci_lib.h | 4 +-- lib/sdp.c | 20 +++++++-------- mesh/agent.c | 4 +-- monitor/att.c | 54 ++++++++++++++++++++--------------------- monitor/avctp.c | 2 +- monitor/intel.c | 28 ++++++++++----------- monitor/l2cap.c | 2 +- monitor/rfcomm.c | 2 +- monitor/sdp.c | 10 ++++---- obexd/client/manager.c | 6 ++--- obexd/client/map.c | 4 +-- obexd/client/mns.c | 8 +++--- obexd/plugins/bluetooth.c | 6 ++--- obexd/plugins/filesystem.c | 8 +++--- obexd/plugins/ftp.c | 2 +- obexd/plugins/irmc.c | 4 +-- obexd/plugins/mas.c | 18 +++++++------- obexd/plugins/opp.c | 2 +- obexd/plugins/pbap.c | 8 +++--- obexd/plugins/pcsuite.c | 4 +-- obexd/plugins/phonebook-ebook.c | 2 +- obexd/plugins/syncevolution.c | 4 +-- obexd/src/genbuiltin | 4 +-- obexd/src/main.c | 2 +- obexd/src/mimetype.c | 26 +++++++------------- obexd/src/mimetype.h | 12 +++++---- obexd/src/obex-priv.h | 4 +-- obexd/src/obex.c | 18 +++++++------- obexd/src/plugin.c | 8 +++--- obexd/src/plugin.h | 4 +-- obexd/src/server.c | 10 ++++---- obexd/src/server.h | 2 +- obexd/src/service.c | 20 +++++++-------- obexd/src/service.h | 6 ++--- obexd/src/transport.c | 14 +++++------ obexd/src/transport.h | 6 ++--- profiles/audio/avctp.c | 2 +- profiles/audio/avrcp.c | 8 +++--- profiles/audio/media.c | 6 ++--- profiles/audio/sink.c | 2 +- profiles/audio/source.c | 2 +- profiles/audio/transport.c | 12 ++++----- profiles/health/hdp_util.c | 15 ++++++------ profiles/iap/main.c | 2 +- src/genbuiltin | 4 +-- src/log.c | 2 +- src/plugin.c | 6 ++--- src/plugin.h | 6 ++--- 54 files changed, 251 insertions(+), 258 deletions(-)
---
base-commit: 770ad5614e7e8074133e6f563495ce4822f63fe4
change-id: 20240116-const-bc91df591e93
Best regards,
Signature · 1 line
Emil Velikov <[email protected]>