Skip to content

tty: vt: cleanup and documentation

Jiri Slaby (SUSE) dri-devel linux-doc linux-fbdev linux-parisc linux-serial lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest47 patches 2 repliesIn review
  2. v145 patches 9 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/47vgacon: inline vc_scrolldelta_helper() into vgacon_scrolldelta()drivers/tty/vt/vt.c drivers/video/console/vgacon.c include/linux/vt_kern.h+34 -450 replies
2/47fbcon: make display_desc a static array in fbcon_startup()drivers/video/fbdev/core/fbcon.c+1 -10 replies
3/47tty: vt: fix 20 vs 0x20 typo in EScsiignoredrivers/tty/vt/vt.c+1 -10 replies
4/47tty: vt: expect valid vc when in tty opsdrivers/tty/vt/vt.c+3 -160 replies
5/47tty: vt: pass proper pointers from tioclinux()drivers/tty/vt/selection.c drivers/tty/vt/vt.c include/linux/selection.h+15 -140 replies
6/47tty: vt: push console lock from tioclinux() down to 2 functionsdrivers/tty/vt/selection.c drivers/tty/vt/vt.c+14 -100 replies
7/47tty: vt: pass vc_resize_user as a parameterdrivers/tty/vt/vt.c drivers/tty/vt/vt_ioctl.c drivers/video/console/vgacon.c +4 more+27 -250 replies
8/47tty: vt: make vc_is_sel()'s vc constdrivers/tty/vt/selection.c include/linux/selection.h+2 -20 replies
9/47tty: vt: define an enum for CSI+m codesdrivers/tty/vt/vt.c+69 -290 replies
10/47tty: vt: use case ranges for CSI+m fg/bg colorsdrivers/tty/vt/vt.c+16 -190 replies
11/47tty: vt: define an enum for CSI+J codesdrivers/tty/vt/vt.c+15 -80 replies
12/47tty: vt: reflow csi_J()drivers/tty/vt/vt.c+25 -250 replies
13/47use clamp() for counts in csi_?() handlersdrivers/tty/vt/vt.c+5 -220 replies
14/47don't pass vc->vc_par[0] to csi_?() handlersdrivers/tty/vt/vt.c+19 -160 replies
15/47tty: vt: define an enum for CSI+K codesdrivers/tty/vt/vt.c+9 -30 replies
16/47tty: vt: reflow csi_K()drivers/tty/vt/vt.c+14 -140 replies
17/47tty: vt: define an enum for ascii charactersdrivers/tty/vt/vt.c+44 -180 replies
18/47tty: vt: remove extern from functions in selection.hinclude/linux/selection.h+24 -280 replies
19/47tty: vt: make consw::con_debug_*() return voiddrivers/tty/vt/vt.c drivers/video/fbdev/core/fbcon.c include/linux/console.h+12 -330 replies
20/47tty: vt: make init parameter of consw::con_init() a booldrivers/tty/vt/vt.c drivers/video/console/dummycon.c drivers/video/console/mdacon.c +5 more+14 -120 replies
21/47tty: vt: sanitize arguments of consw::con_clear()drivers/tty/vt/vt.c drivers/video/console/dummycon.c drivers/video/console/mdacon.c +5 more+39 -370 replies
22/47tty: vt: remove checks for count in consw::con_clear() implementationsdrivers/video/console/mdacon.c drivers/video/console/sticon.c+0 -60 replies
23/47tty: vt: add con_putc() helperdrivers/tty/vt/vt.c+13 -50 replies
24/47tty: vt: eliminate unneeded consw::con_putc() implementationsdrivers/video/console/mdacon.c drivers/video/console/sticon.c drivers/video/console/vgacon.c +1 more+0 -290 replies
25/47tty: vt: sanitize consw::con_putc() parametersdrivers/video/console/dummycon.c drivers/video/console/newport_con.c include/linux/console.h+10 -50 replies
26/47tty: vt: sanitize consw::con_putcs() parametersdrivers/video/console/dummycon.c drivers/video/console/mdacon.c drivers/video/console/newport_con.c +4 more+22 -190 replies
27/47consoles: use if instead of switch-case in consw::con_cursor()drivers/video/console/newport_con.c drivers/video/console/sticon.c drivers/video/console/vgacon.c+53 -660 replies
28/47fbdev/core: simplify cursor_state setting in fbcon_ops::cursor()drivers/video/fbdev/core/bitblit.c drivers/video/fbdev/core/fbcon_ccw.c drivers/video/fbdev/core/fbcon_cw.c +1 more+4 -400 replies
29/47tty: vt: remove CM_* constantsdrivers/tty/vt/vt.c drivers/video/console/dummycon.c drivers/video/console/mdacon.c +11 more+36 -410 replies
30/47tty: vt: make consw::con_switch() return a booldrivers/tty/vt/vt.c drivers/video/console/dummycon.c drivers/video/console/mdacon.c +5 more+17 -150 replies
31/47tty: vt: stop using -1 for blank mode in consw::con_blank()drivers/tty/vt/vt.c drivers/video/console/vgacon.c+1 -20 replies
32/47tty: vt: define a common enum for VESA blanking constantsinclude/linux/console.h include/uapi/linux/fb.h include/uapi/linux/vesa.h+20 -130 replies
33/47tty: vt: use VESA blanking constantsdrivers/tty/vt/vt.c drivers/video/console/newport_con.c drivers/video/console/sticon.c +1 more+10 -90 replies
34/47tty: vt: use enum constants for VESA blanking modesdrivers/tty/vt/vt.c drivers/video/console/dummycon.c drivers/video/console/mdacon.c +5 more+20 -120 replies
35/47tty: vt: make types around consw::con_blank() booldrivers/video/console/dummycon.c drivers/video/console/mdacon.c drivers/video/console/newport_con.c +4 more+29 -240 replies
36/47tty: vt: make font of consw::con_font_set() constdrivers/tty/vt/vt.c drivers/video/console/newport_con.c drivers/video/console/sticon.c +3 more+11 -90 replies
37/47tty: vt: make consw::con_font_default()'s name constdrivers/video/console/newport_con.c drivers/video/console/sticon.c drivers/video/fbdev/core/fbcon.c +1 more+7 -40 replies
38/47tty: vt: change consw::con_set_origin() return typedrivers/video/console/vgacon.c include/linux/console.h+8 -50 replies
39/47fbcon: remove consw::con_screen_pos()drivers/video/fbdev/core/fbcon.c+0 -60 replies
40/47tty: vt: remove consw::con_screen_pos()drivers/tty/vt/vt.c include/linux/console.h+3 -100 replies
41/47tty: vt: make types of screenpos() more consistentdrivers/tty/vt/vt.c+5 -60 replies
42/47fbcon: remove fbcon_getxy()drivers/video/fbdev/core/fbcon.c+0 -250 replies
43/47tty: vt: remove consw::con_getxy()drivers/tty/vt/vt.c include/linux/console.h+5 -170 replies
44/47tty: vt: remove unused consw::con_flush_scrollback()drivers/tty/vt/vt.c include/linux/console.h+12 -190 replies
45/47tty: vt: document the rest of struct conswinclude/linux/console.h+25 -90 replies
46/47tty: vt: fix up kernel-docdrivers/tty/vt/selection.c drivers/tty/vt/vt.c include/linux/console.h+62 -601 reply
47/47Documentation: add console.rstDocumentation/driver-api/tty/console.rst Documentation/driver-api/tty/index.rst+46 -00 replies

Reviews trailers per patch

2 of 47 patches have a Reviewed-by or Acked-by.

PatchGeert UytterhoevenHelge DellerRandy Dunlap
SeriesT-b
1/47
2/47
3/47
4/47
5/47
6/47
7/47
8/47
9/47
10/47
11/47
12/47
13/47
14/47
15/47
16/47
17/47
18/47
19/47
20/47R-b
21/47
22/47
23/47
24/47
25/47
26/47
27/47
28/47
29/47
30/47
31/47
32/47
33/47
34/47
35/47
36/47
37/47
38/47
39/47
40/47
41/47
42/47
43/47
44/47
45/47
46/47R-b
47/47

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 00/47] tty: vt: cleanup and documentation

Push the console code (vt.c, vt.h, console.h, ...) into a bit more maintainable state. Especially all around consw structure and document it.

CSI parser is also a bit cleaned up. More to follow some time in the next round.

[v2] See respective patches for changes. The major changes:
* vesa.h introduced
* parameters of csi*() simplified

Cc Daniel Vetter <[email protected]>
Cc Helge Deller <[email protected]>
Cc "James E.J. Bottomley" <[email protected]>
Cc Jonathan Corbet <[email protected]>
Cc Martin Hostettler <[email protected]>
Cc Thomas Zimmermann <[email protected]>

Jiri Slaby (SUSE) (47):

vgacon: inline vc_scrolldelta_helper() into vgacon_scrolldelta()
fbcon: make display_desc a static array in fbcon_startup()
tty: vt: fix 20 vs 0x20 typo in EScsiignore
tty: vt: expect valid vc when in tty ops
tty: vt: pass proper pointers from tioclinux()
tty: vt: push console lock from tioclinux() down to 2 functions
tty: vt: pass vc_resize_user as a parameter
tty: vt: make vc_is_sel()'s vc const
tty: vt: define an enum for CSI+m codes
tty: vt: use case ranges for CSI+m fg/bg colors
tty: vt: define an enum for CSI+J codes
tty: vt: reflow csi_J()
use clamp() for counts in csi_?() handlers
don't pass vc->vc_par[0] to csi_?() handlers
tty: vt: define an enum for CSI+K codes
tty: vt: reflow csi_K()
tty: vt: define an enum for ascii characters
tty: vt: remove extern from functions in selection.h
tty: vt: make consw::con_debug_*() return void
tty: vt: make init parameter of consw::con_init() a bool
tty: vt: sanitize arguments of consw::con_clear()
tty: vt: remove checks for count in consw::con_clear() implementations
tty: vt: add con_putc() helper
tty: vt: eliminate unneeded consw::con_putc() implementations
tty: vt: sanitize consw::con_putc() parameters
tty: vt: sanitize consw::con_putcs() parameters
consoles: use if instead of switch-case in consw::con_cursor() fbdev/core: simplify cursor_state setting in fbcon_ops::cursor()
tty: vt: remove CM_* constants
tty: vt: make consw::con_switch() return a bool
tty: vt: stop using -1 for blank mode in consw::con_blank()
tty: vt: define a common enum for VESA blanking constants
tty: vt: use VESA blanking constants
tty: vt: use enum constants for VESA blanking modes
tty: vt: make types around consw::con_blank() bool
tty: vt: make font of consw::con_font_set() const
tty: vt: make consw::con_font_default()'s name const
tty: vt: change consw::con_set_origin() return type
fbcon: remove consw::con_screen_pos()
tty: vt: remove consw::con_screen_pos()
tty: vt: make types of screenpos() more consistent
fbcon: remove fbcon_getxy()
tty: vt: remove consw::con_getxy()
tty: vt: remove unused consw::con_flush_scrollback()
tty: vt: document the rest of struct consw
tty: vt: fix up kernel-doc
Documentation: add console.rst

 Documentation/driver-api/tty/console.rst |  45 ++
 Documentation/driver-api/tty/index.rst   |   1 +
 drivers/tty/vt/selection.c               |  43 +-
 drivers/tty/vt/vt.c                      | 645 +++++++++++------------
 drivers/tty/vt/vt_ioctl.c                |   6 +-
 drivers/video/console/dummycon.c         |  38 +-
 drivers/video/console/mdacon.c           |  43 +-
 drivers/video/console/newport_con.c      |  69 +--
 drivers/video/console/sticon.c           |  79 ++-
 drivers/video/console/vgacon.c           | 152 +++---
 drivers/video/fbdev/core/bitblit.c       |  13 +-
 drivers/video/fbdev/core/fbcon.c         | 123 ++---
 drivers/video/fbdev/core/fbcon.h         |   4 +-
 drivers/video/fbdev/core/fbcon_ccw.c     |  13 +-
 drivers/video/fbdev/core/fbcon_cw.c      |  13 +-
 drivers/video/fbdev/core/fbcon_ud.c      |  13 +-
 drivers/video/fbdev/core/tileblit.c      |   4 +-
 include/linux/console.h                  | 124 +++--
 include/linux/console_struct.h           |   1 -
 include/linux/selection.h                |  56 +-
 include/linux/vt_kern.h                  |  12 +-
 include/uapi/linux/fb.h                  |   8 +-
 include/uapi/linux/vesa.h                |  18 +
 23 files changed, 755 insertions(+), 768 deletions(-)
 create mode 100644 Documentation/driver-api/tty/console.rst
 create mode 100644 include/uapi/linux/vesa.h
Signature · 1 line
2.43.0