tty: vt: cleanup and documentation
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest47 patches 2 repliesIn review
- v145 patches 9 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/47 | vgacon: inline vc_scrolldelta_helper() into vgacon_scrolldelta()drivers/ drivers/ include/ | +34 | 0 replies | |
| 2/47 | fbcon: make display_desc a static array in fbcon_startup()drivers/ | +1 | 0 replies | |
| 3/47 | tty: vt: fix 20 vs 0x20 typo in EScsiignoredrivers/ | +1 | 0 replies | |
| 4/47 | tty: vt: expect valid vc when in tty opsdrivers/ | +3 | 0 replies | |
| 5/47 | tty: vt: pass proper pointers from tioclinux()drivers/ drivers/ include/ | +15 | 0 replies | |
| 6/47 | tty: vt: push console lock from tioclinux() down to 2 functionsdrivers/ drivers/ | +14 | 0 replies | |
| 7/47 | tty: vt: pass vc_resize_user as a parameterdrivers/ drivers/ drivers/ +4 more | +27 | 0 replies | |
| 8/47 | tty: vt: make vc_is_sel()'s vc constdrivers/ include/ | +2 | 0 replies | |
| 9/47 | tty: vt: define an enum for CSI+m codesdrivers/ | +69 | 0 replies | |
| 10/47 | tty: vt: use case ranges for CSI+m fg/bg colorsdrivers/ | +16 | 0 replies | |
| 11/47 | tty: vt: define an enum for CSI+J codesdrivers/ | +15 | 0 replies | |
| 12/47 | tty: vt: reflow csi_J()drivers/ | +25 | 0 replies | |
| 13/47 | use clamp() for counts in csi_?() handlersdrivers/ | +5 | 0 replies | |
| 14/47 | don't pass vc->vc_par[0] to csi_?() handlersdrivers/ | +19 | 0 replies | |
| 15/47 | tty: vt: define an enum for CSI+K codesdrivers/ | +9 | 0 replies | |
| 16/47 | tty: vt: reflow csi_K()drivers/ | +14 | 0 replies | |
| 17/47 | tty: vt: define an enum for ascii charactersdrivers/ | +44 | 0 replies | |
| 18/47 | tty: vt: remove extern from functions in selection.hinclude/ | +24 | 0 replies | |
| 19/47 | tty: vt: make consw::con_debug_*() return voiddrivers/ drivers/ include/ | +12 | 0 replies | |
| 20/47 | tty: vt: make init parameter of consw::con_init() a booldrivers/ drivers/ drivers/ +5 more | +14 | 0 replies | |
| 21/47 | tty: vt: sanitize arguments of consw::con_clear()drivers/ drivers/ drivers/ +5 more | +39 | 0 replies | |
| 22/47 | tty: vt: remove checks for count in consw::con_clear() implementationsdrivers/ drivers/ | +0 | 0 replies | |
| 23/47 | tty: vt: add con_putc() helperdrivers/ | +13 | 0 replies | |
| 24/47 | tty: vt: eliminate unneeded consw::con_putc() implementationsdrivers/ drivers/ drivers/ +1 more | +0 | 0 replies | |
| 25/47 | tty: vt: sanitize consw::con_putc() parametersdrivers/ drivers/ include/ | +10 | 0 replies | |
| 26/47 | tty: vt: sanitize consw::con_putcs() parametersdrivers/ drivers/ drivers/ +4 more | +22 | 0 replies | |
| 27/47 | consoles: use if instead of switch-case in consw::con_cursor()drivers/ drivers/ drivers/ | +53 | 0 replies | |
| 28/47 | fbdev/core: simplify cursor_state setting in fbcon_ops::cursor()drivers/ drivers/ drivers/ +1 more | +4 | 0 replies | |
| 29/47 | tty: vt: remove CM_* constantsdrivers/ drivers/ drivers/ +11 more | +36 | 0 replies | |
| 30/47 | tty: vt: make consw::con_switch() return a booldrivers/ drivers/ drivers/ +5 more | +17 | 0 replies | |
| 31/47 | tty: vt: stop using -1 for blank mode in consw::con_blank()drivers/ drivers/ | +1 | 0 replies | |
| 32/47 | tty: vt: define a common enum for VESA blanking constantsinclude/ include/ include/ | +20 | 0 replies | |
| 33/47 | tty: vt: use VESA blanking constantsdrivers/ drivers/ drivers/ +1 more | +10 | 0 replies | |
| 34/47 | tty: vt: use enum constants for VESA blanking modesdrivers/ drivers/ drivers/ +5 more | +20 | 0 replies | |
| 35/47 | tty: vt: make types around consw::con_blank() booldrivers/ drivers/ drivers/ +4 more | +29 | 0 replies | |
| 36/47 | tty: vt: make font of consw::con_font_set() constdrivers/ drivers/ drivers/ +3 more | +11 | 0 replies | |
| 37/47 | tty: vt: make consw::con_font_default()'s name constdrivers/ drivers/ drivers/ +1 more | +7 | 0 replies | |
| 38/47 | tty: vt: change consw::con_set_origin() return typedrivers/ include/ | +8 | 0 replies | |
| 39/47 | fbcon: remove consw::con_screen_pos()drivers/ | +0 | 0 replies | |
| 40/47 | tty: vt: remove consw::con_screen_pos()drivers/ include/ | +3 | 0 replies | |
| 41/47 | tty: vt: make types of screenpos() more consistentdrivers/ | +5 | 0 replies | |
| 42/47 | fbcon: remove fbcon_getxy()drivers/ | +0 | 0 replies | |
| 43/47 | tty: vt: remove consw::con_getxy()drivers/ include/ | +5 | 0 replies | |
| 44/47 | tty: vt: remove unused consw::con_flush_scrollback()drivers/ include/ | +12 | 0 replies | |
| 45/47 | tty: vt: document the rest of struct conswinclude/ | +25 | 0 replies | |
| 46/47 | tty: vt: fix up kernel-docdrivers/ drivers/ include/ | +62 | 1 reply | |
| 47/47 | Documentation: add console.rstDocumentation/ Documentation/ | +46 | 0 replies |
Reviews trailers per patch
2 of 47 patches have a Reviewed-by or Acked-by.
| Patch | Geert Uytterhoeven | Helge Deller | Randy Dunlap |
|---|---|---|---|
| Series | T-b | ||
| 1/47 | |||
| 2/47 | |||
| 3/47 | |||
| 4/47 | |||
| 5/47 | |||
| 6/47 | |||
| 7/47 | |||
| 8/47 | |||
| 9/47 | |||
| 10/47 | |||
| 11/47 | |||
| 12/47 | |||
| 13/47 | |||
| 14/47 | |||
| 15/47 | |||
| 16/47 | |||
| 17/47 | |||
| 18/47 | |||
| 19/47 | |||
| 20/47 | R-b | ||
| 21/47 | |||
| 22/47 | |||
| 23/47 | |||
| 24/47 | |||
| 25/47 | |||
| 26/47 | |||
| 27/47 | |||
| 28/47 | |||
| 29/47 | |||
| 30/47 | |||
| 31/47 | |||
| 32/47 | |||
| 33/47 | |||
| 34/47 | |||
| 35/47 | |||
| 36/47 | |||
| 37/47 | |||
| 38/47 | |||
| 39/47 | |||
| 40/47 | |||
| 41/47 | |||
| 42/47 | |||
| 43/47 | |||
| 44/47 | |||
| 45/47 | |||
| 46/47 | R-b | ||
| 47/47 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH v2 00/47] tty: vt: cleanup and documentation
Push the console code (vt.c, vt.h, console.h, ...) into a bit more maintainable state. Especially all around consw structure and document it.
CSI parser is also a bit cleaned up. More to follow some time in the next round.
[v2] See respective patches for changes. The major changes:
* vesa.h introduced
* parameters of csi*() simplified
Jiri Slaby (SUSE) (47):
vgacon: inline vc_scrolldelta_helper() into vgacon_scrolldelta()
fbcon: make display_desc a static array in fbcon_startup()
tty: vt: fix 20 vs 0x20 typo in EScsiignore
tty: vt: expect valid vc when in tty ops
tty: vt: pass proper pointers from tioclinux()
tty: vt: push console lock from tioclinux() down to 2 functions
tty: vt: pass vc_resize_user as a parameter
tty: vt: make vc_is_sel()'s vc const
tty: vt: define an enum for CSI+m codes
tty: vt: use case ranges for CSI+m fg/bg colors
tty: vt: define an enum for CSI+J codes
tty: vt: reflow csi_J()
use clamp() for counts in csi_?() handlers
don't pass vc->vc_par[0] to csi_?() handlers
tty: vt: define an enum for CSI+K codes
tty: vt: reflow csi_K()
tty: vt: define an enum for ascii characters
tty: vt: remove extern from functions in selection.h
tty: vt: make consw::con_debug_*() return void
tty: vt: make init parameter of consw::con_init() a bool
tty: vt: sanitize arguments of consw::con_clear()
tty: vt: remove checks for count in consw::con_clear() implementations
tty: vt: add con_putc() helper
tty: vt: eliminate unneeded consw::con_putc() implementations
tty: vt: sanitize consw::con_putc() parameters
tty: vt: sanitize consw::con_putcs() parameters
consoles: use if instead of switch-case in consw::con_cursor() fbdev/core: simplify cursor_state setting in fbcon_ops::cursor()
tty: vt: remove CM_* constants
tty: vt: make consw::con_switch() return a bool
tty: vt: stop using -1 for blank mode in consw::con_blank()
tty: vt: define a common enum for VESA blanking constants
tty: vt: use VESA blanking constants
tty: vt: use enum constants for VESA blanking modes
tty: vt: make types around consw::con_blank() bool
tty: vt: make font of consw::con_font_set() const
tty: vt: make consw::con_font_default()'s name const
tty: vt: change consw::con_set_origin() return type
fbcon: remove consw::con_screen_pos()
tty: vt: remove consw::con_screen_pos()
tty: vt: make types of screenpos() more consistent
fbcon: remove fbcon_getxy()
tty: vt: remove consw::con_getxy()
tty: vt: remove unused consw::con_flush_scrollback()
tty: vt: document the rest of struct consw
tty: vt: fix up kernel-doc
Documentation: add console.rst
Documentation/driver-api/tty/console.rst | 45 ++ Documentation/driver-api/tty/index.rst | 1 + drivers/tty/vt/selection.c | 43 +- drivers/tty/vt/vt.c | 645 +++++++++++------------ drivers/tty/vt/vt_ioctl.c | 6 +- drivers/video/console/dummycon.c | 38 +- drivers/video/console/mdacon.c | 43 +- drivers/video/console/newport_con.c | 69 +-- drivers/video/console/sticon.c | 79 ++- drivers/video/console/vgacon.c | 152 +++--- drivers/video/fbdev/core/bitblit.c | 13 +- drivers/video/fbdev/core/fbcon.c | 123 ++--- drivers/video/fbdev/core/fbcon.h | 4 +- drivers/video/fbdev/core/fbcon_ccw.c | 13 +- drivers/video/fbdev/core/fbcon_cw.c | 13 +- drivers/video/fbdev/core/fbcon_ud.c | 13 +- drivers/video/fbdev/core/tileblit.c | 4 +- include/linux/console.h | 124 +++-- include/linux/console_struct.h | 1 - include/linux/selection.h | 56 +- include/linux/vt_kern.h | 12 +- include/uapi/linux/fb.h | 8 +- include/uapi/linux/vesa.h | 18 + 23 files changed, 755 insertions(+), 768 deletions(-) create mode 100644 Documentation/driver-api/tty/console.rst create mode 100644 include/uapi/linux/vesa.h
Signature · 1 line
2.43.0