Skip to content

ppc: add machine check injection HMP command

Nicholas Piggin qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4nmi: add MCE class for implementing machine check injection commandshmp-commands.hx hw/core/nmi.c include/hw/nmi.h +4 more+112 -20 replies
2/4ppc/spapr: Implement mce injectionhw/ppc/spapr.c include/hw/ppc/spapr.h+57 -00 replies
3/4target/ppc: Add machine check interrupt injection helperhw/ppc/spapr_events.c target/ppc/excp_helper.c+8 -20 replies
4/4ppc/pnv: Implement mce injectionhw/ppc/pnv.c target/ppc/cpu.h+56 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] ppc: add machine check injection HMP command

I'd like to resurrect this and get it merged, because it's quite useful for testing (has caught several Linux bugs in the past).

IIRC the main concern David had last time it came up was that it should have QMP commands too. Which is valid. But I ended up deciding it wouldn't be nice to expose this low level interface too much, it would be better to use maybe a higher level error injection interface that would be emulated in more detail (e.g., not just a MCE, but would set relevant FIR registers and go through error handling logic).

Since x86 has a low level 'mce' hmp command without qmp equivalent, and since better error injection might take some time, I'd like to just hold nose and take this for now.

Thanks,
Nick

Nicholas Piggin (4):
nmi: add MCE class for implementing machine check injection commands ppc/spapr: Implement mce injection
target/ppc: Add machine check interrupt injection helper ppc/pnv: Implement mce injection

 include/hw/nmi.h             | 20 ++++++++++++
 include/hw/ppc/spapr.h       |  3 ++
 include/monitor/hmp-target.h |  1 -
 include/monitor/hmp.h        |  1 +
 target/ppc/cpu.h             |  1 +
 hw/core/nmi.c                | 61 ++++++++++++++++++++++++++++++++++++
 hw/ppc/pnv.c                 | 55 ++++++++++++++++++++++++++++++++
 hw/ppc/spapr.c               | 54 +++++++++++++++++++++++++++++++
 hw/ppc/spapr_events.c        |  3 +-
 monitor/hmp-cmds.c           |  1 +
 target/ppc/excp_helper.c     |  7 +++++
 target/ppc/ppc-qmp-cmds.c    | 10 ++++++
 hmp-commands.hx              | 20 +++++++++++-
 13 files changed, 233 insertions(+), 4 deletions(-)
Signature · 1 line
2.42.0