Skip to content

net: hifemac: a few cleanups

Yang Xiwen b4-sent u-boot 3 versions – In review

Get series with b4
b4 am [email protected] change-id 20240119-net-72a32675eeb4

Versions newest first

  1. v3 Latest5 patches 1 replyIn review
  2. v24 patches 0 repliesSuperseded
  3. v13 patches 0 repliesSuperseded

Changes in v3 from the cover letter

- hisi-femac: add missing static to avoid polluting global namespace.
- Link to v2: https://lore.kernel.org/r/[email protected]

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5net: hifemac_mdio: use log_msg_ret() correctly, report error by dev_err()drivers/net/hifemac_mdio.c+8 -31 reply
2/5net: hifemac: fix log reportingdrivers/net/hifemac.c+73 -370 replies
3/5net: hifemac: register MDIO bus device for subnodedrivers/net/hifemac.c+28 -00 replies
4/5net: hifemac: implement `net stats` needed opsdrivers/net/hifemac.c+87 -00 replies
5/5net: hifemac: make some functions staticdrivers/net/hifemac.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/5] net: hifemac: a few cleanups

- Fix the use of log_msg_ret() and add dev_xxx() for error reporting.
- Register mdio subnode as a mdio bus device for hifemac.
- Implement ops needed by net stats
- Make functions static.

---
Changes in v3:
- hisi-femac: add missing static to avoid polluting global namespace.
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- hisi-femac: add statistics related operations
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Yang Xiwen (5):
net: hifemac_mdio: use log_msg_ret() correctly, report error by dev_err()
net: hifemac: fix log reporting
net: hifemac: register MDIO bus device for subnode
net: hifemac: implement net stats needed ops
net: hifemac: make some functions static

 drivers/net/hifemac.c      | 229 +++++++++++++++++++++++++++++++++++++--------
 drivers/net/hifemac_mdio.c |  11 ++-
 2 files changed, 198 insertions(+), 42 deletions(-)

---
base-commit: f7cca7ccc5117eaafcc2bde91ad1bed6fee7cfc3
change-id: 20240119-net-72a32675eeb4

Best regards,

Signature · 1 line
Yang Xiwen <[email protected]>