Skip to content

ui/spice: Enable gl=on option for non-local or remote clients

Vivek Kasireddy qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7ui/spice: Add an option for users to provide a preferred codecqemu-options.hx ui/spice-core.c+17 -02 replies
2/7ui/spice: Enable gl=on option for non-local or remote clientsinclude/ui/spice-display.h ui/spice-core.c ui/spice-display.c+6 -02 replies
3/7ui/spice: Submit the gl_draw requests at 60 FPS for remote clientsui/spice-display.c+28 -102 replies
4/7ui/console-gl: Add an option to override a surface's glformatinclude/ui/surface.h ui/console-gl.c+7 -00 replies
5/7ui/spice: Override the surface's glformat when gl=on is enabledui/spice-display.c+3 -00 replies
6/7ui/console-gl: Add a helper to create a texture with linear memory layoutinclude/ui/console.h ui/console-gl.c+28 -00 replies
7/7ui/spice: Create another texture with linear layout when gl=on is enabledui/spice-display.c+33 -02 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/7] ui/spice: Enable gl=on option for non-local or remote clients

To address the limitation that this option is incompatible with remote clients, this patch series adds an option to select a preferred codec and also enable gl=on option for clients that are connected via the network. In other words, with this option enabled (and the below linked Spice series merged), it would be possible to have Qemu share a dmabuf fd with Spice, which would then forward it to a hardware or software based encoder and eventually send the data associated with the fd to a client that could be located on a different machine.

Tested with: -device virtio-vga,max_outputs=1,xres=1920,yres=1080
-spice port=3001,gl=on,disable-ticketing=on,preferred-codec=gstreamer:h264

and remote-viewer --spice-debug spice://x.x.x.x:3001 on the client side.

---
Associated Spice server patches can be found here:
https://lists.freedesktop.org/archives/spice-devel/2023-December/053288.html

Cc Gerd Hoffmann <[email protected]>
Cc Marc-André Lureau <[email protected]>
Cc Frediano Ziglio <[email protected]>
Cc Dongwon Kim <[email protected]>

Vivek Kasireddy (7):
ui/spice: Add an option for users to provide a preferred codec ui/spice: Enable gl=on option for non-local or remote clients ui/spice: Submit the gl_draw requests at 60 FPS for remote clients ui/console-gl: Add an option to override a surface's glformat ui/spice: Override the surface's glformat when gl=on is enabled ui/console-gl: Add a helper to create a texture with linear memory
layout
ui/spice: Create another texture with linear layout when gl=on is
enabled

 include/ui/console.h       |  2 +
 include/ui/spice-display.h |  1 +
 include/ui/surface.h       |  1 +
 qemu-options.hx            |  5 +++
 ui/console-gl.c            | 32 ++++++++++++++++
 ui/spice-core.c            | 16 ++++++++
 ui/spice-display.c         | 75 +++++++++++++++++++++++++++++++++-----
 7 files changed, 122 insertions(+), 10 deletions(-)
Signature · 1 line
2.39.2