Skip to content

log both average and max values over the window

Ankit Kumar fio 3 versions – Applied

Status from this message: Applied. Thanks.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 1 replyApplied
  2. v22 patches 1 replySuperseded
  3. v12 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- Fix man page as suggested by Vincent.

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2stat: log out both average and max over the windowclient.c iolog.c iolog.h +3 more+128 -450 replies
2/2docs: update fio man page for log_window_valueHOWTO.rst fio.1+72 -200 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] log both average and max values over the window

This series adds an alias log_window_value to option log_max_value which now report average, max or both the values. The log_window_value option type has been changed from boolean to string but retains backward compatibility by allowing =0 and =1 values to specify avg and max values respectively.
There is no change to existing log formats while reporting only average or max values.

The fio documentation has been updated specifying the new log format when both values are reported.

Changes since v2:
- Fix man page as suggested by Vincent.

Changes since v1:
- Use posval for strings instead of magic numbers as suggested by Jens.
- Change option name to log_window_value and add alias to log_max_value as suggested by Vincent.

Ankit Kumar (2):
stat: log out both average and max over the window
docs: update fio man page for log_window_value

 HOWTO.rst | 45 +++++++++++++++++++++++++--------
 client.c  |  6 +++--
 fio.1     | 47 +++++++++++++++++++++++++++--------
 iolog.c   | 74 ++++++++++++++++++++++++++++++++++++++++---------------
 iolog.h   | 21 +++++++++++++---
 options.c | 34 +++++++++++++++++++++----
 server.c  |  6 +++--
 stat.c    | 32 ++++++++++++++----------
 8 files changed, 200 insertions(+), 65 deletions(-)
Signature · 1 line
2.25.1